Re: CVS commit: src/usr.sbin/powerd
On Thu, Jan 28, 2010 at 04:43:25AM +, David Holland wrote: If some people do care, changing the perception might prompt someone to do something about it. Maybe. It's probably a good chunk of work and there's not much bang for the buck. I tried, but it's not obvious [PR 37434, if anyone cares]. But my main point was: why bother with an extra directory for APM scripts while - obvisouly nobody uses APM - APM is expected to go away completely - it is unclear how scripts could make use of the fact which subsystem triggered the pmf event they are dealing with Martin
CVS commit: src/sys/miscfs/genfs
Module Name:src Committed By: uebayasi Date: Thu Jan 28 08:20:00 UTC 2010 Modified Files: src/sys/miscfs/genfs: genfs_io.c Log Message: genfs_getpages: Constify 2 variables, move one. No functional changes. To generate a diff of this commit: cvs rdiff -u -r1.29 -r1.30 src/sys/miscfs/genfs/genfs_io.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/powerpc/powerpc
Module Name:src Committed By: phx Date: Thu Jan 28 12:37:45 UTC 2010 Modified Files: src/sys/arch/powerpc/powerpc: db_disasm.c db_interface.c pmap_subr.c Log Message: Fixed typo: PPC_OEA64_BIRDGE - PPC_OEA64_BRIDGE To generate a diff of this commit: cvs rdiff -u -r1.23 -r1.24 src/sys/arch/powerpc/powerpc/db_disasm.c cvs rdiff -u -r1.40 -r1.41 src/sys/arch/powerpc/powerpc/db_interface.c cvs rdiff -u -r1.21 -r1.22 src/sys/arch/powerpc/powerpc/pmap_subr.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/powerpc/powerpc
Module Name:src Committed By: phx Date: Thu Jan 28 12:45:01 UTC 2010 Modified Files: src/sys/arch/powerpc/powerpc: db_disasm.c db_interface.c Log Message: Reverted last commit for db_disasm.c and db_inteface.c. Sorry, erroneously commited them... To generate a diff of this commit: cvs rdiff -u -r1.24 -r1.25 src/sys/arch/powerpc/powerpc/db_disasm.c cvs rdiff -u -r1.41 -r1.42 src/sys/arch/powerpc/powerpc/db_interface.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/miscfs/genfs
Module Name:src Committed By: uebayasi Date: Thu Jan 28 13:43:53 UTC 2010 Modified Files: src/sys/miscfs/genfs: genfs_io.c Log Message: genfs_getpages: More constification localization. To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31 src/sys/miscfs/genfs/genfs_io.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/share
Module Name:src Committed By: mbalmer Date: Thu Jan 28 14:05:03 UTC 2010 Modified Files: src/share/doc/psd/05.sysman: 2.3.t src/share/termcap: termcap.src Log Message: Fix language. To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/share/doc/psd/05.sysman/2.3.t cvs rdiff -u -r1.102 -r1.103 src/share/termcap/termcap.src Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/miscfs/genfs
Log Message:
Revert part which variable initializations within interleaved gotos.
again:
if (...) goto err;
void *ptr = alloc();
if (...) goto again;
if (...) goto err1;
...
err1: if (ptr) free(ptr);
err:
return;
This leaks memory if exited with goto again; - goto err;.
Actually it did NOT. Because the if (...) goto again; part carefully
free()'ed the object. In the actual code:
312 if (vp-v_size origvsize) {
313 rw_exit(gp-g_glock);
314 if (pgs != pgs_onstack)
315 kmem_free(pgs, pgs_size);
316 goto startover;
317 }
Masao
--
Masao Uebayashi / Tombi Inc. / Tel: +81-90-9141-4635
Re: CVS commit: src
| I think that vasnprintf and asnprintf are not used by anything in | heimdal and can safely be removed. Combined with the winsize fix, | this fixes the cygwin problems with minimal changes. I am trying a | build now. | | Note roken.h includes resolv.h and arpa/nameser.h that don't | exist on Cygwin so we had to handle it in src/tools/compat/configure. | (toolchain/29032) Which is fine; I'd rather have one place to keep roken.h and deal with portability in compat, rather than 2. But src/include/heimdal/roken.h is a generated file for NetBSD with unusual method. We might be able to generate roken.h for tools host from src/crypto/dist/heimdal/lib/roken/roken.h.in using src/crypto/dist/heimdal/lib/roken/roken.awk as defined in src/crypto/dist/heimdal/lib/roken/Makefile.am: --- roken.h: make-roken$(EXEEXT) @./make-roken$(EXEEXT) tmp.h ;\ if [ -f roken.h ] cmp -s tmp.h roken.h ; then rm -f tmp.h ; \ else rm -f roken.h; mv tmp.h roken.h; fi make-roken.c: roken.h.in roken.awk $(AWK) -f $(srcdir)/roken.awk $(srcdir)/roken.h.in make-roken.c --- but it requires all macros like HAVE_FOO referred in roken.h.in and we have to add checks for them into src/tools/compat/configure.ac, as defined in src/include/heimdal/config.h configured for NetBSD. Is it really worth than adding a manually edited dumb roken.h for tools? --- Izumi Tsutsui
CVS commit: [matt-nb5-mips64] src/distrib/sets/lists
Module Name:src Committed By: matt Date: Thu Jan 28 17:10:21 UTC 2010 Modified Files: src/distrib/sets/lists/base [matt-nb5-mips64]: ad.mips64eb ad.mips64el md.amd64 md.sparc64 src/distrib/sets/lists/comp [matt-nb5-mips64]: ad.mips64eb ad.mips64el md.amd64 md.sparc64 Log Message: libsupc++ doesn't have a shared library. To generate a diff of this commit: cvs rdiff -u -r1.1.2.2 -r1.1.2.3 src/distrib/sets/lists/base/ad.mips64eb \ src/distrib/sets/lists/base/ad.mips64el cvs rdiff -u -r1.25.2.2.2.1 -r1.25.2.2.2.1.2.1 \ src/distrib/sets/lists/base/md.amd64 cvs rdiff -u -r1.23.2.2.2.1 -r1.23.2.2.2.1.2.1 \ src/distrib/sets/lists/base/md.sparc64 cvs rdiff -u -r1.1.2.2 -r1.1.2.3 src/distrib/sets/lists/comp/ad.mips64eb \ src/distrib/sets/lists/comp/ad.mips64el cvs rdiff -u -r1.39.2.3 -r1.39.2.3.4.1 src/distrib/sets/lists/comp/md.amd64 cvs rdiff -u -r1.37.2.3 -r1.37.2.3.4.1 src/distrib/sets/lists/comp/md.sparc64 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [matt-nb5-mips64] src/gnu/dist/binutils/bfd
Module Name:src
Committed By: matt
Date: Thu Jan 28 17:13:53 UTC 2010
Modified Files:
src/gnu/dist/binutils/bfd [matt-nb5-mips64]: config.bfd
Log Message:
Switch to using bfd_elf32_ntrad{little,big]mips_vec because the non-trad is
for IRIX systems and bfd does weird things for/because of IRIX. With this
change C++ programs build and link correctly.
To generate a diff of this commit:
cvs rdiff -u -r1.14.24.2 -r1.14.24.3 src/gnu/dist/binutils/bfd/config.bfd
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: [matt-nb5-mips64] src/sys/dev/pci
Module Name:src Committed By: matt Date: Thu Jan 28 17:42:37 UTC 2010 Modified Files: src/sys/dev/pci [matt-nb5-mips64]: ppb.c Log Message: Change ppb_fix_pcix to ppb_fix_pcie since pcix is usually PCI-X while pcie is PCI-Express. To generate a diff of this commit: cvs rdiff -u -r1.39.18.1 -r1.39.18.2 src/sys/dev/pci/ppb.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [matt-nb5-mips64] src/sys/dev/mii
Module Name:src Committed By: matt Date: Thu Jan 28 17:43:11 UTC 2010 Modified Files: src/sys/dev/mii [matt-nb5-mips64]: mvphy.c Log Message: Fix a split device_t/softc botch. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.7.14.1 src/sys/dev/mii/mvphy.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/usr.sbin/powerd
On Jan 28, 2010, at 12:19 AM, Martin Husemann wrote: - it is unclear how scripts could make use of the fact which subsystem triggered the pmf event they are dealing with When I wrote that code, I did hot have a concrete example usage scenario for power-type-specific scripts, but since these scripts essentially embody configuration information, it did seem reasonable to allow for such a scenario. -- thorpej
CVS commit: src/sys/dev/putter
Module Name:src Committed By: pooka Date: Thu Jan 28 18:12:56 UTC 2010 Modified Files: src/sys/dev/putter: putter.c Log Message: Adjust some comments which were written when this was still a part of puffs. To generate a diff of this commit: cvs rdiff -u -r1.26 -r1.27 src/sys/dev/putter/putter.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/powerpc
Module Name:src Committed By: phx Date: Thu Jan 28 21:10:49 UTC 2010 Modified Files: src/sys/arch/powerpc/include: db_machdep.h src/sys/arch/powerpc/powerpc: db_interface.c Log Message: New machine commands for PPC OEA: bat: prints the BAT registers and translations mmu: prints MMU registers (sdr1, sr0..15) To generate a diff of this commit: cvs rdiff -u -r1.20 -r1.21 src/sys/arch/powerpc/include/db_machdep.h cvs rdiff -u -r1.42 -r1.43 src/sys/arch/powerpc/powerpc/db_interface.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/share/man/man4
Module Name:src Committed By: phx Date: Thu Jan 28 21:13:49 UTC 2010 Modified Files: src/share/man/man4: ddb.4 Log Message: New machine commands for PPC OEA. bat: prints the BAT registers and translations mmu: prints MMU registers (sdr1, sr0..15) Previous PPC commands were for IBM4xx only, so make two sections now: POWERPC 4xx and POWERPC OEA. To generate a diff of this commit: cvs rdiff -u -r1.131 -r1.132 src/share/man/man4/ddb.4 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/bsd/libelf/dist
Module Name:src Committed By: darran Date: Thu Jan 28 21:38:29 UTC 2010 Modified Files: src/external/bsd/libelf/dist: elf_data.c elf_getdata.3 Log Message: Fix a problem with the handling of NOBITS sections (i.e. bss), where the elf_getdata() function would return an invalid section error if the size of the section was bigger than the raw size of the elf binary. This is basically a sync with changeset 10 of the sourceforge repository for this library (elftoolchain). To generate a diff of this commit: cvs rdiff -u -r1.3 -r1.4 src/external/bsd/libelf/dist/elf_data.c cvs rdiff -u -r1.1.1.1 -r1.2 src/external/bsd/libelf/dist/elf_getdata.3 Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [matt-nb5-mips64] src/sys/arch
Module Name:src Committed By: matt Date: Fri Jan 29 00:16:58 UTC 2010 Modified Files: src/sys/arch/algor/conf [matt-nb5-mips64]: P5064 P5064-64 src/sys/arch/evbmips/conf [matt-nb5-mips64]: ADM5120 ADM5120-NB ADM5120-USB ALCHEMY AP30 MALTA MALTA64 MERAKI RB153 WGT624V3 XLSATX src/sys/arch/hpcmips/conf [matt-nb5-mips64]: std.hpcmips std.lcard src/sys/arch/mips/conf [matt-nb5-mips64]: files.mips src/sys/arch/mips/mips [matt-nb5-mips64]: compat_16_machdep.c fp.S locore.S mips_emul.c mips_fputrap.c trap.c src/sys/arch/sbmips/conf [matt-nb5-mips64]: GENERIC Log Message: Change mips kernel options SOFTFLOAT to FPEMUL. Allow a kernel to have no FP emulation code. Fix insufficient SYMTAB_SPACE. When a kernel without an FPU and with FPEMUL code, the application will trap with a SIGILL/ILL_ILLOPC signal, not SIGSEGV/SEGV_MAPERR. To generate a diff of this commit: cvs rdiff -u -r1.54 -r1.54.8.1 src/sys/arch/algor/conf/P5064 cvs rdiff -u -r1.1.2.1 -r1.1.2.2 src/sys/arch/algor/conf/P5064-64 cvs rdiff -u -r1.3 -r1.3.12.1 src/sys/arch/evbmips/conf/ADM5120 \ src/sys/arch/evbmips/conf/ADM5120-NB cvs rdiff -u -r1.2 -r1.2.58.1 src/sys/arch/evbmips/conf/ADM5120-USB \ src/sys/arch/evbmips/conf/RB153 cvs rdiff -u -r1.20.8.1 -r1.20.8.2 src/sys/arch/evbmips/conf/ALCHEMY cvs rdiff -u -r1.10 -r1.10.8.1 src/sys/arch/evbmips/conf/AP30 cvs rdiff -u -r1.48.8.2 -r1.48.8.3 src/sys/arch/evbmips/conf/MALTA cvs rdiff -u -r1.1.2.3 -r1.1.2.4 src/sys/arch/evbmips/conf/MALTA64 cvs rdiff -u -r1.6 -r1.6.8.1 src/sys/arch/evbmips/conf/MERAKI cvs rdiff -u -r1.3 -r1.3.8.1 src/sys/arch/evbmips/conf/WGT624V3 cvs rdiff -u -r1.1.2.4 -r1.1.2.5 src/sys/arch/evbmips/conf/XLSATX cvs rdiff -u -r1.19 -r1.19.96.1 src/sys/arch/hpcmips/conf/std.hpcmips cvs rdiff -u -r1.7 -r1.7.76.1 src/sys/arch/hpcmips/conf/std.lcard cvs rdiff -u -r1.58.24.5 -r1.58.24.6 src/sys/arch/mips/conf/files.mips cvs rdiff -u -r1.12.14.2 -r1.12.14.3 \ src/sys/arch/mips/mips/compat_16_machdep.c cvs rdiff -u -r1.33.38.7 -r1.33.38.8 src/sys/arch/mips/mips/fp.S cvs rdiff -u -r1.167.38.5 -r1.167.38.6 src/sys/arch/mips/mips/locore.S cvs rdiff -u -r1.14.78.7 -r1.14.78.8 src/sys/arch/mips/mips/mips_emul.c cvs rdiff -u -r1.5.66.2 -r1.5.66.3 src/sys/arch/mips/mips/mips_fputrap.c cvs rdiff -u -r1.217.12.15 -r1.217.12.16 src/sys/arch/mips/mips/trap.c cvs rdiff -u -r1.70.8.3 -r1.70.8.4 src/sys/arch/sbmips/conf/GENERIC Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [matt-nb5-mips64] src/sys/arch/mips/rmi
Module Name:src Committed By: cliff Date: Fri Jan 29 00:21:49 UTC 2010 Modified Files: src/sys/arch/mips/rmi [matt-nb5-mips64]: rmixlreg.h Log Message: - add RMIXL_ADDR_ERR_DEVICE_MASK_2 reg - add RMIXL_GPIO_LOW_PWR_DIS bit defines To generate a diff of this commit: cvs rdiff -u -r1.1.2.7 -r1.1.2.8 src/sys/arch/mips/rmi/rmixlreg.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [matt-nb5-mips64] src/sys/arch/mips/rmi
Module Name:src Committed By: cliff Date: Fri Jan 29 00:22:06 UTC 2010 Modified Files: src/sys/arch/mips/rmi [matt-nb5-mips64]: rmixlvar.h Log Message: - add enum and display name lookup for firmware type - firmware type field added to rmixl_config - rmixl_cache_err_dis, rmixl_cache_err_restore, rmixl_cache_err_check inlines moved here from pcie driver - add rmixl_probe_4 nofault address probe inline To generate a diff of this commit: cvs rdiff -u -r1.1.2.12 -r1.1.2.13 src/sys/arch/mips/rmi/rmixlvar.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [matt-nb5-mips64] src/sys/arch/mips/rmi
Module Name:src Committed By: cliff Date: Fri Jan 29 00:22:53 UTC 2010 Modified Files: src/sys/arch/mips/rmi [matt-nb5-mips64]: rmixl_cpu.c Log Message: - avoid cpu_wakeup callback if running on PSB_TYPE_DELL firmware To generate a diff of this commit: cvs rdiff -u -r1.1.2.3 -r1.1.2.4 src/sys/arch/mips/rmi/rmixl_cpu.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [matt-nb5-mips64] src/sys/arch/mips/rmi
Module Name:src Committed By: cliff Date: Fri Jan 29 00:23:35 UTC 2010 Modified Files: src/sys/arch/mips/rmi [matt-nb5-mips64]: rmixl_pcievar.h Log Message: - add pcie interrupt dispatch stuff To generate a diff of this commit: cvs rdiff -u -r1.1.2.2 -r1.1.2.3 src/sys/arch/mips/rmi/rmixl_pcievar.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [matt-nb5-mips64] src/sys/arch/mips/rmi
Module Name:src Committed By: cliff Date: Fri Jan 29 00:24:14 UTC 2010 Modified Files: src/sys/arch/mips/rmi [matt-nb5-mips64]: rmixl_intr.c Log Message: - be more thorough about 'mips_cpu_id' based variations - rip out pcie interrupt related debug stuff - start thinking about MULTIPROCESSOR IRT entries in rmixl_intr_irt_init() To generate a diff of this commit: cvs rdiff -u -r1.1.2.7 -r1.1.2.8 src/sys/arch/mips/rmi/rmixl_intr.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: [matt-nb5-mips64] src/sys/arch/mips/rmi
Module Name:src Committed By: cliff Date: Fri Jan 29 00:24:33 UTC 2010 Modified Files: src/sys/arch/mips/rmi [matt-nb5-mips64]: rmixl_usbi.c Log Message: - use rmixl_probe_4 to match - fail attach if USB interface is disabled GPIO LOW_PWR_DIS reg (?) - fail attach if USB interface BIST failed (?) - enable HW byteswap enable if LITTLE_ENDIAN To generate a diff of this commit: cvs rdiff -u -r1.1.2.2 -r1.1.2.3 src/sys/arch/mips/rmi/rmixl_usbi.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src
On Thu, Jan 28, 2010 at 06:42:16AM +, YAMAMOTO Takashi wrote: ISTM that section 9 is an appropriate place for both interface and implementation docs. In the (few) cases where we actually have an interface, as opposed to some exposed pieces of the implementation, the documentation should be clear on which is which and which properties of the implementation are actually guaranteed by the interface and which aren't. let's stop being too generic and go back to the change in question. do you think this man page is an appropriate place for these functions? Given that they exist in several MD implementations and (I think) are more or less the same in at least some of those, yes, provided they're documented as a piece of internals. some MD implementations might have this for their internal use? it sounds useless and confusing to me. comments along the code itself is far more appropriate for this kind of descriptions because they have more chance to be up-to-date and someone who cares MD implementation details likely will look at the code anyway. Of course, we could get rid of them and move to MI spl functions :-) (see tech-kern, ad@ just found the thread and thereby reminded me of it) we are discussing if we want to describe MD internal details in the man page of MI spl interfaces. YAMAMOTO Takashi (why tech-pkg, btw?) I was wondering about that... -- David A. Holland dholl...@netbsd.org
CVS commit: src/sys/miscfs/genfs
Module Name:src Committed By: uebayasi Date: Fri Jan 29 04:36:20 UTC 2010 Modified Files: src/sys/miscfs/genfs: genfs_io.c Log Message: genfs_getpages: Narrow clarify the context where I/O happens vmobjlock is dropped. To generate a diff of this commit: cvs rdiff -u -r1.33 -r1.34 src/sys/miscfs/genfs/genfs_io.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/sys/arch/sparc/include
Module Name:src Committed By: mrg Date: Fri Jan 29 05:14:11 UTC 2010 Modified Files: src/sys/arch/sparc/include: proc.h Log Message: make fpu_mtx visible only ifdef _KERNEL. To generate a diff of this commit: cvs rdiff -u -r1.17 -r1.18 src/sys/arch/sparc/include/proc.h Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/gpl3/binutils/dist/ld
Module Name:src Committed By: matt Date: Fri Jan 29 06:05:32 UTC 2010 Modified Files: src/external/gpl3/binutils/dist/ld: configure.tgt Log Message: Remove redundant mips*-*-netbsd* clause To generate a diff of this commit: cvs rdiff -u -r1.5 -r1.6 src/external/gpl3/binutils/dist/ld/configure.tgt Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
CVS commit: src/external/gpl3/binutils/dist/bfd
Module Name:src
Committed By: matt
Date: Fri Jan 29 06:08:01 UTC 2010
Modified Files:
src/external/gpl3/binutils/dist/bfd: config.bfd
Log Message:
Use bfd_ntrad{little,big}_vec and drop all non-trad vectors since they
make target matching ambiguous.
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/external/gpl3/binutils/dist/bfd/config.bfd
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
CVS commit: src/external/gpl3/binutils/dist/bfd
Module Name:src Committed By: matt Date: Fri Jan 29 06:09:37 UTC 2010 Modified Files: src/external/gpl3/binutils/dist/bfd: elfn32-mips.c Log Message: Add a _is_local_label_name routine (taken from elf64-mips.c). To generate a diff of this commit: cvs rdiff -u -r1.1.1.1 -r1.2 \ src/external/gpl3/binutils/dist/bfd/elfn32-mips.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
