Re: CVS commit: src/sys/dev/ieee1394

2010-08-31 Thread Christoph Egger 
On 26.08.10 16:31, Mindaugas Rasiukevicius wrote:
 Module Name:src
 Committed By:   cegger
 Date:   Thu Aug 26 12:48:19 UTC 2010

 Modified Files:
 src/sys/dev/ieee1394: fwdev.c

 Log Message:
 don't call tsleep() with any mutexes hold


 To generate a diff of this commit:
 cvs rdiff -u -r1.23 -r1.24 src/sys/dev/ieee1394/fwdev.c
 
 The right fix would be to use condvar(9).  Generally, tsleep(9) should
 be replaced and removed in the longer term.

Sure. Two questions hold me back from doing this:
1. Which cv_*wait* variant should be used?
2. Where should I add the corresponding cv_signal/cv_broadcast ?

Is it possible to have an conversion example in the tsleep(9) manpage?

Christoph

Re: CVS commit: src

2010-08-31 Thread Tom Spindler 
   src/sys/sys: exec_elf.h
 
 Log Message:
 Replace the current usage of Elf64_Half with Elf64_Word and rename
 NetBSD specific Elf64_Quarter to Elf64_Half. This restores compatibility
 with the common ELF specifications.

I believe this change is what's causing alpha to blow up:

/src/nbsrc/external/bsd/libdwarf/dist/dwarf_dump.c:884: warning: format '%u' 
expects type 'unsigned int', but argument 2 has type 'Elf64_Word'
/src/nbsrc/external/bsd/libdwarf/dist/dwarf_dump.c:886: warning: format '%u' 
expects type 'unsigned int', but argument 3 has type 'Elf64_Word'

There's (still) a ton of lint warnings in libdwarf, but they don't seem to
have changed for i386, at least.

Re: CVS commit: src

2010-08-31 Thread Valeriy E. Ushakov 
On Tue, Aug 31, 2010 at 16:24:40 +, Tom Spindler wrote:

  src/sys/sys: exec_elf.h
  
  Log Message:
  Replace the current usage of Elf64_Half with Elf64_Word and rename
  NetBSD specific Elf64_Quarter to Elf64_Half. This restores compatibility
  with the common ELF specifications.
 
 I believe this change is what's causing alpha to blow up:
 
 /src/nbsrc/external/bsd/libdwarf/dist/dwarf_dump.c:884: warning: format '%u' 
 expects type 'unsigned int', but argument 2 has type 'Elf64_Word'
 /src/nbsrc/external/bsd/libdwarf/dist/dwarf_dump.c:886: warning: format '%u' 
 expects type 'unsigned int', but argument 3 has type 'Elf64_Word'
 
 There's (still) a ton of lint warnings in libdwarf, but they don't seem to
 have changed for i386, at least.


sys/arch/alpha/include/elf_machdep.h:

/*
 * Alpha ELF uses different (non-standard) definitions of Elf64_Sword
 * and Elf64_Word.
 */
typedef int64_t Elf64_Sword;
#define ELF64_FSZ_SWORD 8
typedef uint64_tElf64_Word;
#define ELF64_FSZ_WORD  8


-uwe

Re: CVS commit: src

2010-08-31 Thread Joerg Sonnenberger 
On Tue, Aug 31, 2010 at 08:43:33PM +0400, Valeriy E. Ushakov wrote:
 On Tue, Aug 31, 2010 at 16:24:40 +, Tom Spindler wrote:
 
 src/sys/sys: exec_elf.h
   
   Log Message:
   Replace the current usage of Elf64_Half with Elf64_Word and rename
   NetBSD specific Elf64_Quarter to Elf64_Half. This restores compatibility
   with the common ELF specifications.
  
  I believe this change is what's causing alpha to blow up:
  
  /src/nbsrc/external/bsd/libdwarf/dist/dwarf_dump.c:884: warning: format 
  '%u' expects type 'unsigned int', but argument 2 has type 'Elf64_Word'
  /src/nbsrc/external/bsd/libdwarf/dist/dwarf_dump.c:886: warning: format 
  '%u' expects type 'unsigned int', but argument 3 has type 'Elf64_Word'
  
  There's (still) a ton of lint warnings in libdwarf, but they don't seem to
  have changed for i386, at least.
 
 
 sys/arch/alpha/include/elf_machdep.h:
 
 /*
  * Alpha ELF uses different (non-standard) definitions of Elf64_Sword
  * and Elf64_Word.
  */
 typedef   int64_t Elf64_Sword;
 #define   ELF64_FSZ_SWORD 8
 typedef   uint64_tElf64_Word;
 #define   ELF64_FSZ_WORD  8

That violates the ELF API as specified by SCO again. Is there any reason
why Alpha has to be special and can't just use the standard types?

Joerg

Re: CVS commit: src/sys/ddb

2010-08-31 Thread Simon Burge 
Thor Lancelot Simon wrote:

 Module Name:  src
 Committed By: tls
 Date: Mon Aug 30 19:23:26 UTC 2010
 
 Modified Files:
 
   src/sys/ddb: db_input.c

Was there any particular reason for removing the lint directives in this
change?  Eg:

-   } while (/*CONSTCOND*/ 0)
+} while (0)

Cheers,
Simon.

Re: CVS commit: src/sys/ddb

2010-08-31 Thread Thor Lancelot Simon 
On Wed, Sep 01, 2010 at 06:01:23AM +1000, Simon Burge wrote:
 Thor Lancelot Simon wrote:
 
  Module Name:src
  Committed By:   tls
  Date:   Mon Aug 30 19:23:26 UTC 2010
  
  Modified Files:
  
  src/sys/ddb: db_input.c
 
 Was there any particular reason for removing the lint directives in this
 change?  Eg:
 
 -   } while (/*CONSTCOND*/ 0)
 +} while (0)

No.

Thor