Re: CVS commit: src/sys/kern

[Andrew Doran]

On Thu, Oct 14, 2010 at 04:59:42AM +0100, Mindaugas Rasiukevicius wrote:
> Hello,
> 
> "Masaru OKI"  wrote:
> > Module Name:src
> > Committed By:   oki
> > Date:   Thu Oct 14 03:07:52 UTC 2010
> > 
> > Modified Files:
> > src/sys/kern: uipc_socket.c
> > 
> > Log Message:
> > Wait for freeing mbuf cluster in sosend() causes freeze network stack.
> > Don't wait for it.
> > problem was found by iij seil team.
> > it is similar to OpenBSD uipc_socket.c rev.1.72.
> 
> Can you explain what the actual problem M_WAIT causes i.e. how would
> it "freeze network stack"?

I don't see what it would solve on the face of it, but regardless M_DONTWAIT
is almost certainly the wrong thing to do here.

Re: CVS commit: src/sys/kern

[Takahiro Kambe]

In message <20101014004717.7887917...@cvs.netbsd.org>
on Thu, 14 Oct 2010 00:47:17 +,
"matthew green"  wrote:
> Module Name:  src
> Committed By: mrg
> Date: Thu Oct 14 00:47:17 UTC 2010
> 
> Modified Files:
>   src/sys/kern: subr_disk.c
> 
> Log Message:
> add some (uint64_t) casts so avoid 32 bit overflows.  this fixes my
> 3TB disk with 4KB sectors and disklabel (which looks like it would
> work upto 16TB.)
> 
> idea from mlel...@.
I think that this small fix should be pulled up to netbsd-4/netbsd-5
branches.

-- 
Takahiro Kambe