Re: CVS commit: src/sbin/disklabel

2011-01-08 Thread Izumi Tsutsui
 Modified Files:
   src/sbin/disklabel: interact.c main.c printlabel.c
 
 Log Message:
 Change printf formats to match the data type of the values being
 printed.  There's now a lot of PRIu16 and PRIu32, some PRIu8, some
 SCNu32, and a few cases where %u and %d were reversed.

Probably you also have to add them (at least PRIu8 and SCNu32)
into tools/compat/compat_defs.h for src/tools/disklabel.
---
Izumi Tsutsui


Re: CVS commit: src/usr.sbin/iostat

2011-01-08 Thread Martin Husemann
On Sat, Jan 08, 2011 at 05:12:00PM +, Matthias Scheler wrote:
 Why not? It doesn't sound hard to do that based on the manual page.

Because it special cases +0.0  -0.0 and also claims to deal with NaNs.
We problaby should do a naive implementation and conditionalize the man
page claims on architectures where such concepts exists.

Martin


Re: CVS commit: src/etc/rc.d

2011-01-08 Thread David Holland
On Sat, Jan 08, 2011 at 04:16:52PM +, Adam Hamsik wrote:
  Modified Files:
   src/etc/rc.d: mountcritlocal
  
  Log Message:
  Use /rescue/chown not chown from /usr/sbin which might not be available in
  time of running this script.
  
  XXX. Why is chown in /usr/sbin ? it should be moved to /sbin

Because historically nothing needed to be chowned during boot because
it was all root.

This is no longer true, for lvm and other things, so let's take a deep
breath and move chown. I don't like the idea of having rc.d scripts
depend on /rescue.

-- 
David A. Holland
dholl...@netbsd.org


Re: CVS commit: src/bin/sh

2011-01-08 Thread David Holland
On Sat, Jan 08, 2011 at 02:10:16AM +, Christos Zoulas wrote:
  Modified Files:
  src/bin/sh: histedit.c
  
  Log Message:
  Call el_source before initializing sh-specific editline properties (i.e.
  the editor type and the tab completion binding).
  
  This allows tab completion to work when a user has an ~/.editrc file.
  
  Err, this change is wrong. If you change now the editor to vi in your
  .editrc file, then it will be ignored. You also will not be able to
  bind ^I to what you want, because your change will be undone!  If
  you put bind -v in your .editrc you should know to bind tab-complete
  to ^I for vi too! What was there was on purpose. Revert and document
  the previous behavior in the man page if you want.

For the record, this is PR 44347, not 43404. 43404 was an unrelated
local problem of mine that jmmv had initially reopened instead.

-- 
David A. Holland
dholl...@netbsd.org


Re: CVS commit: src/etc/rc.d

2011-01-08 Thread Matthias Scheler

On 8 Jan 2011, at 23:21, David Holland wrote:
 This is no longer true, for lvm and other things, so let's take a deep
 breath and move chown.

Yes, but we should probably provide a symlink from /usr/sbin/chown to 
/sbin/chown for backwards compatibility reasons.

 I don't like the idea of having rc.d scripts depend on /rescue.

Me neither.

Kind regards

-- 
Matthias Scheler   http://zhadum.org.uk/





Re: CVS commit: src/tests/lib/libc

2011-01-08 Thread Julio Merino
On Sat, Jan 8, 2011 at 6:10 PM, Paul Goyette pgoye...@netbsd.org wrote:
 Module Name:    src
 Committed By:   pgoyette
 Date:           Sat Jan  8 18:10:32 UTC 2011

 Modified Files:
        src/tests/lib/libc: Makefile
 Added Files:
        src/tests/lib/libc/regex: README debug.c main.c split.c t_regex.awk
            t_regex.in test_regex.h
        src/tests/lib/libc/regex/data: anchor.in backref.in basic.in bracket.in
            c_comments.in complex.in error.in meta.in nospec.in nul.in paren.in
            regress.in repet_bounded.in repet_multi.in repet_ordinary.in
            startend.in subexp.in subtle.in word_bound.in

 Log Message:
 Atf-ify the regex test

I think there is a missing Makefile in this change in
src/tests/lib/libc/regex/.  I get complains in the checkflist stage
about missing files in destdir, but surprisingly not during the build.

-- 
Julio Merino


Re: CVS commit: src/etc/rc.d

2011-01-08 Thread David Holland
On Sat, Jan 08, 2011 at 11:49:54PM +, Matthias Scheler wrote:
   This is no longer true, for lvm and other things, so let's take a deep
   breath and move chown.
  
  Yes, but we should probably provide a symlink from
  /usr/sbin/chown to /sbin/chown for backwards compatibility
  reasons.

Maybe for a while, but I hope not permanently...

-- 
David A. Holland
dholl...@netbsd.org


Re: CVS commit: src/etc/rc.d

2011-01-08 Thread Hubert Feyrer

On Sat, 8 Jan 2011, David Holland wrote:

 XXX. Why is chown in /usr/sbin ? it should be moved to /sbin

Because historically nothing needed to be chowned during boot because
it was all root.

This is no longer true, for lvm and other things, so let's take a deep
breath and move chown. I don't like the idea of having rc.d scripts
depend on /rescue.


Seconded (on the don't depend on /rescue part).
FWIW:
fehu.org% cat /etc/debian_version
squeeze/sid
fehu.org% which chown
/bin/chown


 - Hubert