Re: CVS commit: src/sys/fs/puffs
On Tue Jan 11 2011 at 14:04:54 +, Mihai Chelaru wrote: Module Name: src Committed By: kefren Date: Tue Jan 11 14:04:54 UTC 2011 Modified Files: src/sys/fs/puffs: puffs_sys.h puffs_vnops.c Log Message: add advlock to puffs. ok pooka@ should fix kern/43321 Thanks! This is a big improvement and fixes the problem in most cases. However, e.g. for distributed file systems it would be good to have an additional mode where the server can decide the locking policy. I'll bump the PR state to analyzed to indicate progress. -- älä karot toivorikkauttas, kyl rätei ja lumpui piisaa
Re: CVS commit: src/tests/lib/libc
In article 2011063054.5531017...@cvs.netbsd.org, Paul Goyette source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: pgoyette Date: Tue Jan 11 16:30:54 UTC 2011 Modified Files: src/tests/lib/libc: Makefile Added Files: src/tests/lib/libc/getaddrinfo: Makefile README basics_v4.exp basics_v4v6.exp h_gai.c no_host_v4.exp no_host_v4v6.exp no_serv_v4.exp no_serv_v4v6.exp scoped.exp sock_raw_v4.exp sock_raw_v4v6.exp spec_fam_v4.exp spec_fam_v4v6.exp t_getaddrinfo.sh unsup_fam.exp Log Message: Atf-ify the getaddrinfo test, with updated golden output files. To generate a diff of this commit: cvs rdiff -u -r1.27 -r1.28 src/tests/lib/libc/Makefile cvs rdiff -u -r0 -r1.1 src/tests/lib/libc/getaddrinfo/Makefile \ src/tests/lib/libc/getaddrinfo/README \ src/tests/lib/libc/getaddrinfo/basics_v4.exp \ src/tests/lib/libc/getaddrinfo/basics_v4v6.exp \ src/tests/lib/libc/getaddrinfo/h_gai.c \ src/tests/lib/libc/getaddrinfo/no_host_v4.exp \ src/tests/lib/libc/getaddrinfo/no_host_v4v6.exp \ src/tests/lib/libc/getaddrinfo/no_serv_v4.exp \ src/tests/lib/libc/getaddrinfo/no_serv_v4v6.exp \ src/tests/lib/libc/getaddrinfo/scoped.exp \ src/tests/lib/libc/getaddrinfo/sock_raw_v4.exp \ src/tests/lib/libc/getaddrinfo/sock_raw_v4v6.exp \ src/tests/lib/libc/getaddrinfo/spec_fam_v4.exp \ src/tests/lib/libc/getaddrinfo/spec_fam_v4v6.exp \ src/tests/lib/libc/getaddrinfo/t_getaddrinfo.sh \ src/tests/lib/libc/getaddrinfo/unsup_fam.exp Can you please move all this to src/tests/lib/libc/net/getaddrinfo to reflect the structure in libc. I know others have been abusing it, but I meant to fix all of it and adding more does not help. Thanks, christos
Re: CVS commit: src/tests/lib/libc
Damn, I wish I had asked first. :( I could easily delete the files (move them to the attic) and then re-add them in the desired location. I am aware of other ways to accomplish this, but I do not know how to do a repository move. If there's some cook-book approach written down somewhere, I'm pretty good at following instructions. But otherwise it would take me some time to figure it out (and test my approach first on a dummy repository). On Tue, 11 Jan 2011, Christos Zoulas wrote: In article 2011063054.5531017...@cvs.netbsd.org, Paul Goyette source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name:src Committed By: pgoyette Date: Tue Jan 11 16:30:54 UTC 2011 Modified Files: src/tests/lib/libc: Makefile Added Files: src/tests/lib/libc/getaddrinfo: Makefile README basics_v4.exp basics_v4v6.exp h_gai.c no_host_v4.exp no_host_v4v6.exp no_serv_v4.exp no_serv_v4v6.exp scoped.exp sock_raw_v4.exp sock_raw_v4v6.exp spec_fam_v4.exp spec_fam_v4v6.exp t_getaddrinfo.sh unsup_fam.exp Log Message: Atf-ify the getaddrinfo test, with updated golden output files. To generate a diff of this commit: cvs rdiff -u -r1.27 -r1.28 src/tests/lib/libc/Makefile cvs rdiff -u -r0 -r1.1 src/tests/lib/libc/getaddrinfo/Makefile \ src/tests/lib/libc/getaddrinfo/README \ src/tests/lib/libc/getaddrinfo/basics_v4.exp \ src/tests/lib/libc/getaddrinfo/basics_v4v6.exp \ src/tests/lib/libc/getaddrinfo/h_gai.c \ src/tests/lib/libc/getaddrinfo/no_host_v4.exp \ src/tests/lib/libc/getaddrinfo/no_host_v4v6.exp \ src/tests/lib/libc/getaddrinfo/no_serv_v4.exp \ src/tests/lib/libc/getaddrinfo/no_serv_v4v6.exp \ src/tests/lib/libc/getaddrinfo/scoped.exp \ src/tests/lib/libc/getaddrinfo/sock_raw_v4.exp \ src/tests/lib/libc/getaddrinfo/sock_raw_v4v6.exp \ src/tests/lib/libc/getaddrinfo/spec_fam_v4.exp \ src/tests/lib/libc/getaddrinfo/spec_fam_v4v6.exp \ src/tests/lib/libc/getaddrinfo/t_getaddrinfo.sh \ src/tests/lib/libc/getaddrinfo/unsup_fam.exp Can you please move all this to src/tests/lib/libc/net/getaddrinfo to reflect the structure in libc. I know others have been abusing it, but I meant to fix all of it and adding more does not help. Thanks, christos !DSPAM:4d2ce6e62341669414842! - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/tests/lib/libc
On Jan 11, 3:36pm, p...@whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/tests/lib/libc | Damn, I wish I had asked first. :( Heh, no worries. | I could easily delete the files (move them to the attic) and then re-add | them in the desired location. You can, but read on. | | I am aware of other ways to accomplish this, but I do not know how to do | a repository move. If there's some cook-book approach written down | somewhere, I'm pretty good at following instructions. But otherwise it | would take me some time to figure it out (and test my approach first on | a dummy repository). Leave the directory, move the files to the new directory. Do you want me to do it for you? christos
Re: CVS commit: src/sys/arch/i386/i386
=?UTF-8?B?R3LDqWdvaXJlIFN1dHJl?= gsu...@netbsd.org writes: Assume for instance that the boot-loader left us with: +--+ ++ +--+ | string table | | kernel | | symbol table | +--+ ++ +--+ The new addresses computed by lines 338-359 (here, it's really lines 344-345) will move the tables so that they end up as: ++--+--+ | kernel | symbol table | string table | ++--+--+ If this ascii art is correct, memmove should be used instead of memcpy. Also, if initial order is kernel, string table, symbol table and a gap between kernel and string table is smaller than symbol table, copying it may overwrite the string table. Is there any guarantee that the gap is large enough? enami.
Re: CVS commit: src/tests/lib/libc
On Tue, Jan 11, 2011 at 11:25:01PM +, Christos Zoulas wrote: In article 2011063054.5531017...@cvs.netbsd.org, Paul Goyette source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By:pgoyette Date:Tue Jan 11 16:30:54 UTC 2011 Modified Files: src/tests/lib/libc: Makefile Added Files: src/tests/lib/libc/getaddrinfo: Makefile README basics_v4.exp basics_v4v6.exp h_gai.c no_host_v4.exp no_host_v4v6.exp no_serv_v4.exp no_serv_v4v6.exp scoped.exp sock_raw_v4.exp sock_raw_v4v6.exp spec_fam_v4.exp spec_fam_v4v6.exp t_getaddrinfo.sh unsup_fam.exp Log Message: Atf-ify the getaddrinfo test, with updated golden output files. To generate a diff of this commit: cvs rdiff -u -r1.27 -r1.28 src/tests/lib/libc/Makefile cvs rdiff -u -r0 -r1.1 src/tests/lib/libc/getaddrinfo/Makefile \ src/tests/lib/libc/getaddrinfo/README \ src/tests/lib/libc/getaddrinfo/basics_v4.exp \ src/tests/lib/libc/getaddrinfo/basics_v4v6.exp \ src/tests/lib/libc/getaddrinfo/h_gai.c \ src/tests/lib/libc/getaddrinfo/no_host_v4.exp \ src/tests/lib/libc/getaddrinfo/no_host_v4v6.exp \ src/tests/lib/libc/getaddrinfo/no_serv_v4.exp \ src/tests/lib/libc/getaddrinfo/no_serv_v4v6.exp \ src/tests/lib/libc/getaddrinfo/scoped.exp \ src/tests/lib/libc/getaddrinfo/sock_raw_v4.exp \ src/tests/lib/libc/getaddrinfo/sock_raw_v4v6.exp \ src/tests/lib/libc/getaddrinfo/spec_fam_v4.exp \ src/tests/lib/libc/getaddrinfo/spec_fam_v4v6.exp \ src/tests/lib/libc/getaddrinfo/t_getaddrinfo.sh \ src/tests/lib/libc/getaddrinfo/unsup_fam.exp Can you please move all this to src/tests/lib/libc/net/getaddrinfo to reflect the structure in libc. I know others have been abusing it, but I meant to fix all of it and adding more does not help. Why not put unit tests in the original directories? (Like src/lib/libc/net/getaddrinfo for this.)
Re: CVS commit: src/tests/lib/libc
On Wed, 12 Jan 2011, Masao Uebayashi wrote: On Tue, Jan 11, 2011 at 11:25:01PM +, Christos Zoulas wrote: Module Name:src Committed By: pgoyette Date: Tue Jan 11 16:30:54 UTC 2011 Modified Files: src/tests/lib/libc: Makefile Added Files: src/tests/lib/libc/getaddrinfo: Makefile README basics_v4.exp basics_v4v6.exp h_gai.c no_host_v4.exp no_host_v4v6.exp no_serv_v4.exp no_serv_v4v6.exp scoped.exp sock_raw_v4.exp sock_raw_v4v6.exp spec_fam_v4.exp spec_fam_v4v6.exp t_getaddrinfo.sh unsup_fam.exp Log Message: Atf-ify the getaddrinfo test, with updated golden output files. ... Can you please move all this to src/tests/lib/libc/net/getaddrinfo to reflect the structure in libc. I know others have been abusing it, but I meant to fix all of it and adding more does not help. Why not put unit tests in the original directories? (Like src/lib/libc/net/getaddrinfo for this.) The original test was already in the regress/... hierarchy where it wasn't getting any attention. It just seemed reasonable to me to move a regression test to our new location for regression tests. :) At Christos's suggestion, I've already moved the getaddrinfo test from: src/test/lib/libc/getaddrinfo/* to: src/test/lib/libc/net/getaddrinfo/* If there are no objections, I'll likely move the servent and protoent tests into the /net directory, too. But not tonight! :) - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
