Re: CVS commit: src/sys/arch/amd64/include
On Fri, Mar 04, 2011 at 04:33:17AM +, Christos Zoulas wrote: In article 20110304033425.0e01017...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By:joerg Date:Fri Mar 4 03:34:24 UTC 2011 Modified Files: src/sys/arch/amd64/include: vmparam.h Log Message: Reduce MAXSSIZ to 64MB, otherwise netbsd32 binaries crash in ld.elf_so, including the trivial main(){}. Add a warning to not modify this without testing compatibility mode. Please revert this. The 32 bit emulation is supposed to be using MAXSSIZ32. Feel free to revert the change after testing that it actually works. I've spend enough time looking for the regression. Joerg
Re: CVS commit: src/sys/arch/amd64/include
On Fri Mar 04 2011 at 11:42:10 +0100, Joerg Sonnenberger wrote: On Fri, Mar 04, 2011 at 04:33:17AM +, Christos Zoulas wrote: In article 20110304033425.0e01017...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: joerg Date: Fri Mar 4 03:34:24 UTC 2011 Modified Files: src/sys/arch/amd64/include: vmparam.h Log Message: Reduce MAXSSIZ to 64MB, otherwise netbsd32 binaries crash in ld.elf_so, including the trivial main(){}. Add a warning to not modify this without testing compatibility mode. Please revert this. The 32 bit emulation is supposed to be using MAXSSIZ32. Feel free to revert the change after testing that it actually works. I've spend enough time looking for the regression. If only we had some infrastructure for periodically testing that a program compiled with -m32 works on amd64! Good thing that it's not my time being wasted or I'd try to prevent it from happening in the future. -- älä karot toivorikkauttas, kyl rätei ja lumpui piisaa
Re: CVS commit: src/sys/arch/amd64/include
On Fri, Mar 04, 2011 at 01:24:19PM +0200, Antti Kantee wrote: On Fri Mar 04 2011 at 11:42:10 +0100, Joerg Sonnenberger wrote: On Fri, Mar 04, 2011 at 04:33:17AM +, Christos Zoulas wrote: In article 20110304033425.0e01017...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By:joerg Date:Fri Mar 4 03:34:24 UTC 2011 Modified Files: src/sys/arch/amd64/include: vmparam.h Log Message: Reduce MAXSSIZ to 64MB, otherwise netbsd32 binaries crash in ld.elf_so, including the trivial main(){}. Add a warning to not modify this without testing compatibility mode. Please revert this. The 32 bit emulation is supposed to be using MAXSSIZ32. Feel free to revert the change after testing that it actually works. I've spend enough time looking for the regression. If only we had some infrastructure for periodically testing that a program compiled with -m32 works on amd64! Good thing that it's not my time being wasted or I'd try to prevent it from happening in the future. You mean like build i386, copy tests.tgz, done? Joerg
Re: CVS commit: src/sys/arch/amd64/include
In article 20110304104210.ga22...@britannica.bec.de, Joerg Sonnenberger jo...@britannica.bec.de wrote: On Fri, Mar 04, 2011 at 04:33:17AM +, Christos Zoulas wrote: In article 20110304033425.0e01017...@cvs.netbsd.org, Joerg Sonnenberger source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name:src Committed By: joerg Date: Fri Mar 4 03:34:24 UTC 2011 Modified Files: src/sys/arch/amd64/include: vmparam.h Log Message: Reduce MAXSSIZ to 64MB, otherwise netbsd32 binaries crash in ld.elf_so, including the trivial main(){}. Add a warning to not modify this without testing compatibility mode. Please revert this. The 32 bit emulation is supposed to be using MAXSSIZ32. Feel free to revert the change after testing that it actually works. I've spend enough time looking for the regression. Your change has no effect anymore and I tested it. christos
Re: CVS commit: src/sys/arch/amd64/include
On Fri Mar 04 2011 at 13:59:34 +0100, Joerg Sonnenberger wrote: Log Message: Reduce MAXSSIZ to 64MB, otherwise netbsd32 binaries crash in ld.elf_so, including the trivial main(){}. Add a warning to not modify this without testing compatibility mode. Please revert this. The 32 bit emulation is supposed to be using MAXSSIZ32. Feel free to revert the change after testing that it actually works. I've spend enough time looking for the regression. If only we had some infrastructure for periodically testing that a program compiled with -m32 works on amd64! Good thing that it's not my time being wasted or I'd try to prevent it from happening in the future. You mean like build i386, copy tests.tgz, done? Being lazy, personally I'd start with the minimum effort which would have caught the regression: a test case which compiles hello.c with -m32 and runs it. (I'm not saying that it would not be worthwhile to run all tests with compat32, but I am saying that it's more important to have some test today than wait 10 years for the perfect set of tests... because then we'd need compat64 too ;) -- älä karot toivorikkauttas, kyl rätei ja lumpui piisaa