Re: CVS commit: src

2011-03-25 Thread Joerg Sonnenberger
Forgot to add:
This material is based upon work partially supported by
The NetBSD Foundation under a contract with Joerg Sonnenberger.

Sorry, about that.

On Fri, Mar 25, 2011 at 06:07:08PM +, Joerg Sonnenberger wrote:
> Module Name:  src
> Committed By: joerg
> Date: Fri Mar 25 18:07:07 UTC 2011
> 
> Modified Files:
>   src/libexec/ld.elf_so: rtld.c rtld.h tls.c
>   src/libexec/ld.elf_so/arch/alpha: alpha_reloc.c
>   src/libexec/ld.elf_so/arch/arm: mdreloc.c
>   src/libexec/ld.elf_so/arch/hppa: hppa_reloc.c
>   src/libexec/ld.elf_so/arch/i386: mdreloc.c
>   src/libexec/ld.elf_so/arch/m68k: mdreloc.c
>   src/libexec/ld.elf_so/arch/mips: mips_reloc.c
>   src/libexec/ld.elf_so/arch/powerpc: ppc_reloc.c
>   src/libexec/ld.elf_so/arch/sh3: mdreloc.c
>   src/libexec/ld.elf_so/arch/sparc: mdreloc.c
>   src/libexec/ld.elf_so/arch/sparc64: mdreloc.c
>   src/libexec/ld.elf_so/arch/vax: mdreloc.c
>   src/libexec/ld.elf_so/arch/x86_64: mdreloc.c
>   src/rescue: list.ldd
>   src/usr.bin/ldd: ldd.c
> 
> Log Message:
> Add basic locking to ld.elf_so.
> 
> 
> To generate a diff of this commit:
> cvs rdiff -u -r1.140 -r1.141 src/libexec/ld.elf_so/rtld.c
> cvs rdiff -u -r1.103 -r1.104 src/libexec/ld.elf_so/rtld.h
> cvs rdiff -u -r1.3 -r1.4 src/libexec/ld.elf_so/tls.c
> cvs rdiff -u -r1.38 -r1.39 src/libexec/ld.elf_so/arch/alpha/alpha_reloc.c
> cvs rdiff -u -r1.34 -r1.35 src/libexec/ld.elf_so/arch/arm/mdreloc.c
> cvs rdiff -u -r1.38 -r1.39 src/libexec/ld.elf_so/arch/hppa/hppa_reloc.c
> cvs rdiff -u -r1.33 -r1.34 src/libexec/ld.elf_so/arch/i386/mdreloc.c
> cvs rdiff -u -r1.27 -r1.28 src/libexec/ld.elf_so/arch/m68k/mdreloc.c
> cvs rdiff -u -r1.61 -r1.62 src/libexec/ld.elf_so/arch/mips/mips_reloc.c
> cvs rdiff -u -r1.48 -r1.49 src/libexec/ld.elf_so/arch/powerpc/ppc_reloc.c
> cvs rdiff -u -r1.29 -r1.30 src/libexec/ld.elf_so/arch/sh3/mdreloc.c
> cvs rdiff -u -r1.44 -r1.45 src/libexec/ld.elf_so/arch/sparc/mdreloc.c
> cvs rdiff -u -r1.50 -r1.51 src/libexec/ld.elf_so/arch/sparc64/mdreloc.c
> cvs rdiff -u -r1.27 -r1.28 src/libexec/ld.elf_so/arch/vax/mdreloc.c
> cvs rdiff -u -r1.39 -r1.40 src/libexec/ld.elf_so/arch/x86_64/mdreloc.c
> cvs rdiff -u -r1.5 -r1.6 src/rescue/list.ldd
> cvs rdiff -u -r1.16 -r1.17 src/usr.bin/ldd/ldd.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
> 


Re: CVS commit: src/tests

2011-03-25 Thread Nicolas Joly
On Fri, Mar 25, 2011 at 12:15:08PM +0200, Jukka Ruohonen wrote:
> On Fri, Mar 25, 2011 at 11:09:26AM +0100, Nicolas Joly wrote:
> > Skipping them is not the right solution IMO.
> 
> I have no strong opinion about this. But to me it seems that these
> bugs/tests are really testing an emulator instead of NetBSD itself.

We do exercise with tests the tuple of hardware (or emulator) and OS.
Tests should show existing problems on the tested infrastructure.

And it could be a good way to know if/when QEMU fixed the reported
problems, without following it too closely ...

-- 
Nicolas Joly

Projects and Developments in Bioinformatics
Institut Pasteur, Paris.


Re: CVS commit: src/tests

2011-03-25 Thread Jukka Ruohonen
On Fri, Mar 25, 2011 at 11:09:26AM +0100, Nicolas Joly wrote:
> Skipping them is not the right solution IMO.

I have no strong opinion about this. But to me it seems that these
bugs/tests are really testing an emulator instead of NetBSD itself.

- Jukka.


Re: CVS commit: src/tests

2011-03-25 Thread Nicolas Joly
On Fri, Mar 25, 2011 at 10:00:32AM +, Jukka Ruohonen wrote:
> Module Name:  src
> Committed By: jruoho
> Date: Fri Mar 25 10:00:32 UTC 2011
> 
> Modified Files:
>   src/tests/include/sys: t_bitops.c
>   src/tests/lib/libm: t_ceil.c t_floor.c
> 
> Log Message:
> Bluntly skip the tests that fail under QEMU. XXX: system(3) is used for this?

Skipping them is not the right solution IMO. I would expect them to
fail if run under QEMU:

if (system("cpuctl identify 0 | grep -q QEMU") == 0)
atf_tc_expect_fail("PR misc/44767: floating point support broken in 
QEMU");

> To generate a diff of this commit:
> cvs rdiff -u -r1.4 -r1.5 src/tests/include/sys/t_bitops.c
> cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libm/t_ceil.c
> cvs rdiff -u -r1.2 -r1.3 src/tests/lib/libm/t_floor.c
> 
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.

-- 
Nicolas Joly

Projects and Developments in Bioinformatics
Institut Pasteur, Paris.