Re: CVS commit: src
On Sat, Apr 09, 2011 at 05:45:25PM +, Paul Goyette wrote: Module Name: src Committed By: pgoyette Date: Sat Apr 9 17:45:25 UTC 2011 Modified Files: src/distrib/sets/lists/tests: mi src/etc/mtree: NetBSD.dist.tests src/tests/lib/libc: Makefile Added Files: src/tests/lib/libc/locale: Makefile t_ctype1.c t_ctype2.c t_mbtowc.c t_wcstod.c t_wctomb.c Log Message: atf-ify the various locale tests I suppose the empty src/regress -directories should be removed as well? - Jukka.
Re: CVS commit: src
They should be removed - if you use cvs update -Pd On Sun, 10 Apr 2011, Jukka Ruohonen wrote: On Sat, Apr 09, 2011 at 05:45:25PM +, Paul Goyette wrote: Module Name:src Committed By: pgoyette Date: Sat Apr 9 17:45:25 UTC 2011 Modified Files: src/distrib/sets/lists/tests: mi src/etc/mtree: NetBSD.dist.tests src/tests/lib/libc: Makefile Added Files: src/tests/lib/libc/locale: Makefile t_ctype1.c t_ctype2.c t_mbtowc.c t_wcstod.c t_wctomb.c Log Message: atf-ify the various locale tests I suppose the empty src/regress -directories should be removed as well? - Jukka. !DSPAM:4da14cf82445187468586! - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
Re: CVS commit: src/sys/dev/videomode
hi christos, On Sat, Apr 09, 2011 at 04:53:39PM -0400, Christos Zoulas wrote: - use struct copy instead of memcpy i haven't looked into this specific instance, but won't gcc (at least) produce the same code for memcpy as struct copy, and the memcpy call has the (admittedly arguable) distinction of being more readable. - snprintf(%s) - strlcpy i use snprintf(%s) since it's more portable, and avoids having to indirect through autoconf HAVE_STRLCPY goo just to invoke snprintf(%s) in a stub re-implementation of strlcpy(3). feel the glibc luurrve. regards, al
Re: CVS commit: src/sys/dev/videomode
In article 20110410161417.ge4...@nef.pbox.org, Alistair Crooks a...@pkgsrc.org wrote: hi christos, On Sat, Apr 09, 2011 at 04:53:39PM -0400, Christos Zoulas wrote: - use struct copy instead of memcpy i haven't looked into this specific instance, but won't gcc (at least) produce the same code for memcpy as struct copy, and the memcpy call has the (admittedly arguable) distinction of being more readable. It is more readable, exactly. - snprintf(%s) - strlcpy i use snprintf(%s) since it's more portable, and avoids having to indirect through autoconf HAVE_STRLCPY goo just to invoke snprintf(%s) in a stub re-implementation of strlcpy(3). feel the glibc luurrve. This is a kernel device driver, and the kernel has strlcpy(3) and does not use autoconf :-) christos
Re: CVS commit: src/share/mk
On 10.04.11 23:03, Joerg Sonnenberger wrote:
Module Name: src
Committed By: joerg
Date: Sun Apr 10 21:03:17 UTC 2011
Modified Files:
src/share/mk: bsd.own.mk
Log Message:
Use ?: operator to determine when to add --sysroot. Unbreaks clang
bootstrap.
[...]
-CPPFLAGS+= ${HOSTPROG:U${HOSTLIB:U${DESTDIR:D--sysroot=${DESTDIR
-LDFLAGS+=${HOSTPROG:U${HOSTLIB:U${DESTDIR:D--sysroot=${DESTDIR
+CPPFLAGS+= ${!defined(HOSTPROG) !defined(HOSTLIB) defined(DESTDIR)
:? --sysroot=${DESTDIR} :}
+LDFLAGS+=${!defined(HOSTPROG) !defined(HOSTLIB) defined(DESTDIR)
:? --sysroot=${DESTDIR} :}
.endif # EXTERNAL_TOOLCHAIN
# }
:? == ?: operator?
Christoph
Re: CVS commit: src/share/mk
On Sun, Apr 10, 2011 at 11:25:50PM +0200, Christoph Egger wrote:
[...] ${[...foo...] :? --sysroot=${DESTDIR} :}
^ ^
:? == ?: operator?
no, see above.
--
David A. Holland
dholl...@netbsd.org
Re: CVS commit: src/sys
On Mon, Apr 11, 2011 at 01:33:05AM +, David A. Holland wrote: Module Name: src Committed By:dholland Date:Mon Apr 11 01:33:05 UTC 2011 Modified Files: src/sys/kern: vfs_lookup.c src/sys/nfs: nfs_serv.c nfs_srvsubs.c Log Message: kern/ZZmsg Well crap. -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/sys
On Mon, Apr 11, 2011 at 01:33:05AM +, David A. Holland wrote: Modified Files: src/sys/kern: vfs_lookup.c src/sys/nfs: nfs_serv.c nfs_srvsubs.c Log Message: kern/ZZmsg This was supposed to be: Clean up. Move some more code across from nfsd's private entry points. and I've fixed the repo. I think for the rest I'm going to revert and then redo them. -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/sys
On Mon, Apr 11, 2011 at 01:53:32AM +, David Holland wrote: I think for the rest I'm going to revert and then redo them. Because that would get me into rcsid hell, I decided not. I've fixed the repo and will reply with the right message for the archive. Sigh. at least phone stopped me before I did all 41 patches. -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/sys/kern
On Mon, Apr 11, 2011 at 01:35:00AM +, David A. Holland wrote: Log Message: ZZmsg To generate a diff of this commit: cvs rdiff -u -r1.133 -r1.134 src/sys/kern/vfs_lookup.c More cleanup. -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/sys/kern
On Mon, Apr 11, 2011 at 02:21:17AM +, David A. Holland wrote: Module Name: src Committed By:dholland Date:Mon Apr 11 02:21:17 UTC 2011 Modified Files: src/sys/kern: vfs_lookup.c Log Message: description: Update comments. ...aaand that's the last one for now. that was originally only nine patches, but the 8th had way too much crap in it (and a bug I couldn't find) so I split it up and ended up at the other extreme. -- David A. Holland dholl...@netbsd.org
