Re: CVS commit: src

2011-05-29 Thread Matthias Scheler
On Sat, May 28, 2011 at 11:42:37PM +0100, Julio M. Merino Vidal wrote: On 5/28/11 10:46 PM, Christos Zoulas wrote: In article20110528161256.ab89817...@cvs.netbsd.org, Matthias Schelersource-changes-d@NetBSD.org wrote: + assert(pipe(fds) == 0); [...] + assert(write(fds[1], , 1) == 1);

Re: CVS commit: src

2011-05-29 Thread Christos Zoulas
In article 20110529125822.ga17...@colwyn.zhadum.org.uk, Matthias Scheler t...@netbsd.org wrote: I've fixed it as suggested by you. Thank you! Now if I could only figure out why the pselect tests work on virtual pc and not a real machine. christos

Re: CVS commit: src

2011-05-29 Thread Paul Goyette
chris...@astron.com wrote: Thank you! Now if I could only figure out why the pselect tests work on virtual pc and not a real machine. Perhaps it is because the real machine is SMP/multi-core? By default, qemu virtual machines are single-core.

Re: CVS commit: src

2011-05-29 Thread Christos Zoulas
In article pine.neb.4.64.1105290616001.9...@quicky.whooppee.com, Paul Goyette p...@whooppee.com wrote: chris...@astron.com wrote: Thank you! Now if I could only figure out why the pselect tests work on virtual pc and not a real machine. Perhaps it is because the real machine is

Re: CVS commit: src/tests/syscall

2011-05-29 Thread Julio Merino
On 5/29/11 1:57 PM, Matthias Scheler wrote: Modified Files: src/tests/syscall: t_pollts.c Log Message: [...] Also use ATF_REQUIRE_EQ_MSG() instead of ATF_REQUIRE_MSG() to avoid crashes if one of the required conditions isn't met. It could be a bug in the macro. I tried changing the

Re: CVS commit: src

2011-05-29 Thread David Laight
On Sat, May 28, 2011 at 11:42:37PM +0100, Julio Merino wrote: On 5/28/11 10:46 PM, Christos Zoulas wrote: In article20110528161256.ab89817...@cvs.netbsd.org, Matthias Schelersource-changes-d@NetBSD.org wrote: [...] + assert(close(fd) == 0); Please don't create assertions that contain

Re: CVS commit: src/usr.sbin/makefs

2011-05-29 Thread Izumi Tsutsui
I think the problem is that the final ISO9660 output including embeded MD boot fs and partition maps still has to be iso9660 compliant. There is no public space to store MD parameters for postprocessing in output image, ... Could the extra parameters be put into a file within the image?

Re: CVS commit: src/tests/syscall

2011-05-29 Thread Matthias Scheler
On Sun, May 29, 2011 at 02:57:14PM +0100, Julio M. Merino Vidal wrote: On 5/29/11 1:57 PM, Matthias Scheler wrote: Modified Files: src/tests/syscall: t_pollts.c Log Message: [...] Also use ATF_REQUIRE_EQ_MSG() instead of ATF_REQUIRE_MSG() to avoid crashes if one of the required

Re: CVS commit: src

2011-05-29 Thread Matthias Scheler
On Sun, May 29, 2011 at 01:07:34PM +, Christos Zoulas wrote: I've fixed it as suggested by you. Thank you! Now if I could only figure out why the pselect tests work on virtual pc and not a real machine. They also fail on virtual machines:

Re: CVS commit: src

2011-05-29 Thread Matthias Scheler
On Sun, May 29, 2011 at 06:18:11AM -0700, Paul Goyette wrote: Thank you! Now if I could only figure out why the pselect tests work on virtual pc and not a real machine. Perhaps it is because the real machine is SMP/multi-core? By default, qemu virtual machines are single-core. It fails for

Re: CVS commit: src

2011-05-29 Thread Paul Goyette
Yup, I just checked on my amd64 test-bed, and the tests fail there, too! http://www.whooppee.com/amd64-results/1842_atf.html#failed-tcs-summary On Sun, 29 May 2011, Matthias Scheler wrote: On Sun, May 29, 2011 at 01:07:34PM +, Christos Zoulas wrote: I've fixed it as suggested by you.

Re: CVS commit: src

2011-05-29 Thread Christos Zoulas
In article 20110529165252.ga17...@colwyn.zhadum.org.uk, Matthias Scheler t...@netbsd.org wrote: On Sun, May 29, 2011 at 01:07:34PM +, Christos Zoulas wrote: I've fixed it as suggested by you. Thank you! Now if I could only figure out why the pselect tests work on virtual pc and not a

Re: CVS commit: src/lib/libdm

2011-05-29 Thread Adam Hamsik
I forgot to say that this commit fixes PR 44947. On May,Monday 30 2011, at 3:10 AM, Adam Hamsik wrote: Module Name: src Committed By: haad Date: Mon May 30 01:10:58 UTC 2011 Modified Files: src/lib/libdm: libdm_ioctl.c Log Message: Fix problem where DM_IOCTL_NAME was