Re: CVS commit: src/sys/arch

2011-07-18 Thread David Laight
On Mon, Jul 18, 2011 at 02:18:54AM +0200, Jean-Yves Migeon wrote:
 On 18.07.2011 02:00, David Young wrote:
  Can we please use ansi function definitions in newly committed code?
  
  This was tedious enough without converting to ANSI function definitions.
  A good job for Coccinelle (spatch)?
 
 Sadly, no: last time I tried (when moving kvm(3) code to ANSI style), I
 had to do it manually. It's even the opposite, spatch has issues when
 parsing non-ANSI declarations, so you have to do the conversion all by
 yourself first...

I've a sed script that will change most of them
see ftp.netbsd.org:~dsl/protoz

David

-- 
David Laight: da...@l8s.co.uk


re: CVS commit: src/sys/arch/alpha/include

2011-07-18 Thread matthew green

 On Mon, Jul 18, 2011 at 11:26:59AM +1000, matthew green wrote:
  making port-alpha build by simply removing what isn't building is the
  wrong answer, unless you're positive that is the right thing to do.
 
 This was rather poor phrasing, wasn't it?

hope you understand this then:  please revert your changes.


.mrg.


Re: CVS commit: src/sys/arch

2011-07-18 Thread Jean-Yves Migeon

On Mon, 18 Jul 2011 07:41:30 +0100, David Laight wrote:

On Mon, Jul 18, 2011 at 02:18:54AM +0200, Jean-Yves Migeon wrote:

On 18.07.2011 02:00, David Young wrote:
 Can we please use ansi function definitions in newly committed 
code?


 This was tedious enough without converting to ANSI function 
definitions.

 A good job for Coccinelle (spatch)?

Sadly, no: last time I tried (when moving kvm(3) code to ANSI 
style), I
had to do it manually. It's even the opposite, spatch has issues 
when
parsing non-ANSI declarations, so you have to do the conversion all 
by

yourself first...


I've a sed script that will change most of them
see ftp.netbsd.org:~dsl/protoz


Ah yes, forgot about it. Works pretty well, thanks for pointing it out.

--
Jean-Yves Migeon
jeanyves.mig...@free.fr


Re: CVS commit: src/sbin/newfs_v7fs

2011-07-18 Thread tsugutomo . enami
Matthias Scheler t...@netbsd.org writes:

 Log Message:
 Don't use roundup2(9) (which should have been howmany(9) anyway) to
 fix builds on platforms other than NetBSD.

Since usr.sbin/makefs/cd9660.[ch] already uses howmany(), we can use it
here too, can't we?

enami.


Re: CVS commit: src/usr.sbin/makefs

2011-07-18 Thread UCHIYAMA Yasushi
From: Matthias Scheler t...@netbsd.org
Subject: CVS commit: src/usr.sbin/makefs
Date: Mon, 18 Jul 2011 22:52:37 +

 Module Name:  src
 Committed By: tron
 Date: Mon Jul 18 22:52:37 UTC 2011
 
 Modified Files:
   src/usr.sbin/makefs: Makefile makefs.c makefs.h
 
 Log Message:
 Re-enable v7fs support in the tools version of makefs after the
 issues have been fixed by Alan Barrett. Tested under Mac OS X.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.28 -r1.29 src/usr.sbin/makefs/Makefile \
 src/usr.sbin/makefs/makefs.c
 cvs rdiff -u -r1.22 -r1.23 src/usr.sbin/makefs/makefs.h
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 

Thank you!