Re: CVS commit: src/sys/kern
On Aug 29, 2011, at 2:39 AM, Mindaugas Rasiukevicius wrote: > Module Name: src > Committed By: rmind > Date: Mon Aug 29 00:39:16 UTC 2011 > > Modified Files: > src/sys/kern: sys_select.c > > Log Message: > Add kern.direct_select sysctl. Default to 0 for now. Why is it disabled by default? -- Juergen Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)
Re: CVS commit: src/share/man/man4
On 29.08.11 06:26, Christoph Egger wrote: > On 29.08.11 00:09, Jean-Yves Migeon wrote: >> Module Name: src >> Committed By:jym >> Date:Sun Aug 28 22:09:37 UTC 2011 >> >> Modified Files: >> src/share/man/man4: ddb.4 >> >> Log Message: >> Be more precise for Xen: + is only valid for Xen domUs. dom0 uses >> the same key sequences as i386/amd64. > > + also works for me in a dom0. I think I have to mention I am using serial console regularly. Christoph
Re: CVS commit: src/share/man/man4
On 29.08.11 00:09, Jean-Yves Migeon wrote: > Module Name: src > Committed By: jym > Date: Sun Aug 28 22:09:37 UTC 2011 > > Modified Files: > src/share/man/man4: ddb.4 > > Log Message: > Be more precise for Xen: + is only valid for Xen domUs. dom0 uses > the same key sequences as i386/amd64. + also works for me in a dom0. Christoph
re: CVS commit: src/sys/arch/sparc/include
> Module Name: src > Committed By: mrg > Date: Sun Aug 28 22:30:09 UTC 2011 > > Modified Files: > src/sys/arch/sparc/include: psl.h > > Log Message: > apply some always_inline attribute to setpsr and spl*. while i am > not yet sure exactly why this is necessary, but does avoid crashes > seen on sparc INSTALL with gcc 4.5. uwe@ helped me understand why this fixes the problem. thanks! it goes like this: - srmmu_vcache_flush_context() turns off traps to do its work. - at the end, when it is trying to turn on traps again which happens via the now no longer inlined setpsr() call, the caller has a tail-call optimisation on the call to setpsr() and the asm looks like: 0xf0012f08 :b 0xf0012618 0xf0012f0c :restore - but wait, we have traps turned off and we're going to execute the restore, so any time we need to clean a register window upon restore we go boom here. the inlined version calls restore after setting %psr, and the trap can be handled normally. .mrg.
Re: CVS commit: src/sbin/resize_ffs
On Aug 28, 7:14pm, w...@netbsd.org (Thomas Klausner) wrote: -- Subject: Re: CVS commit: src/sbin/resize_ffs | On Sat, Aug 27, 2011 at 12:34:57PM -0400, Christos Zoulas wrote: | > Module Name:src | > Committed By: christos | > Date: Sat Aug 27 16:34:57 UTC 2011 | > | > Modified Files: | > src/sbin/resize_ffs: resize_ffs.8 resize_ffs.c | > | > Log Message: | > PR/45301: Julian Fagir: make clear that the unit is sectors and fix a typo. | > While there, use errx, and sizeof(*var) instead of sizeof(type) | | This leaves a sentence in the upper paragraph that doesn't make sense | in the place, and also makes me curious if blocksizes != 512 are | supported: Where, the '.Nm\ncan both grow and shrink filesystems.'? | It will not work correctly for file systems with other sector sizes.) | | Is it correct? I think so. The uses of DEV_BSIZE seem suspicious to me. Better safe than sorry. christos
Re: CVS commit: src/sys
> Log Message: > set default WARNS for modules to 3 -- the only one that needs < 3 now is pf Nice, thanks! -- NetBSD - Simplicity is prerequisite for reliability Software Engineering Department, University of Szeged
Re: CVS commit: src/sbin/resize_ffs
On Sat, Aug 27, 2011 at 12:34:57PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sat Aug 27 16:34:57 UTC 2011 > > Modified Files: > src/sbin/resize_ffs: resize_ffs.8 resize_ffs.c > > Log Message: > PR/45301: Julian Fagir: make clear that the unit is sectors and fix a typo. > While there, use errx, and sizeof(*var) instead of sizeof(type) This leaves a sentence in the upper paragraph that doesn't make sense in the place, and also makes me curious if blocksizes != 512 are supported: It will not work correctly for file systems with other sector sizes.) Is it correct? Thomas
Re: CVS commit: src/sys/dev/ic
On Sun, Aug 28, 2011 at 05:32:21AM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Sun Aug 28 09:32:21 UTC 2011 > > Modified Files: > src/sys/dev/ic: wdc.c > > Log Message: > Make this compile again without WDC_NO_IDS. Ops, sorry. Looks like I commited the wrong version of the patch, before cleanups. The only cleanup needed so far was to remove the #error and a KASSERT() that I added while testing on the fuloong. I just commited the right version of this code. Sorry for this mess ... -- Manuel Bouyer NetBSD: 26 ans d'experience feront toujours la difference --
Re: CVS commit: src/usr.sbin/chroot
Am 28.08.11 00:32, schrieb Joerg Sonnenberger:
> Module Name: src
> Committed By: joerg
> Date: Sat Aug 27 22:32:44 UTC 2011
>
> Modified Files:
> src/usr.sbin/chroot: chroot.c
>
> Log Message:
> Use __dead. Move global variables into function scope.
>
>
> To generate a diff of this commit:
> cvs rdiff -u -r1.16 -r1.17 src/usr.sbin/chroot/chroot.c
>
> Please note that diffs are not public domain; they are subject to the
> copyright notices on the relevant files.
>
>
>
>
> Modified files:
>
> Index: src/usr.sbin/chroot/chroot.c
> diff -u src/usr.sbin/chroot/chroot.c:1.16 src/usr.sbin/chroot/chroot.c:1.17
> --- src/usr.sbin/chroot/chroot.c:1.16 Mon Aug 15 14:43:17 2011
> +++ src/usr.sbin/chroot/chroot.c Sat Aug 27 22:32:44 2011
> @@ -1,4 +1,4 @@
> -/* $NetBSD: chroot.c,v 1.16 2011/08/15 14:43:17 wiz Exp $ */
> +/* $NetBSD: chroot.c,v 1.17 2011/08/27 22:32:44 joerg Exp $*/
>
> /*
> * Copyright (c) 1988, 1993
> @@ -39,7 +39,7 @@
> #if 0
> static char sccsid[] = "@(#)chroot.c 8.1 (Berkeley) 6/9/93";
> #else
> -__RCSID("$NetBSD: chroot.c,v 1.16 2011/08/15 14:43:17 wiz Exp $");
> +__RCSID("$NetBSD: chroot.c,v 1.17 2011/08/27 22:32:44 joerg Exp $");
> #endif
> #endif /* not lint */
>
> @@ -56,16 +56,14 @@
> #include
> #include
>
> -int main(int, char **);
> -void usage(void) __dead;
> -
> -char *user; /* user to switch to before running program */
> -char *group; /* group to switch to ... */
> -char *grouplist; /* group list to switch to ... */
> +static void usage(void) __dead;
>
> int
> main(int argc, char *argv[])
> {
> + char*user; /* user to switch to before running program */
> + char*group; /* group to switch to ... */
> + char*grouplist; /* group list to switch to ... */
> struct group*gp;
> struct passwd *pw;
> char*endp, *p;
> @@ -175,7 +173,7 @@
> /* NOTREACHED */
> }
>
> -void
> +static void
> usage(void)
> {
>
>
--
\~.The NetBSD Foundation
\~' Marc Balmer, Developer / Marketing
NetBSD
\ mbal...@netbsd.org http://www.NetBSD.org/
