Re: CVS commit: src/lib/libutil

2011-11-17 Thread Christos Zoulas 
In article <4ec5a97e.2070...@free.fr>,
Jean-Yves Migeon   wrote:
>On 13.11.2011 23:03, Christos Zoulas wrote:
>> Module Name: src
>> Committed By:christos
>> Date:Sun Nov 13 22:03:34 UTC 2011
>>
>> Modified Files:
>>  src/lib/libutil: Makefile
>> Added Files:
>>  src/lib/libutil: getfstypename.3
>>
>> Log Message:
>> add manual page
>
>Just wondering: is there a different rule applicable to man pages for 
>4-clause vs 2-clause BSD? I occasionally see new man pages written with 
>a 4-clause BSD, however, most newly written code is 2-clause.

fixed.

christos

Re: CVS commit: src/lib/libc/gdtoa

2011-11-17 Thread tsugutomo . enami 
Christos Zoulas  writes:

> Modified Files:
>   src/lib/libc/gdtoa: misc.c

I've noticed that this code casually enclosing piece of code including
return statement with ACQUIRE_LOCK/FREE_LOCK.  I guess the lock need to
be freed (i.e., unlocked) before return.

enami.

Re: CVS commit: src/lib/libutil

2011-11-17 Thread Jean-Yves Migeon 

On 13.11.2011 23:03, Christos Zoulas wrote:

Module Name:src
Committed By:   christos
Date:   Sun Nov 13 22:03:34 UTC 2011

Modified Files:
src/lib/libutil: Makefile
Added Files:
src/lib/libutil: getfstypename.3

Log Message:
add manual page


Just wondering: is there a different rule applicable to man pages for 
4-clause vs 2-clause BSD? I occasionally see new man pages written with 
a 4-clause BSD, however, most newly written code is 2-clause.


--
Jean-Yves Migeon
jeanyves.mig...@free.fr

Re: CVS commit: src/crypto/dist/ipsec-tools/src/racoon

2011-11-17 Thread Paul Goyette 

On Thu, 17 Nov 2011, VANHULLEBUS Yvan wrote:


Module Name:src
Committed By:   vanhu
Date:   Thu Nov 17 14:41:55 UTC 2011

Modified Files:
src/crypto/dist/ipsec-tools/src/racoon: handler.c

Log Message:
fixed some crashes in LIST_FOREACH where current element could be removed 
during the loop


Should we have a LIST_FOREACH_SAFE similar to 
{SLIST,STAILQ,SIMPLEQ,TAILQ}_FOREACH_SAFE ?


:)


-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |  | pgoyette at netbsd.org  |
-

Re: CVS commit: src/sys/arch/amiga/amiga

2011-11-17 Thread Izumi Tsutsui 
> Module Name:  src
> Committed By: mlelstv
> Date: Thu Nov 17 07:45:54 UTC 2011
> 
> Modified Files:
>   src/sys/arch/amiga/amiga: machdep.c
> 
> Log Message:
> identifycpu() is not just cosmetic for the banner but initializes how FPU
> contexts are saved.
> Also drop code that checks for fputype before it is determined.

Is it really ok to remove m68k_make_fpu_idle_frame()?
Shouldn't it be moved after identifycpu()?

I wonder if it would affect recent awk problem on port-amiga.

---
Izumi Tsutsui