Christos Zoulas chris...@netbsd.org writes: To generate a diff of this commit: cvs rdiff -u -r1.341 -r1.342 src/sys/kern/kern_exec.c + kmem_free(fa-fae, sizeof(*fa-fae)); Two bugs here. fa-fae isn't allocated if (original) fa-len is zero. And the size of allocation is `sizeof(*fa-fae) * fa-len' (again, original fa-len). enami.
On Tue, Feb 21, 2012 at 02:19:01AM +, Matt Thomas wrote: Module Name: src Committed By: matt Date: Tue Feb 21 02:19:01 UTC 2012 Modified Files: src/sys/arch/powerpc/include: cdefs.h Log Message: Restore back to double alignment. For reference: __ALIGNBYTES is used for two purposes. The first purpose is stack alignment, which is what was intended here. The second purpose is the alignment for CMSG_SPACE and friends, which was not intended. The latter is part of the system ABI. Joerg
Christos Zoulas chris...@netbsd.org writes: Modified Files: src/sys/kern: kern_exec.c Log Message: fix fae free'ing, from enami. The fa-len in the posix_spawn_fa_free() might no longer be equal to the value used when fa-fae is allocated. So you can't use it as is. That's why I said 'original fa-len' in the last mail. enami.