Re: CVS commit: src/lib/libc/arch

2012-02-27 Thread Matt Thomas 

On Feb 27, 2012, at 12:35 PM, Joerg Sonnenberger wrote:

> On Mon, Feb 27, 2012 at 03:47:11PM +, Matt Thomas wrote:
>> Module Name: src
>> Committed By:matt
>> Date:Mon Feb 27 15:47:11 UTC 2012
>> 
>> Modified Files:
>>  src/lib/libc/arch/powerpc/sys: cerror.S
>>  src/lib/libc/arch/powerpc64/sys: cerror.S
>> 
>> Log Message:
>> PowerPC doesn't have CERROR since it never had a.out.
>> Use _C_LABEL(__cerror) instead.
> 
> Can we please be consistent on all platforms in this case?

No.  It is consistent.  platforms that formerly used a.out use CERROR.
platforms that didn't don't.

Re: CVS commit: src/lib/libc/arch

2012-02-27 Thread Joerg Sonnenberger 
On Mon, Feb 27, 2012 at 03:47:11PM +, Matt Thomas wrote:
> Module Name:  src
> Committed By: matt
> Date: Mon Feb 27 15:47:11 UTC 2012
> 
> Modified Files:
>   src/lib/libc/arch/powerpc/sys: cerror.S
>   src/lib/libc/arch/powerpc64/sys: cerror.S
> 
> Log Message:
> PowerPC doesn't have CERROR since it never had a.out.
> Use _C_LABEL(__cerror) instead.

Can we please be consistent on all platforms in this case?

Joerg

Re: CVS commit: src/lib/libc

2012-02-27 Thread Izumi Tsutsui 
> Module Name:  src
> Committed By: joerg
> Date: Mon Feb 27 12:26:22 UTC 2012
> 
> Modified Files:
 :
>   src/lib/libc/arch/powerpc/sys: cerror.S
>   src/lib/libc/arch/powerpc64/sys: cerror.S

--- src/lib/libc/arch/powerpc/sys/cerror.S  2011/01/16 02:43:10 1.8
+++ src/lib/libc/arch/powerpc/sys/cerror.S  2012/02/27 12:26:21 1.9
 :
-   .hidden _C_LABEL(__cerror)
+   .protected  CERROR

It looks there is no CERROR macro on powerpc.  Is this change OK?

---
Izumi Tsutsui