Re: CVS commit: [netbsd-6] src/etc/root
Hi Havard,
see the issue at the end.
On Sun, Mar 18, 2012 at 01:20:02AM +0400, Aleksej Saushev wrote:
Manuel Bouyer bou...@netbsd.org writes:
Module Name:src
Committed By: bouyer
Date: Sat Mar 17 17:22:54 UTC 2012
Modified Files:
src/etc/root [netbsd-6]: dot.cshrc dot.profile
Log Message:
Pull up following revision(s) (requested by he in ticket #109):
etc/root/dot.cshrc: revision 1.23
etc/root/dot.cshrc: revision 1.24
etc/root/dot.profile: revision 1.26
Can't use Bourne shell syntax here... (Even in comments, for PKG_PATH.)
Point first to 6.0 packages, then to packages for 5.1 or 5.0.
The latter have reduced usefullness in -current or netbsd-6 until
we have a compat50 package.
To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.22.4.1 src/etc/root/dot.cshrc
cvs rdiff -u -r1.25 -r1.25.4.1 src/etc/root/dot.profile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
...
Index: src/etc/root/dot.profile
diff -u src/etc/root/dot.profile:1.25 src/etc/root/dot.profile:1.25.4.1
--- src/etc/root/dot.profile:1.25 Tue Jun 21 05:31:29 2011
+++ src/etc/root/dot.profileSat Mar 17 17:22:54 2012
@@ -1,11 +1,12 @@
-# $NetBSD: dot.profile,v 1.25 2011/06/21 05:31:29 erh Exp $
+# $NetBSD: dot.profile,v 1.25.4.1 2012/03/17 17:22:54 bouyer Exp $
export PATH=/sbin:/usr/sbin:/bin:/usr/bin:/usr/pkg/sbin:/usr/pkg/bin
export
PATH=${PATH}:/usr/X11R7/bin:/usr/X11R6/bin:/usr/local/sbin:/usr/local/bin
# Uncomment the following line(s) to install binary packages
# from ftp.NetBSD.org via pkg_add. (See also pkg_install.conf)
-#export PKG_PATH=ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
-m)/5.1/All
+#export PKG_PATH=ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
-m)/6.0/All
+#export
PKG_PATH=${PKG_PATH};ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
-m)/5.1/All
#export
PKG_PATH=${PKG_PATH};ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
-m)/5.0/All
export BLOCKSIZE=1k
Why were quotes dropped?
You are asking the wrong person. That change come from the HEAD commit
by Havard, this is just the pullup.
Bernd
Re: CVS commit: src/tests/lib/librt
On Sat, Mar 17, 2012 at 10:14:16PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Sun Mar 18 02:14:16 UTC 2012 Modified Files: src/tests/lib/librt: t_sched.c Log Message: this should be fixed. Hmm. But now it fails with the third check: pid_t p = getpid(); /* * IEEE Std 1003.1-2008: if the supplied pid is zero, * the parameters for the calling process are returned. */ ATF_REQUIRE(sched_getparam(0, s1) == 0); ATF_REQUIRE(sched_getparam(p, s2) == 0); [HERE] ATF_REQUIRE(s1.sched_priority == s2.sched_priority); - Jukka.
Re: CVS commit: [netbsd-6] src/etc/root
Hello,
Bernd Ernesti net...@lists.veego.de writes:
Hi Havard,
see the issue at the end.
On Sun, Mar 18, 2012 at 01:20:02AM +0400, Aleksej Saushev wrote:
Manuel Bouyer bou...@netbsd.org writes:
Module Name: src
Committed By: bouyer
Date: Sat Mar 17 17:22:54 UTC 2012
Modified Files:
src/etc/root [netbsd-6]: dot.cshrc dot.profile
Log Message:
Pull up following revision(s) (requested by he in ticket #109):
etc/root/dot.cshrc: revision 1.23
etc/root/dot.cshrc: revision 1.24
etc/root/dot.profile: revision 1.26
Can't use Bourne shell syntax here... (Even in comments, for PKG_PATH.)
Point first to 6.0 packages, then to packages for 5.1 or 5.0.
The latter have reduced usefullness in -current or netbsd-6 until
we have a compat50 package.
To generate a diff of this commit:
cvs rdiff -u -r1.22 -r1.22.4.1 src/etc/root/dot.cshrc
cvs rdiff -u -r1.25 -r1.25.4.1 src/etc/root/dot.profile
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Modified files:
...
Index: src/etc/root/dot.profile
diff -u src/etc/root/dot.profile:1.25 src/etc/root/dot.profile:1.25.4.1
--- src/etc/root/dot.profile:1.25 Tue Jun 21 05:31:29 2011
+++ src/etc/root/dot.profile Sat Mar 17 17:22:54 2012
@@ -1,11 +1,12 @@
-# $NetBSD: dot.profile,v 1.25 2011/06/21 05:31:29 erh Exp $
+# $NetBSD: dot.profile,v 1.25.4.1 2012/03/17 17:22:54 bouyer Exp $
export PATH=/sbin:/usr/sbin:/bin:/usr/bin:/usr/pkg/sbin:/usr/pkg/bin
export
PATH=${PATH}:/usr/X11R7/bin:/usr/X11R6/bin:/usr/local/sbin:/usr/local/bin
# Uncomment the following line(s) to install binary packages
# from ftp.NetBSD.org via pkg_add. (See also pkg_install.conf)
-#export PKG_PATH=ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
-m)/5.1/All
+#export PKG_PATH=ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
-m)/6.0/All
+#export
PKG_PATH=${PKG_PATH};ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
-m)/5.1/All
#export
PKG_PATH=${PKG_PATH};ftp://ftp.NetBSD.org/pub/pkgsrc/packages/NetBSD/$(uname
-m)/5.0/All
export BLOCKSIZE=1k
Why were quotes dropped?
You are asking the wrong person. That change come from the HEAD commit
by Havard, this is just the pullup.
I understand it. I must have missed the original commit mail.
I'm just a bit puzzled why it was changed to a different style.
--
HE CE3OH...
Re: CVS commit: src/sbin/ifconfig
On 3/18/12 1:53 AM, Jukka Ruohonen wrote: On Fri, Mar 16, 2012 at 10:25:08PM -0400, Christos Zoulas wrote: Module Name:src Committed By: christos Date: Sat Mar 17 02:25:08 UTC 2012 Modified Files: src/sbin/ifconfig: af_inetany.c Log Message: PR/43141: Tobias Nygren: Print an error on unknown interfaces. Now this is trival and it is fixed. But I guess there is a bug here in ATF. The test only checks that the exit code is not zero: atf_check -s not-exit:0 ifconfig nonexistent0 1.2.3.4/24 But why is stderr being involved? If you really want to ignore stderr in the test, pass -e ignore to atf_check. The default is -o empty -e empty. Now, the question is: do you really want to ignore the message, or do you want to validate that the appropriate error message is printed? If the later (which should be the preferred way), -e inline:'foo bar\n' or -e match:'foo bar' or -e file:experr (with experr being pre-populated with the expected message) will do the job.
Re: CVS commit: src/sbin/ifconfig
On Sun, Mar 18, 2012 at 11:57:08PM +0900, Julio Merino wrote: But why is stderr being involved? If you really want to ignore stderr in the test, pass -e ignore to atf_check. The default is -o empty -e empty. Now, the question is: do you really want to ignore the message, or do you want to validate that the appropriate error message is printed? If the later (which should be the preferred way), -e inline:'foo bar\n' or -e match:'foo bar' or -e file:experr (with experr being pre-populated with the expected message) will do the job. Thanks; this was pointed out already. But I have a related question. Supposedly ATF uses something like freopen(3) to capture the output in the standard streams. Now consider this from one test I just added: $ find /etc -type f -exit $ echo $? 0 All good; exited without nothing printed to stderr and the status is zero. But this: atf_check -o ignore \ -s exit:0 -x find /etc -type f -exit yields tc-so:Executing command [ /bin/sh -c find /etc -type f -exit ] tc-se:Fail: incorrect exit status: 1, expected: 0 tc-se:stdout: tc-se: tc-se:stderr: tc-se:find: fts_read: Inappropriate ioctl for device tc-se: tc-end: 1332083101.965143, exit, failed, atf-check failed; see the output of the test for details So what is going on here? Likewise $ find / -exit 99 $ echo $? 99 contra atf_check -o ignore -e ignore -s exit:99 -x find / -exit 99 and tc-so:Executing command [ /bin/sh -c find / -exit 99 ] tc-se:Fail: incorrect exit status: 1, expected: 99 tc-se:stdout: tc-se: tc-se:stderr: tc-se:find: fts_read: Inappropriate ioctl for device tc-se: tc-end: 1332083172.374247, exit_status, failed, atf-check failed; see the output of the test for details - Jukka.
Re: CVS commit: src/lib/libc/sys
On Sat, Mar 17, 2012 at 10:04:40PM -0400, Christos Zoulas wrote:
Module Name: src
Committed By: christos
Date: Sun Mar 18 02:04:40 UTC 2012
Modified Files:
src/lib/libc/sys: sched.c
Log Message:
fail as the man page says sched_rr_get_interval should.
#include string.h
#include unistd.h
#include errno.h
#include sched.h
+#include signal.h
#include sys/param.h
#include sys/types.h
@@ -123,6 +124,8 @@ int
sched_rr_get_interval(pid_t pid, struct timespec *interval)
{
+ if (pid kill(pid, 0) == -1)
+ return -1;
interval-tv_sec = 0;
interval-tv_nsec = sysconf(_SC_SCHED_RT_TS) * 1000;
return 0;
So to return to this: surely this can't be right?
- Jukka.
