Re: CVS commit: src/lib/libc/arch/alpha/gen

2012-03-22 Thread David Laight
On Wed, Mar 21, 2012 at 11:57:25PM +0100, Nicolas Joly wrote: On Wed, Mar 21, 2012 at 10:42:58PM +0200, Alan Barrett wrote: On Wed, 21 Mar 2012, Havard Eidnes wrote: Modified Files: src/lib/libc/arch/alpha/gen: fpgetround.c fpsetround.c Log Message: Add some casts to get rid of

Re: CVS commit: src/lib/libarch/alpha

2012-03-22 Thread Alan Barrett
On Thu, 22 Mar 2012, Havard Eidnes wrote: Modified Files: src/lib/libarch/alpha: alpha_pci_io.c Log Message: Add a cast of the shift count to int32_t, so that we don't try to do int32_t long, since ANSI C doesn't perform balancing before the shift operation according to lint. Should

Re: CVS commit: src/lib/libc/arch/alpha/gen

2012-03-22 Thread Valeriy E. Ushakov
On Thu, Mar 22, 2012 at 07:27:18 +, David Laight wrote: On Wed, Mar 21, 2012 at 11:57:25PM +0100, Nicolas Joly wrote: On Wed, Mar 21, 2012 at 10:42:58PM +0200, Alan Barrett wrote: On Wed, 21 Mar 2012, Havard Eidnes wrote: Modified Files: src/lib/libc/arch/alpha/gen: fpgetround.c

Re: CVS commit: src/lib/libc/gen

2012-03-22 Thread Alan Barrett
On Thu, 22 Mar 2012, Havard Eidnes wrote: Modified Files: src/lib/libc/gen: modf_ieee754.c Log Message: Add a pair of casts to silence lint about conversion possibly losing bits. - v.dblu_dbl.dbl_fracl = frac 0x; - v.dblu_dbl.dbl_frach = frac 32; +

Re: CVS commit: src/lib/libarch/alpha

2012-03-22 Thread Christos Zoulas
In article 20120322100642.ga1...@apb-laptoy.apb.alt.za, Alan Barrett a...@cequrux.com wrote: I don't know what balancing means, but this seems bogus to me. The type of the right hand operand of the operator is irrelevant; only its value is important. (See sectiopn 6.5.7 of the C99

Re: CVS commit: src/lib/libarch/alpha

2012-03-22 Thread Joerg Sonnenberger
On Thu, Mar 22, 2012 at 02:51:08PM +0100, Havard Eidnes wrote: IMHO, as long as lint is capable of helping us spot actual problems, adding a few of these sorts of constrcucts seems like a small price to pay. It doesn't. From what I see, the signal to noise ratio of lint is completely

Re: CVS commit: src/lib/libarch/alpha

2012-03-22 Thread Warner Losh
On Mar 22, 2012, at 8:43 AM, Joerg Sonnenberger wrote: On Thu, Mar 22, 2012 at 02:51:08PM +0100, Havard Eidnes wrote: IMHO, as long as lint is capable of helping us spot actual problems, adding a few of these sorts of constrcucts seems like a small price to pay. It doesn't. From what I