Re: CVS commit: src

2012-07-08 Thread Simon Burge
Mindaugas Rasiukevicius wrote: [ ... ] Log Message: Add MurmurHash2 -- a non-cryptographic hash function by Austin Appleby. The code is taken from the upstream and is in the public domain. I'm curious why you've chosen MurmurHash2 instead of MurmurHash3 given the known problems with

Re: CVS commit: src

2012-07-08 Thread Mindaugas Rasiukevicius
Hi Simon, Simon Burge sim...@netbsd.org wrote: [ ... ] Log Message: Add MurmurHash2 -- a non-cryptographic hash function by Austin Appleby. The code is taken from the upstream and is in the public domain. I'm curious why you've chosen MurmurHash2 instead of MurmurHash3 given

Re: CVS commit: src

2012-07-08 Thread Simon Burge
Mindaugas Rasiukevicius wrote: Simon Burge sim...@netbsd.org wrote: [ ... ] Log Message: Add MurmurHash2 -- a non-cryptographic hash function by Austin Appleby. The code is taken from the upstream and is in the public domain. I'm curious why you've chosen MurmurHash2

Re: CVS commit: src

2012-07-08 Thread Mindaugas Rasiukevicius
Simon Burge sim...@netbsd.org wrote: Mindaugas Rasiukevicius wrote: Simon Burge sim...@netbsd.org wrote: [ ... ] Log Message: Add MurmurHash2 -- a non-cryptographic hash function by Austin Appleby. The code is taken from the upstream and is in the public

Re: CVS commit: src

2012-07-08 Thread Joerg Sonnenberger
On Sun, Jul 08, 2012 at 01:21:12AM +, Mindaugas Rasiukevicius wrote: Module Name: src Committed By: rmind Date: Sun Jul 8 01:21:12 UTC 2012 Modified Files: src/common/lib/libc: Makefile.inc src/lib/libc: shlib_version src/lib/libc/hash: Makefile.inc Added

Re: CVS commit: src

2012-07-08 Thread Mindaugas Rasiukevicius
Joerg Sonnenberger jo...@britannica.bec.de wrote: Log Message: Add MurmurHash2 -- a non-cryptographic hash function by Austin Appleby. The code is taken from the upstream and is in the public domain. OK christos@ There are a number of issues with this. First of all, it pollutes the

Re: CVS commit: src/sys

2012-07-08 Thread Valeriy E. Ushakov
On Sun, Jul 08, 2012 at 20:14:13 +, David Laight wrote: Log Message: The MDP_USEDFPU (amd64 and sh3) and MDP_SSTEP (sh3) are lwp flags not process ones, rename to MDL_xxx. While you are at it... according to $ gid -r '^MDP_' | grep 'l_md.*[|]=' there are also amd64: MDP_IRET

Re: CVS commit: src

2012-07-08 Thread Simon Burge
Mindaugas Rasiukevicius wrote: Simon Burge sim...@netbsd.org wrote: Mindaugas Rasiukevicius wrote: Simon Burge sim...@netbsd.org wrote: [ ... ] Log Message: Add MurmurHash2 -- a non-cryptographic hash function by Austin Appleby. The code is taken from

Re: CVS commit: src

2012-07-08 Thread Mindaugas Rasiukevicius
Simon Burge sim...@netbsd.org wrote: Are you referring to the weakness when using 4-bytes? Anyway, that is why the file name does not have 2 in it, so that we could add MurmurHash3 as well. That's completely different to the other hashes we have in the source tree. Can you

Re: CVS commit: src

2012-07-08 Thread Simon Burge
Mindaugas Rasiukevicius wrote: Simon Burge sim...@netbsd.org wrote: Are you referring to the weakness when using 4-bytes? Anyway, that is why the file name does not have 2 in it, so that we could add MurmurHash3 as well. That's completely different to the other hashes we