Re: CVS commit: src/lib/libutil
On Sun, Jul 22, 2012 at 10:21:14PM -0400, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Mon Jul 23 02:21:14 UTC 2012 > > Modified Files: > src/lib/libutil: openpty.3 > > Log Message: > Mention how big the name can be. I don't think we should leak internals like that. It's a path name, the only limit guaranteed by the system should PATH_MAX as such. Joerg
Re: CVS commit: src/regress/lib/libc/cdb
On Sun, Jul 22, 2012 at 07:59:12AM -0400, Julio Merino wrote: > On Sat, Jul 21, 2012 at 7:05 PM, Joerg Sonnenberger > wrote: > > On Sun, Jul 22, 2012 at 02:00:42AM +0300, Jukka Ruohonen wrote: > >> On Sat, Jul 21, 2012 at 10:22:56PM +, Mindaugas Rasiukevicius wrote: > >> > Module Name:src > >> > Committed By: rmind > >> > Date: Sat Jul 21 22:22:55 UTC 2012 > >> > > >> > Added Files: > >> > src/regress/lib/libc/cdb: cdb_test.c > >> > > >> > Log Message: > >> > Add a simple test for cdb(5). > >> > >> Is there a particular reason why you do not use ATF but keep adding your > >> custom test programs?? I recall some kind of resolution about this... > >> > >> (And IMO, even if you dislike ATF, you can not dislike the infrastructure.) > > > > It's just a temporary solution. > > What is just a temporary solution? The test case in regress until I have time to write a proper ATF test case. Joerg
Re: CVS commit: src/sys
On Sun, Jul 22, 2012 at 05:50:16PM +, David Holland wrote: > On Sun, Jul 22, 2012 at 12:53:23AM +, Mindaugas Rasiukevicius wrote: > > Log Message: > > Move some the test for MAKEENTRY into the cache_enter(9). Make some > > variables in vfs_cache.c static, __read_mostly, etc. > > > > No objection on tech-kern@. > > thank you. ...although, this requires a kernel version bump because the filesystem module interface has changed. -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/sys
On Sun, Jul 22, 2012 at 12:53:23AM +, Mindaugas Rasiukevicius wrote: > Log Message: > Move some the test for MAKEENTRY into the cache_enter(9). Make some > variables in vfs_cache.c static, __read_mostly, etc. > > No objection on tech-kern@. thank you. -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/regress/lib/libc/cdb
On Sat, Jul 21, 2012 at 7:12 PM, Mindaugas Rasiukevicius wrote: > Jukka Ruohonen wrote: >> > Module Name:src >> > Committed By: rmind >> > Date: Sat Jul 21 22:22:55 UTC 2012 >> > >> > Added Files: >> > src/regress/lib/libc/cdb: cdb_test.c >> > >> > Log Message: >> > Add a simple test for cdb(5). >> >> Is there a particular reason why you do not use ATF but keep adding your >> custom test programs?? I recall some kind of resolution about this... >> >> (And IMO, even if you dislike ATF, you can not dislike the >> infrastructure.) > > Unfortunately, ATF is problematic and inconvenient to use for me. I can > share my thoughts on this, if there is an interest. Please do. Ignoring the problem is not going to fix it. (Feel free to reply privately or email the atf-devel list only if you do not want to share at large for whatever reason.) > Feel free to convert this to ATF. As for resolution - if you insist, > I can stop adding the tests. Have you gone over http://wiki.netbsd.org/tutorials/atf/ ? (I guess you have, but just in case.) -- Julio Merino / @jmmv
Re: CVS commit: src/regress/lib/libc/cdb
On Sat, Jul 21, 2012 at 7:05 PM, Joerg Sonnenberger wrote: > On Sun, Jul 22, 2012 at 02:00:42AM +0300, Jukka Ruohonen wrote: >> On Sat, Jul 21, 2012 at 10:22:56PM +, Mindaugas Rasiukevicius wrote: >> > Module Name:src >> > Committed By: rmind >> > Date: Sat Jul 21 22:22:55 UTC 2012 >> > >> > Added Files: >> > src/regress/lib/libc/cdb: cdb_test.c >> > >> > Log Message: >> > Add a simple test for cdb(5). >> >> Is there a particular reason why you do not use ATF but keep adding your >> custom test programs?? I recall some kind of resolution about this... >> >> (And IMO, even if you dislike ATF, you can not dislike the infrastructure.) > > It's just a temporary solution. What is just a temporary solution? -- Julio Merino / @jmmv
Re: CVS commit: src/regress/lib/libc/cdb
Izumi Tsutsui wrote: > There is Core's policy: > http://mail-index.NetBSD.org/netbsd-announce/2010/09/06/msg000109.html > >> To this end, > >> we now require that all new tests are written using the ATF tool. > >> All exceptions for tests committed to the old src/regress framework > >> must be ok'd by core prior to commit. > > According to this announcement, you need an approval to commit tests > under src/regress. The change has been reverted. -- Mindaugas
