Re: CVS commit: src/lib/libutil
On Sun, Jul 22, 2012 at 10:21:14PM -0400, Christos Zoulas wrote: Module Name: src Committed By: christos Date: Mon Jul 23 02:21:14 UTC 2012 Modified Files: src/lib/libutil: openpty.3 Log Message: Mention how big the name can be. I don't think we should leak internals like that. It's a path name, the only limit guaranteed by the system should PATH_MAX as such. Joerg
Re: CVS commit: src/sys/dev
I think fec(4) is too common. I'd give SoC periph devs more descriptive names, like mpc8xxxfec(4). On Mon, Jul 23, 2012 at 10:05 PM, Matt Thomas m...@netbsd.org wrote: Module Name:src Committed By: matt Date: Mon Jul 23 13:05:48 UTC 2012 Modified Files: src/sys/dev: DEVNAMES Log Message: Add fec (arm) and mdio (powerpc) To generate a diff of this commit: cvs rdiff -u -r1.277 -r1.278 src/sys/dev/DEVNAMES Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files.
Re: CVS commit: src/sys/fs/puffs
David Holland dholland-sourcechan...@netbsd.org wrote: Di not call cache_enter with path components bigger than NCHNAMLEN, as it panics the kernel. This is wrong; you're reverting rmind's cleanup. I backed out the change. Will someone pullup the change to netbsd-6? -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz m...@netbsd.org
Re: CVS commit: src/sys/fs/puffs
On Mon, Jul 23, 2012 at 10:07:06PM +, Martin Husemann wrote: This is wrong; you're reverting rmind's cleanup. I backed out the change. Will someone pullup the change to netbsd-6? Can you prepare a patch that applies before rmind's cleanup? (Or just one that applies on netbsd-6?) OTOH for netbsd-6 maybe a better patch would be to change cache_enter to return instead of asserting for long filenames. (not sure if this is related) Unfortunately even after the backout a test run still fails reproducably for me - see kern/46734. Doesn't look particularly related to me. Do you know which test kills it? (I guess post it to the PR, not here...) -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/sys/fs/puffs
David Holland dholland-sourcechan...@netbsd.org wrote: OTOH for netbsd-6 maybe a better patch would be to change cache_enter to return instead of asserting for long filenames. If nobody opposes, I can do that. -- Emmanuel Dreyfus http://hcpnet.free.fr/pubz m...@netbsd.org
Re: CVS commit: src/sys/fs/puffs
On Tue, Jul 24, 2012 at 07:13:34AM +0200, Emmanuel Dreyfus wrote: OTOH for netbsd-6 maybe a better patch would be to change cache_enter to return instead of asserting for long filenames. If nobody opposes, I can do that. Best to ask on tech-kern, but it seems unlikely to be controversial. It's hiding bugs but only in the sense that the interface was stupid; and it's probable that puffs isn't the only fs missing the check. -- David A. Holland dholl...@netbsd.org
