re: CVS commit: src/sys
> >> Committed By: matt > >> Date: Sat Sep 1 00:24:44 UTC 2012 > >> > >> Modified Files: > >>src/sys/kern: kern_cpu.c > >>src/sys/sys: cpu_data.h > >> > >> Log Message: > >> Add a kcpuset_t which just includes ourself. > >> Add a ci_cpuname for convenience > > > > there's already this i thought: > > > > sys/cpu_data.h:109: charcpu_name[8];/* eg, > > "cpu4" */ > > > I added > > #define ci_cpuname ci_data.cpu_name why not just use cpu_name(9)? .mrg.
Re: CVS commit: src/sys
On Sep 4, 2012, at 12:55 PM, matthew green wrote: > >> Module Name: src >> Committed By:matt >> Date:Sat Sep 1 00:24:44 UTC 2012 >> >> Modified Files: >> src/sys/kern: kern_cpu.c >> src/sys/sys: cpu_data.h >> >> Log Message: >> Add a kcpuset_t which just includes ourself. >> Add a ci_cpuname for convenience > > there's already this i thought: > > sys/cpu_data.h:109: charcpu_name[8];/* eg, > "cpu4" */ I added #define ci_cpuname ci_data.cpu_name
re: CVS commit: src/sys/dev/pci
> On Sat, Sep 01, 2012 at 02:08:28AM +, Matt Thomas wrote: > > Module Name:src > > Committed By: matt > > Date: Sat Sep 1 02:08:28 UTC 2012 > > > > Modified Files: > > src/sys/dev/pci: if_wm.c > > > > Log Message: > > Shut up gcc about some uninitialized variables. > > > Hum, gcc is wrong here, cmdlen and fields are only used if do_csum == true, > and do_csum cannot be changed between setting it to false and testing it. > > Is it dependant on compiler flags ? FWIW, usually these sorts of problems only appear at -O3. it's the main reason i stopped using -O3 in general. .mrg.
re: CVS commit: src/etc/etc.evbarm
> Module Name: src > Committed By: matt > Date: Sat Sep 1 01:45:17 UTC 2012 > > Modified Files: > src/etc/etc.evbarm: MAKEDEV.conf > > Log Message: > Add lots more ldN dkN > Add drvctl to md we probably want to do this on a bunch of other ports too. i've had to MAKEDEV dk's on recent systems.. .mrg.
re: CVS commit: src/sys
> Module Name: src > Committed By: matt > Date: Sat Sep 1 00:24:44 UTC 2012 > > Modified Files: > src/sys/kern: kern_cpu.c > src/sys/sys: cpu_data.h > > Log Message: > Add a kcpuset_t which just includes ourself. > Add a ci_cpuname for convenience there's already this i thought: sys/cpu_data.h:109: charcpu_name[8];/* eg, "cpu4" */ .mrg.
Re: CVS commit: src/sys/uvm
Matt Thomas wrote: > > On Sep 3, 2012, at 3:33 PM, Mindaugas Rasiukevicius wrote: > > > "Matt Thomas" wrote: > >> Module Name: src > >> Committed By: matt > >> Date: Mon Sep 3 19:53:43 UTC 2012 > >> > >> Modified Files: > >>src/sys/uvm: uvm_km.c uvm_map.c > >> > >> Log Message: > >> Switch to a spin lock (uvm_kentry_lock) which, fortunately, was sitting > >> there unused. > > > > - pmap_growkernel() may use adaptive locks, which cannot be acquired > > with the spin lock held; so the change breaks at least x86 and alpha. > > > > - Why in the caller? I think it would be better do leave it for the > > pmaps, e.g. they may re-use the locks which already provide the > > necessary protection and which need to be taken anyway (like in x86 > > pmap). > > uvm_maxkaddr need a lock for its updating > > growkernel can be called uvm_km_mem_alloc which might be called > at interrupt level. The second point stands, but I see you already fixed it - thanks! As for pmap_growkernel() being called from interrupt context - right, then it seems Xen is broken, as its path in pmap_growkernel() acquires adaptive pmaps_lock and might call pool_cache_invalidate() which can block.. -- Mindaugas
Re: CVS commit: src/sys/dev/pci
On Thu, 30 Aug 2012, Manuel Bouyer wrote: BTW, reason I am asking is that I had previously (about a year or so ago) needed to disable the offload functions on the 82574 because it wasn't working. This commit seems to imply that it fixes only the I350 so I was wondering if some other change that I had missed might have already fixed the 82574. 82575, 82576, 82580(ER) and I350 use the new queue mechanism. So the 82574 should already be working correctly? Thanks, I will verify. It should, yes. But now that programming docs are publically available, we may be able to do something if it doesn't work. Seems to be working just fine with everything enabled. Thanks! # ifconfig wm0 wm0: flags=8843 mtu 1500 capabilities=7ff80 enabled=7ff80 address: bc:ae:c5:30:d9:8a media: Ethernet autoselect (1000baseT full-duplex,flowcontrol,rxpause,txpause) status: active inet 50.193.51.18 netmask 0xfff0 broadcast 50.193.51.31 inet6 fe80::beae:c5ff:fe30:d98a%wm0 prefixlen 64 scopeid 0x1 inet6 2001:470:1f05:80f::1 prefixlen 96 # - | Paul Goyette | PGP Key fingerprint: | E-mail addresses: | | Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com| | Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net | | Kernel Developer | | pgoyette at netbsd.org | -
