Re: CVS commit: src/sys/arch
Hi! From: David Holland dholland-sourcechan...@netbsd.org Date: Sat, 8 Dec 2012 20:44:32 + On Sat, Dec 08, 2012 at 12:36:31PM +, KIYOHARA Takashi wrote: Modified Files: src/sys/arch/i386/i386: db_interface.c trap.c src/sys/arch/x86/x86: bus_dma.c cpu.c platform.c Log Message: #ifdef - #endif-ed. NMCA, NISA, NNPX, NIOAPIC, LAPIC, MPBIOS and MULTIPROCESSOR. MULTIPROCESSOR is not meant to be optional on x86. Please think for other x86 machine(e.g. pc98, FM-TOWNS :). # Also please create options SMBIOS and LONGRUN. Thanks, -- kiyohara
Re: CVS commit: src/sys/arch
On Sat, Dec 08, 2012 at 12:36:31PM +, KIYOHARA Takashi wrote: Module Name: src Committed By: kiyohara Date: Sat Dec 8 12:36:31 UTC 2012 Modified Files: src/sys/arch/i386/i386: db_interface.c trap.c src/sys/arch/x86/x86: bus_dma.c cpu.c platform.c Log Message: #ifdef - #endif-ed. NMCA, NISA, NNPX, NIOAPIC, LAPIC, MPBIOS and MULTIPROCESSOR. Please, add no new #ifdefs. Let config(1) and the linker configure the kernel. Dave -- David Young dyo...@pobox.comUrbana, IL(217) 721-9981
Re: CVS commit: src/sys/arch
On Sun, Dec 09, 2012 at 11:27:14AM -0600, David Young wrote: On Sat, Dec 08, 2012 at 12:36:31PM +, KIYOHARA Takashi wrote: Module Name:src Committed By: kiyohara Date: Sat Dec 8 12:36:31 UTC 2012 Modified Files: src/sys/arch/i386/i386: db_interface.c trap.c src/sys/arch/x86/x86: bus_dma.c cpu.c platform.c Log Message: #ifdef - #endif-ed. NMCA, NISA, NNPX, NIOAPIC, LAPIC, MPBIOS and MULTIPROCESSOR. Please, add no new #ifdefs. Let config(1) and the linker configure the kernel. Indeed. I doubt that any modern systems are so short of memory that removing the code fragments from switch statements (because the event can't happen) matters. One good reason for removing code is that is isn't likely to be used on anything anyone might try to run in on, has probably bitrotted (because it hasn't been run for years), might be a security risk, and complicates the other code paths. Which is, more or less, why i386 support was removed. There is probably other 'support' for systems that no one has any more, and really aren't of enough historical interest to keep supporting. David -- David Laight: da...@l8s.co.uk
Re: CVS commit: src/sys/arch/arm
On Dec 9, 2012, at 6:02 PM, Christos Zoulas wrote: In article 20121210013731.5b86c17...@cvs.netbsd.org, Matt Thomas source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By:matt Date:Mon Dec 10 01:37:31 UTC 2012 Modified Files: src/sys/arch/arm/arm32: arm32_machdep.c cpuswitch.S fault.c genassym.cf vm_machdep.c src/sys/arch/arm/include: pcb.h Log Message: Rename pcb_sp/PCB_SP to pcb_ksp/PCB_KSP so that ipsec.c will compile. I already fixed that on head, in ipsec.c I think sys/proc.h including machine/pcb.h is wrong. Nothing in machine/pcb.h needs to be used by MI code.
Re: CVS commit: src/sys/arch/arm
In article b25fedfc-40a2-48f1-b0ad-ecd1bf4f6...@3am-software.com, Matt Thomas m...@3am-software.com wrote: On Dec 9, 2012, at 6:02 PM, Christos Zoulas wrote: In article 20121210013731.5b86c17...@cvs.netbsd.org, Matt Thomas source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name:src Committed By: matt Date: Mon Dec 10 01:37:31 UTC 2012 Modified Files: src/sys/arch/arm/arm32: arm32_machdep.c cpuswitch.S fault.c genassym.cf vm_machdep.c src/sys/arch/arm/include: pcb.h Log Message: Rename pcb_sp/PCB_SP to pcb_ksp/PCB_KSP so that ipsec.c will compile. I already fixed that on head, in ipsec.c I think sys/proc.h including machine/pcb.h is wrong. Nothing in machine/pcb.h needs to be used by MI code. Ok, I'll see if I can get rid of it. christos