Re: CVS commit: src/usr.bin/man

2013-07-18 Thread Valery Ushakov
On Thu, Jul 18, 2013 at 11:39:08 -0400, Christos Zoulas wrote: > - don't use snprintf on a user-provided buffer This: - (void)snprintf(buf, sizeof(buf), fmt, escpage, suffix->s); + fixstring(buf, sizeof(buf), fmt, escpage); seems wrong, as it loses suffix->s, doesn't it? And fixstring is a ter

Re: CVS commit: src/usr.bin/man

2013-07-18 Thread Valery Ushakov
On Thu, Jul 18, 2013 at 11:39:08 -0400, Christos Zoulas wrote: > - fix cast qual issues Do you really need EMPTY hack? Why not just (untested) - pg->gl_pathv[cnt] = ""; + *pg->gl_pathv[cnt] = '\0'; -uwe