Re: CVS commit: src/lib/libcurses
On Sun, Nov 10, 2013 at 23:45:46 +, David Laight wrote: > On Sat, Nov 09, 2013 at 11:17:00AM +, Brett Lymn wrote: > > Module Name:src > > Committed By: blymn > > Date: Sat Nov 9 11:16:59 UTC 2013 > > > > Modified Files: > > src/lib/libcurses: add_wch.c addbytes.c addch.c addchnstr.c > > curses_private.h > > > > Log Message: > > Rename the old __waddbytes function to _cursesi_waddbytes and add a > > parameter that controls whether or not certain characters in the > > string are interpreted or not (things like tab being expanded). > ... > > Fix the addchstr family functions so that they call _cursesi_waddbytes > > with character interpretation off as per SUSV2. > > Does not expanding tabs actually make sense? > At a guess it would lead to tab characters being send to the terminal > and the display getting f**cked up. > > I also suspect it will break applications that expect curses to > expand tabs. This is what addchstr() &c are defined to to. Position is not changed, special characters are not processed, wrapping is not done. -uwe
Re: CVS commit: src/lib/libcurses
On Sat, Nov 09, 2013 at 11:17:00AM +, Brett Lymn wrote: > Module Name: src > Committed By: blymn > Date: Sat Nov 9 11:16:59 UTC 2013 > > Modified Files: > src/lib/libcurses: add_wch.c addbytes.c addch.c addchnstr.c > curses_private.h > > Log Message: > Rename the old __waddbytes function to _cursesi_waddbytes and add a > parameter that controls whether or not certain characters in the > string are interpreted or not (things like tab being expanded). ... > Fix the addchstr family functions so that they call _cursesi_waddbytes > with character interpretation off as per SUSV2. Does not expanding tabs actually make sense? At a guess it would lead to tab characters being send to the terminal and the display getting f**cked up. I also suspect it will break applications that expect curses to expand tabs. David -- David Laight: da...@l8s.co.uk
Re: CVS commit: src/sys/arch/xen/x86
On Nov 10, 4:50pm, Jukka Ruohonen wrote: } On Sun, Nov 10, 2013 at 01:19:13AM +, John Nemeth wrote: } > Module Name:src } > Committed By: jnemeth } > Date: Sun Nov 10 01:19:13 UTC 2013 } > } > Modified Files: } > src/sys/arch/xen/x86: x86_xpmap.c } > } > Log Message: } > Change xpq_flush_cache to just do WBINVD letting the hypervisor trap and } > handle it as MMUEXT_FLUSH_CACHE is a privileged hypervisor operation. } } x86_wbind()? Which however appears to be (icorrectly?) #ifndef'd for Xen. Uh, the function for Xen would be wbinvd(), which would create a very nice infinite loop as all that function does is call xpq_flush_cache(). This change was fully discussed on tech-xen@. }-- End of excerpt from Jukka Ruohonen
Re: CVS commit: src/sys/arch/xen/x86
On Sun, Nov 10, 2013 at 01:19:13AM +, John Nemeth wrote: > Module Name: src > Committed By: jnemeth > Date: Sun Nov 10 01:19:13 UTC 2013 > > Modified Files: > src/sys/arch/xen/x86: x86_xpmap.c > > Log Message: > Change xpq_flush_cache to just do WBINVD letting the hypervisor trap and > handle it as MMUEXT_FLUSH_CACHE is a privileged hypervisor operation. x86_wbind()? Which however appears to be (icorrectly?) #ifndef'd for Xen. - Jukka.
Re: CVS commit: src/sys/fs/tmpfs
"J. Hannken-Illjes" wrote: > > Module Name:src > > Committed By: rmind > > Date: Fri Nov 8 15:44:23 UTC 2013 > > > <...> > > The tests fs/vfs/t_union/tmpfs_basic and fs/vfs/t_union/tmpfs_whiteout > start failing after this commit. > Fixed. -- Mindaugas
Re: CVS commit: src/sys/fs/tmpfs
On Nov 8, 2013, at 4:44 PM, Mindaugas Rasiukevicius wrote: > Module Name: src > Committed By: rmind > Date: Fri Nov 8 15:44:23 UTC 2013 > > Modified Files: > src/sys/fs/tmpfs: tmpfs.h tmpfs_rename.c tmpfs_subr.c tmpfs_vfsops.c > tmpfs_vnops.c > > Log Message: > tmpfs: replace the broken tmpfs_dircookie() logic which uses the node > address truncated to 31 bits (required for 32-bit readdir compatibility, > e.g. linux32). Instead, assign 2^31 range using the following logic: > - The first half of the 2^31 is assigned incrementally (the fast path). > - When exceeded, use the second half of 2^31, but manage with vmem(9). > > It will require 2 billion files per-directory to trigger vmem(9) usage. > Also, while here, add some fixes for tmpfs_unmount(). > > Should fix PR/47739, PR/47480, PR/46088 and PR/41068. > Thanks to wiz@ for stress testing. The tests fs/vfs/t_union/tmpfs_basic and fs/vfs/t_union/tmpfs_whiteout start failing after this commit. -- J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)
