Re: CVS commit: src/sys/kern
On Jan 12, 3:17am, dholland-sourcechan...@netbsd.org (David Holland) wrote: -- Subject: Re: CVS commit: src/sys/kern | On Sun, Jan 12, 2014 at 02:13:34PM +1100, matthew green wrote: | > > Modified Files: | > > src/sys/kern: subr_prf.c | > > | > > Log Message: | > > Revert, breaks the build due to missing rumpns_delay in librump.so. | > | > thanks. | > | > when this comes back, i'd rather it defaulted to zero but was a | > sysctl controllable value. | > | > i do not want this for my serial console systems, or my systems | > that drop to ddb on crashes before (manual) rebooting. | | Surely it should be set up so it skips the delay if ddb is active? Good idea. christos
Re: CVS commit: src/sys/kern
On Sun, Jan 12, 2014 at 02:13:34PM +1100, matthew green wrote: > > Modified Files: > >src/sys/kern: subr_prf.c > > > > Log Message: > > Revert, breaks the build due to missing rumpns_delay in librump.so. > > thanks. > > when this comes back, i'd rather it defaulted to zero but was a > sysctl controllable value. > > i do not want this for my serial console systems, or my systems > that drop to ddb on crashes before (manual) rebooting. Surely it should be set up so it skips the delay if ddb is active? -- David A. Holland dholl...@netbsd.org
re: CVS commit: src/sys/kern
> Module Name: src > Committed By: joerg > Date: Sun Jan 12 00:29:15 UTC 2014 > > Modified Files: > src/sys/kern: subr_prf.c > > Log Message: > Revert, breaks the build due to missing rumpns_delay in librump.so. thanks. when this comes back, i'd rather it defaulted to zero but was a sysctl controllable value. i do not want this for my serial console systems, or my systems that drop to ddb on crashes before (manual) rebooting. .mrg.
Re: CVS commit: src/etc
On Jan 8, 2014, at 10:25 , Greg Troxel wrote: > Why do you think the configured servers should be given query > permission? Is that a sense of courtesy to the pool operators that they > should be able to run "ntpdc -c monlist" and "ntpq -p" at machines that > are syncing from them? Yes, that's polite. It is suggested by the NTP peering guidelines (and I know "server" and "peer" are different). Erik
Re: CVS commit: src/sys/arch/arm
On Jan 11, 2014, at 9:32 AM, Matt Thomas wrote: > Module Name: src > Committed By: matt > Date: Sat Jan 11 17:32:20 UTC 2014 > > Modified Files: > src/sys/arch/arm/arm32: arm32_machdep.c fault.c > src/sys/arch/arm/include: locore.h > > Log Message: > Add hw.printfataltraps sysctl. Always print fatal traps for init. For all > other processes, only do so if cpu_printfataltraps is true. actaully it's machdep.printfataltraps.
Re: CVS commit: src/external/bsd/atf/dist/atf-sh
On Jan 11, 9:05am, ju...@meroh.net (Julio Merino) wrote: -- Subject: Re: CVS commit: src/external/bsd/atf/dist/atf-sh | The reason it works like it does is because atf-run takes care of most | cleanup by itself and runs every test case on its own subprocess. | | The cleanup routine supports exists only to let the test deconfigure | global resources that it may have affected, like, for example, kernel | modules, file systems, routing table, etc. The tests that require | this should be a minority, because tests affecting global system state | should be minimized (and, thanks to rump, that can be generally | avoided these days). | | Keep in mind that the feature set of the 3 atf libraries must be | identical from the point of view of atf-run. trap might have worked | on atf-sh, but there is no way you can get proper cleanup like this on | C. If the program crashes, the cleanup won't run -- and that's why | cleanup is intended to run separately so that it can be executed no | matter what happens to the process that ran the test body. But the languages are not the same. You could have a "cleanup on crash" in C where you don't need that for sh. The parent certainly knows if the child crashed. | Changing the way this works in the atf libraries is not an option. | But with the switch to Kyua it wouldn't matter, because Kyua supports | test programs built with different "frameworks" (including "no | framework"). We'd investigate using other unit-testing libraries at | that point that have more traditional fixture definitions, and even | use different approaches for sh and C, all within the same NetBSD test | suite. I'll be posting an update to the plan in this area soon. Sounds good. I would like for the most part of have self-standing tests that don't require infrastructure wrapping to run (it is fine to utilize libraries to ease up writing them though). christos
Re: CVS commit: src/external/bsd/atf/dist/atf-sh
On Fri, Jan 10, 2014 at 7:31 PM, Christos Zoulas wrote: > I would have preferred that the cleanup functionality was implemented > differently, running in the context of the shell that ran the test. > This could have been done by issuing a 'trap test_cleanup 0' before > invoking the test, instead of all the complex stuff that is currently > been done (unless I am missing something). The reason it works like it does is because atf-run takes care of most cleanup by itself and runs every test case on its own subprocess. The cleanup routine supports exists only to let the test deconfigure global resources that it may have affected, like, for example, kernel modules, file systems, routing table, etc. The tests that require this should be a minority, because tests affecting global system state should be minimized (and, thanks to rump, that can be generally avoided these days). Keep in mind that the feature set of the 3 atf libraries must be identical from the point of view of atf-run. trap might have worked on atf-sh, but there is no way you can get proper cleanup like this on C. If the program crashes, the cleanup won't run -- and that's why cleanup is intended to run separately so that it can be executed no matter what happens to the process that ran the test body. Changing the way this works in the atf libraries is not an option. But with the switch to Kyua it wouldn't matter, because Kyua supports test programs built with different "frameworks" (including "no framework"). We'd investigate using other unit-testing libraries at that point that have more traditional fixture definitions, and even use different approaches for sh and C, all within the same NetBSD test suite. I'll be posting an update to the plan in this area soon. -- Julio Merino / @jmmv
