Re: CVS commit: src/sys/netsmb
On Thu, Feb 20, 2014 at 08:41:36PM +0900, Takeshi Nakayama wrote: Joerg Sonnenberger jo...@netbsd.org wrote Module Name:src Committed By: joerg Date: Thu Feb 20 11:08:57 UTC 2014 Modified Files: src/sys/netsmb: iconv.c Log Message: Don't dereference NULL pointers. I guess proper fix is to move NULL check in iconv_conv(). The issue was not so much the inbuf check, but that inbytesleft is a NULL pointer. That said, I don't understand what the first call was supposed to do. Joerg
Re: CVS commit: src/sys/netsmb
Joerg Sonnenberger jo...@britannica.bec.de wrote On Thu, Feb 20, 2014 at 08:41:36PM +0900, Takeshi Nakayama wrote: Joerg Sonnenberger jo...@netbsd.org wrote Module Name: src Committed By: joerg Date: Thu Feb 20 11:08:57 UTC 2014 Modified Files: src/sys/netsmb: iconv.c Log Message: Don't dereference NULL pointers. I guess proper fix is to move NULL check in iconv_conv(). The issue was not so much the inbuf check, but that inbytesleft is a NULL pointer. That said, I don't understand what the first call was supposed to do. iconv_conv() is a function correspond to iconv(3), so the first call intends to initialize the internal state. But iconv_open() and iconv_close() are competely dummy functions, so it does nothing for now. -- Takeshi Nakayama
Re: CVS commit: src/share/mk
On Jan 23, 2014, at 8:53 PM, Masao Uebayashi uebay...@gmail.com wrote: How about kernel modules? even kernel modules
Re: CVS commit: src/share/mk
On Thu, Feb 20, 2014 at 01:30:27PM -0800, Matt Thomas wrote: On Jan 23, 2014, at 8:53 PM, Masao Uebayashi uebay...@gmail.com wrote: How about kernel modules? even kernel modules Personally I think that DESTDIR should only contain the headers needed for applications. So some parts of sbin would only be buildable in a full source tree. At the moment some headers seem to get released so that things like libkvm (and other kernel grovellers) can be built. If you look at the .d files for applcations you'll see that they end up including all sorts of .h files that they really shouldn't need. Separation in the kernel is even worse. David -- David Laight: da...@l8s.co.uk
Re: CVS commit: src/bin/ls
On Thu, 20 Feb 2014, Christos Zoulas wrote: Modified Files: src/bin/ls: ls.1 ls.c ls.h print.c Log Message: Add -O (only leaf files) and -P (print full path), from tls@ Do any other ls implementations have such options? I like the idea of being able to run ls -ROP1 . instead of find . type f -print, but I'd like the options to be compatible with other operating systems. --apb (Alan Barrett)
