Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread Jukka Ruohonen
On Thu, Mar 13, 2014 at 04:01:33AM +, David Holland wrote: > On Wed, Mar 12, 2014 at 08:11:26AM -0700, Paul Goyette wrote: > > >>Me, too. But I'd rather that we had the equivalent ISCLR() macro, too, > > >>to remove another negation/complement. > > > > > >So is ISCLR when passed two bits tr

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread David Holland
On Wed, Mar 12, 2014 at 08:11:26AM -0700, Paul Goyette wrote: > >>Me, too. But I'd rather that we had the equivalent ISCLR() macro, too, > >>to remove another negation/complement. > > > >So is ISCLR when passed two bits true if both are clear, or if it's just > >not the case that both are set?

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread David Laight
On Thu, Mar 13, 2014 at 12:32:38AM +0900, Mindaugas Rasiukevicius wrote: > Taylor R Campbell wrote: > >Date: Wed, 12 Mar 2014 16:16:32 +0200 > >From: Jukka Ruohonen > > > >On Wed, Mar 12, 2014 at 09:39:23AM +, Juergen Hannken-Illjes wrote: > >> Restructure layer_lock() to alw

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread Mindaugas Rasiukevicius
Taylor R Campbell wrote: >Date: Wed, 12 Mar 2014 16:16:32 +0200 >From: Jukka Ruohonen > >On Wed, Mar 12, 2014 at 09:39:23AM +, Juergen Hannken-Illjes wrote: >> Restructure layer_lock() to always lock before testing for dead node. >> Use ISSET() to test flags, add assertio

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread Paul Goyette
On Wed, 12 Mar 2014, Greg Troxel wrote: Paul Goyette writes: Me, too. But I'd rather that we had the equivalent ISCLR() macro, too, to remove another negation/complement. So is ISCLR when passed two bits true if both are clear, or if it's just not the case that both are set? Arguably this

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread Greg Troxel
Paul Goyette writes: > Me, too. But I'd rather that we had the equivalent ISCLR() macro, too, > to remove another negation/complement. So is ISCLR when passed two bits true if both are clear, or if it's just not the case that both are set? Arguably this points out that the ISSET docs should ex

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread Paul Goyette
On Wed, 12 Mar 2014, Greg Troxel wrote: Taylor R Campbell writes: Date: Wed, 12 Mar 2014 16:16:32 +0200 From: Jukka Ruohonen On Wed, Mar 12, 2014 at 09:39:23AM +, Juergen Hannken-Illjes wrote: > Restructure layer_lock() to always lock before testing for dead node. > Use IS

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread Greg Troxel
Taylor R Campbell writes: >Date: Wed, 12 Mar 2014 16:16:32 +0200 >From: Jukka Ruohonen > >On Wed, Mar 12, 2014 at 09:39:23AM +, Juergen Hannken-Illjes wrote: >> Restructure layer_lock() to always lock before testing for dead node. >> Use ISSET() to test flags, add assert

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread Taylor R Campbell
Date: Wed, 12 Mar 2014 16:16:32 +0200 From: Jukka Ruohonen On Wed, Mar 12, 2014 at 09:39:23AM +, Juergen Hannken-Illjes wrote: > Restructure layer_lock() to always lock before testing for dead node. > Use ISSET() to test flags, add assertions. As I wrote in the manual page,

Re: CVS commit: src/sys/miscfs/genfs

2014-03-12 Thread Jukka Ruohonen
On Wed, Mar 12, 2014 at 09:39:23AM +, Juergen Hannken-Illjes wrote: > Module Name: src > Committed By: hannken > Date: Wed Mar 12 09:39:23 UTC 2014 > > Modified Files: > src/sys/miscfs/genfs: layer_vnops.c > > Log Message: > Restructure layer_lock() to always lock before testin