Re: CVS commit: src/sys/arch/amd64/amd64

2014-05-12 Thread Masao Uebayashi 
On Tue, May 13, 2014 at 2:28 AM, Jonathan A. Kollasch
 wrote:
> On Mon, May 12, 2014 at 07:05:29PM +0200, Joerg Sonnenberger wrote:
>> On Mon, May 12, 2014 at 01:49:24PM +, Masao Uebayashi wrote:
>> > Module Name:src
>> > Committed By:   uebayasi
>> > Date:   Mon May 12 13:49:24 UTC 2014
>> >
>> > Modified Files:
>> > src/sys/arch/amd64/amd64: machdep.c
>> >
>> > Log Message:
>> > Don't reserve space (128) on signal stack for unknown reasons; the actual
>> > space for struct sigframe_siginfo (+ alignment) is allocated just below.
>>
>> AMD64 uses a redzone, so the compiler can put up to 128 Bytes on the
>> stack without having to adjust RSP. Please revert immediately.
>
> Done.

Thanks.  I left a comment there.

re: CVS commit: src/sys/arch/mips

2014-05-12 Thread matthew green 

> > >   gcc 4.5, gmp patched as
> > > posted earlier.
> > 
> > Is this ready to commit?
> 
> Good question, I'd like to hear from one of the Matts first. All the
> patch does is to disable using assembly routines when building n32
> binaries ( as in, mips64* but not _LP64 ). Seems to work, at least on
> sgimips, needs more torturing on Loongson.

there are a couple of minor problems from my POV:

- they're mostly generated files you've changed (at least,
  the Makefile.inc's..)

- the comments in the code seems to indicate that what we
  have right now *should* work, as it was designed to work
  with irix n32.  mac's experience makes me question this.


i think they could be commited right now, but please add
an entry to doc/HACKS.



.mrg.

Re: CVS commit: src/sys/arch/amd64/amd64

2014-05-12 Thread Jonathan A. Kollasch 
On Mon, May 12, 2014 at 07:05:29PM +0200, Joerg Sonnenberger wrote:
> On Mon, May 12, 2014 at 01:49:24PM +, Masao Uebayashi wrote:
> > Module Name:src
> > Committed By:   uebayasi
> > Date:   Mon May 12 13:49:24 UTC 2014
> > 
> > Modified Files:
> > src/sys/arch/amd64/amd64: machdep.c
> > 
> > Log Message:
> > Don't reserve space (128) on signal stack for unknown reasons; the actual
> > space for struct sigframe_siginfo (+ alignment) is allocated just below.
> 
> AMD64 uses a redzone, so the compiler can put up to 128 Bytes on the
> stack without having to adjust RSP. Please revert immediately.

Done.

Re: CVS commit: src/sys/arch/amd64/amd64

2014-05-12 Thread Joerg Sonnenberger 
On Mon, May 12, 2014 at 01:49:24PM +, Masao Uebayashi wrote:
> Module Name:  src
> Committed By: uebayasi
> Date: Mon May 12 13:49:24 UTC 2014
> 
> Modified Files:
>   src/sys/arch/amd64/amd64: machdep.c
> 
> Log Message:
> Don't reserve space (128) on signal stack for unknown reasons; the actual
> space for struct sigframe_siginfo (+ alignment) is allocated just below.

AMD64 uses a redzone, so the compiler can put up to 128 Bytes on the
stack without having to adjust RSP. Please revert immediately.

Joerg

Re: CVS commit: src/sys/arch/mips

2014-05-12 Thread Nick Hudson 

On 05/12/14 02:24, Michael wrote:

Hello,

On Sun, 11 May 2014 19:07:01 +0100
Nick Hudson  wrote:


On 11/05/2014 16:47, Michael wrote:

Hello,


[snip]

My O2's been building stuff from pkgsrc for the last hour without any
of the glitches we've seen before ( fingers crossed )

Good news.

It's doing much better but something is still not quite right. Saw a
SIGILL from /usr/bin/ar, disassemply showed a bunch of seemingly random
0xwhatever between what looked like sane MIPS instructions, problem
disappeared after reboot.


Damn. OK, will take another look.

Nick