Re: CVS commit: src/sys/ufs/ufs

2014-05-16 Thread David Holland
On Fri, May 16, 2014 at 06:48:06PM +, Martin Husemann wrote: > > The problem is that the tokens are memcmp'd, so if they include struct > > padding this may not work. > > All filesystems I've seen init the struct with a full memset to 0, so > all padding fields should be initialized as we

Re: CVS commit: src/sys/ufs/ufs

2014-05-16 Thread Martin Husemann
On Fri, May 16, 2014 at 03:54:44PM +, David Holland wrote: > The problem is that the tokens are memcmp'd, so if they include struct > padding this may not work. All filesystems I've seen init the struct with a full memset to 0, so all padding fields should be initialized as well. However, we

Re: CVS commit: src/sys/ufs/ufs

2014-05-16 Thread David Laight
On Fri, May 16, 2014 at 03:54:44PM +, David Holland wrote: > > > Indeed rebooting with an updated kernel will give active NFS clients > > problems, but I am not sure we should realy care nor how we could > > possibly avoid this one time issue. We have changed encoding of > > filehandles be

Re: CVS commit: src/sys/ufs/ufs

2014-05-16 Thread David Holland
On Fri, May 16, 2014 at 09:04:37AM +0200, Martin Husemann wrote: > > I don't think it is a problem by itself as the file handle is opaque, > > but it is certainly wasteful to not put ufid_ino first. > > That is not possible, the first few bytes of the structure must match > struct fid from fs

Re: CVS commit: src

2014-05-16 Thread Nick Hudson
On 05/16/14 01:48, Mindaugas Rasiukevicius wrote: Module Name:src Committed By: rmind Date: Fri May 16 00:48:41 UTC 2014 Modified Files: src/share/man/man9: pcu.9 src/sys/arch/alpha/alpha: fp_complete.c src/sys/arch/alpha/include: alpha.h src/sys/a

Re: CVS commit: src/sys/ufs/ufs

2014-05-16 Thread Martin Husemann
On Fri, May 16, 2014 at 12:12:00AM +0200, Joerg Sonnenberger wrote: > I don't think it is a problem by itself as the file handle is opaque, > but it is certainly wasteful to not put ufid_ino first. That is not possible, the first few bytes of the structure must match struct fid from fstypes.h. Th