Re: CVS commit: src/sys/arch

[Manuel Bouyer]

On Fri, Jun 13, 2014 at 05:52:53PM -0700, Paul Goyette wrote:
 I modified the newer patch so that things still compile on non-XEN kernels,
 and added the version check to an additional invocation of xen_pagezero().
 The patch is attached, and I have verified that it successfully boots under
 the pre-3.4 hypervisor.
 
 Is there any reason why this should not be committed?

please move XEN_VERSION_SUPPORTED() to an header (hypervisor.h is
probably the most appropriate). Looks OK otherwise.

thanks !


-- 
Manuel Bouyer bou...@antioche.eu.org
 NetBSD: 26 ans d'experience feront toujours la difference
--

Re: CVS commit: src/sys

[J. Hannken-Illjes]

On 03 Jun 2014, at 21:30, Joerg Sonnenberger jo...@netbsd.org wrote:

 Module Name:  src
 Committed By: joerg
 Date: Tue Jun  3 19:30:30 UTC 2014
 
 Modified Files:
   src/sys/fs/cd9660: cd9660_lookup.c
   src/sys/fs/filecorefs: filecore_lookup.c
   src/sys/kern: vfs_cache.c
   src/sys/sys: namei.src
   src/sys/ufs/ext2fs: ext2fs_lookup.c
   src/sys/ufs/lfs: ulfs_lookup.c
   src/sys/ufs/ufs: ufs_lookup.c
 
 Log Message:
 Introduce two helper functions to centralise the namecache statistics
 in vfs_cache.c. Use consistent locking around the per-cpu data.

This change leads to a deadlock:

Thread 1 calls cache_revlookup(),
  holds ncp-nc_lock @ line 589,
  wants cpup-cpu_lock @ line 604

Thread 2 calls cache_lookup(),
  holds cpup-cpu_lock @ line 391,
  calls cache_lookup_entry(),
wants ncp-nc_lock @ line 308

--
J. Hannken-Illjes - hann...@eis.cs.tu-bs.de - TU Braunschweig (Germany)