Re: CVS commit: src/external/bsd/dhcp/include

2014-07-12 Thread Christos Zoulas
In article <20140712200319.aa0b...@cvs.netbsd.org>,
S.P.Zeidler  wrote:
>-=-=-=-=-=-
>
>Module Name:   src
>Committed By:  spz
>Date:  Sat Jul 12 20:03:19 UTC 2014
>
>Modified Files:
>   src/external/bsd/dhcp/include: config.h
>
>Log Message:
>update config.h to the new version and enable DHCPv6
>
>
>To generate a diff of this commit:
>cvs rdiff -u -r1.4 -r1.5 src/external/bsd/dhcp/include/config.h
>
>Please note that diffs are not public domain; they are subject to the
>copyright notices on the relevant files.
>
>
>-=-=-=-=-=-
>
>Modified files:
>

This was there so that we could obey USE_INET6...

>-#if 0
>-/* From the Makefile */
> /* Define to 1 to include DHCPv6 support. */
> #define DHCPv6 1
>-#endif
> 

This is definitely wrong, and should be based on 

>+/* Define WORDS_BIGENDIAN to 1 if your processor stores words with the most
>+   significant byte first (like Motorola and SPARC, unlike Intel). */
>+#if defined AC_APPLE_UNIVERSAL_BUILD
>+# if defined __BIG_ENDIAN__
>+#  define WORDS_BIGENDIAN 1
>+# endif
>+#else
>+# ifndef WORDS_BIGENDIAN
>+/* #  undef WORDS_BIGENDIAN */
>+# endif
>+#endif

christos



Re: CVS commit: src/distrib/sets/lists/tests

2014-07-12 Thread Paul Goyette

Please do not remove lines from this file!

Instead, please mark the files as "obsolete" as directed at the top of 
the file!



On Sat, 12 Jul 2014, Darren Reed wrote:


Module Name:src
Committed By:   darrenr
Date:   Sat Jul 12 14:40:06 UTC 2014

Modified Files:
src/distrib/sets/lists/tests: mi

Log Message:
Test n17_6 does not yet exist so remove unrequired files and test case


To generate a diff of this commit:
cvs rdiff -u -r1.579 -r1.580 src/distrib/sets/lists/tests/mi

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


!DSPAM:53c148cc164524526011279!




-
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:   |
| Customer Service | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at juniper.net |
| Kernel Developer |  | pgoyette at netbsd.org  |
-


re: CVS commit: src/sys/miscfs/procfs

2014-07-12 Thread matthew green

Nicolas Joly writes:
> On Sat, Jul 12, 2014 at 08:11:46PM +1000, matthew green wrote:
> > 
> > "Nicolas Joly" writes:
> > > Module Name:  src
> > > Committed By: njoly
> > > Date: Sat Jul 12 09:58:39 UTC 2014
> > > 
> > > Modified Files:
> > >   src/sys/miscfs/procfs: procfs_linux.c
> > > 
> > > Log Message:
> > > Use kproc2 to provide sensible informations for /proc//stat.
> > 
> > hmm, kernel code should really avoid using the userland compat layer.
> > you're processing something from one known layout to another known
> > layout.. userland needs it because it only knows one of them, which
> > has a known forwards/backwards compat layout.
> 
> I was trying to avoid duplicating all the needed computation ...
> /proc//stat is another exact version (kernel) of the userland
> processes infos.
> 
> Do we need another intermediate layer to fill a kernel only structure
> which can then be easily translated to kproc2 ?

hmmm, OK.  your idea is probably a good one, but i see why
you'd chosen what you have.

thanks.


.mrg.


Re: CVS commit: src/sys/miscfs/procfs

2014-07-12 Thread Nicolas Joly
On Sat, Jul 12, 2014 at 08:11:46PM +1000, matthew green wrote:
> 
> "Nicolas Joly" writes:
> > Module Name:src
> > Committed By:   njoly
> > Date:   Sat Jul 12 09:58:39 UTC 2014
> > 
> > Modified Files:
> > src/sys/miscfs/procfs: procfs_linux.c
> > 
> > Log Message:
> > Use kproc2 to provide sensible informations for /proc//stat.
> 
> hmm, kernel code should really avoid using the userland compat layer.
> you're processing something from one known layout to another known
> layout.. userland needs it because it only knows one of them, which
> has a known forwards/backwards compat layout.

I was trying to avoid duplicating all the needed computation ...
/proc//stat is another exact version (kernel) of the userland
processes infos.

Do we need another intermediate layer to fill a kernel only structure
which can then be easily translated to kproc2 ?

-- 
Nicolas Joly

Biology IT Center
Institut Pasteur, Paris.


re: CVS commit: src/sys/miscfs/procfs

2014-07-12 Thread matthew green

"Nicolas Joly" writes:
> Module Name:  src
> Committed By: njoly
> Date: Sat Jul 12 09:58:39 UTC 2014
> 
> Modified Files:
>   src/sys/miscfs/procfs: procfs_linux.c
> 
> Log Message:
> Use kproc2 to provide sensible informations for /proc//stat.

hmm, kernel code should really avoid using the userland compat layer.
you're processing something from one known layout to another known
layout.. userland needs it because it only knows one of them, which
has a known forwards/backwards compat layout.


.mrg.


Re: CVS commit: src/sys

2014-07-12 Thread Masao Uebayashi
Not objecting this paricular change, but I hope that sys/sysctl.h be
less loaded, ideally porviding only sysctl base definitions, than more
loaded...