Re: CVS commit: src/sys/dev

2014-09-06 Thread Paul Goyette

+   i = year / 100;
+   days += i * DAYS100YEARS;
+   year -= i * 100;

Shouldn't this one be

days -= i * DAYS100YEARS;


On Sat, 6 Sep 2014, Martin Husemann wrote:

Module Name:src
Committed By:   martin
Date:   Sat Sep  6 18:04:28 UTC 2014

Modified Files:
src/sys/dev: clock_subr.c

Log Message:
Counting leap years was fine while we had 32bit time_t - but now it
is not a good idea for dates far away in the future.
For dates in the year 2000 or later, use arithmetic instead (since the
repeating periods are well aligned). Should fix PR 49144.

To generate a diff of this commit:
cvs rdiff -u -r1.20 -r1.21 src/sys/dev/clock_subr.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

| Paul Goyette | PGP Key fingerprint: | E-mail addresses:   |
| (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at|
| Network Engineer | 0786 F758 55DE 53BA 7731 | pgoyette at |
| Kernel Developer |  | pgoyette at  |

Re: CVS commit: src/sys/dev

2014-09-06 Thread Martin Husemann
On Sat, Sep 06, 2014 at 11:42:14AM -0700, Paul Goyette wrote:
 +i = year / 100;
 +days += i * DAYS100YEARS;
 +year -= i * 100;
 Shouldn't this one be
   days -= i * DAYS100YEARS;

We are converting years to days, starting days with the number of days
to 2000-01-01 (from the epoch), decrementing year for years we have
handled already, summing up the result in days.

So year goes down, days goes up.


Re: CVS commit: src/common/lib/libprop

2014-09-06 Thread David Holland
On Fri, Sep 05, 2014 at 05:19:25AM +, Matt Thomas wrote:
  Modified Files:
   src/common/lib/libprop: prop_ingest.c prop_number.c
  Log Message:
  Eliminate use of C++ keywords and don't nest struct definitions.

Why do we care if proppropliblib compiles in a C++ compiler? It is C

David A. Holland

Re: CVS commit: src/sys/external/bsd/drm/dist/shared-core

2014-09-06 Thread Matt Thomas

On Sep 6, 2014, at 12:28 PM, Cherry G. Mathew wrote:

 Hi Matt,
 This doesn't fix drm2 i915 breakage. Could you revisit this please, since 
 it's in external/ ?

If I revert, it still won't build.  So no.

i915 shouldn't be using enum pipe since it conflicts with struct pipe.