Re: CVS commit: src/sys/sys

2014-11-16 Thread Martin Husemann
On Sun, Nov 16, 2014 at 09:27:26PM -0500, Christos Zoulas wrote: > Module Name: src > Committed By: christos > Date: Mon Nov 17 02:27:26 UTC 2014 > > Added Files: > src/sys/sys: clock.h > > Log Message: > PR/49207: Kamil Rytarowski: Centralize and rename a bunch of clock constants

Re: CVS commit: src/sys

2014-11-16 Thread Ryota Ozaki
On Mon, Nov 17, 2014 at 6:58 AM, matthew green wrote: > > "Ryota Ozaki" writes: >> Module Name: src >> Committed By: ozaki-r >> Date: Sun Nov 16 16:20:01 UTC 2014 >> >> Modified Files: >> src/sys/arch/x86/pci: fwhrng.c >> src/sys/arch/x86/x86: via_padlock.c >> src/sys/de

re: CVS commit: src/sys/dev/videomode

2014-11-16 Thread matthew green
"Jared D. McNeill" writes: > Module Name: src > Committed By: jmcneill > Date: Mon Nov 17 00:46:04 UTC 2014 > > Modified Files: > src/sys/dev/videomode: edid.c edidreg.h edidvar.h > > Log Message: > Parse the extension block count field, and make it available in struct > edid_inf

re: CVS commit: src/sys

2014-11-16 Thread matthew green
"Ryota Ozaki" writes: > Module Name: src > Committed By: ozaki-r > Date: Sun Nov 16 16:20:01 UTC 2014 > > Modified Files: > src/sys/arch/x86/pci: fwhrng.c > src/sys/arch/x86/x86: via_padlock.c > src/sys/dev/bluetooth: bcsp.c btkbd.c > src/sys/dev/ic: nslm7x.c >

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-16 Thread Christos Zoulas
On Nov 17, 5:50am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/sys/arch/atari/stand/installboot | christos@ wrote: | | > Yes be16enc() should work just fine, I think. | | Then why don't you guys also complain to fix existing abcksum() function | which is calle

re: CVS commit: src/distrib/atari/floppies/common

2014-11-16 Thread matthew green
"Izumi Tsutsui" writes: > Module Name: src > Committed By: tsutsui > Date: Sun Nov 16 11:54:29 UTC 2014 > > Modified Files: > src/distrib/atari/floppies/common: Makefile.images > > Log Message: > Use "-Os -m68020-60" for DBG. It seems to generate smaller objects than -Os. > > gcc

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-16 Thread Izumi Tsutsui
christos@ wrote: > Yes be16enc() should work just fine, I think. Then why don't you guys also complain to fix existing abcksum() function which is called at the suggested memcpy? --- /* set AHDI checksum */ sum = 0; memcpy(bb->bb_xxboot + 255 * sizeof(sum), &sum, sizeof(s

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-16 Thread Christos Zoulas
On Nov 16, 6:07pm, campbell+netbsd-source-change...@mumble.net (Taylor R Campbell) wrote: -- Subject: Re: CVS commit: src/sys/arch/atari/stand/installboot |Date: Mon, 17 Nov 2014 01:37:37 +0900 |From: Izumi Tsutsui | |> Changing `*(uint16_t *)p = v' to `memcpy(p, &v, 2)' doesn't ch

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-16 Thread Taylor R Campbell
Date: Mon, 17 Nov 2014 01:37:37 +0900 From: Izumi Tsutsui > Changing `*(uint16_t *)p = v' to `memcpy(p, &v, 2)' doesn't change any > of that. The formar can be easily changed *(uint16_t *)p = htobe16(v); but the latter can't. You might be able to use functions like host1

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-16 Thread Christos Zoulas
On Nov 17, 1:37am, tsut...@ceres.dti.ne.jp (Izumi Tsutsui) wrote: -- Subject: Re: CVS commit: src/sys/arch/atari/stand/installboot | Then what's your point? | Should we always strictly use memcpy even in MD code you won't maintain? | | If you really don't like current code, I'd still like to ke

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-16 Thread Izumi Tsutsui
> It's access via two different pointers, which happen to have the same > bits by virtue of being stored in a union -- the union doesn't > actually do anything about aliasing of the pointed-to object, except > probably confuse gcc. > > The point is that you can't get at one object in memory throug

Re: CVS commit: src/sys/arch/atari/stand/installboot

2014-11-16 Thread Taylor R Campbell
Date: Sun, 16 Nov 2014 12:51:34 +0900 From: Izumi Tsutsui My understanding is the strict aliasing rule is referred by compiler for reorder optimization etc. If the access via union is still invalid, why does the strict gcc48 no longer complain against it? It's access via two diff

Re: CVS commit: src/sys

2014-11-16 Thread Antti Kantee
On 15/11/14 23:46, Takeshi Nakayama wrote: Justin Cormack wrote Er, you can't do that. 1. It breaks the rump builds on most platforms http://build.myriabit.eu:8012/waterfall as the prototypes dont match eg see http://build.myriabit.eu:8012/builders/ppc64-cross/builds/5585/steps/shell_3/logs

Re: CVS commit: src/sys

2014-11-16 Thread Justin Cormack
On Sun, Nov 16, 2014 at 12:21 AM, Takeshi Nakayama wrote: Takeshi Nakayama wrote > >> >>> Justin Cormack wrote >> >> > Er, you can't do that. >> > >> > 1. It breaks the rump builds on most platforms >> > http://build.myriabit.eu:8012/waterfall as the prototypes dont match >> > eg see >> >