Re: CVS commit: src/lib/libc/gen

2014-11-26 Thread Christos Zoulas
In article 20141126164843.5cdd...@cvs.netbsd.org, Christos Zoulas source-changes-d@NetBSD.org wrote: -=-=-=-=-=- Module Name: src Committed By: christos Date: Wed Nov 26 16:48:43 UTC 2014 Modified Files: src/lib/libc/gen: opendir.c Log Message: - Use O_DIRECTORY to open the

Re: CVS commit: src/sys/net

2014-11-26 Thread Matt Thomas
On Nov 26, 2014, at 1:38 AM, Ryota Ozaki ozak...@netbsd.org wrote: Module Name: src Committed By: ozaki-r Date: Wed Nov 26 09:38:42 UTC 2014 Modified Files: src/sys/net: if.c if.h Log Message: Change if_slowtimo_ch to a pointer One benefit to do so is to reduce

Re: CVS commit: src/sys/net

2014-11-26 Thread Ryota Ozaki
On Thu, Nov 27, 2014 at 10:30 AM, Matt Thomas m...@3am-software.com wrote: On Nov 26, 2014, at 1:38 AM, Ryota Ozaki ozak...@netbsd.org wrote: Module Name: src Committed By: ozaki-r Date: Wed Nov 26 09:38:42 UTC 2014 Modified Files: src/sys/net: if.c if.h Log Message:

Re: CVS commit: src/sys/net

2014-11-26 Thread Masao Uebayashi
Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ?

Re: CVS commit: src/sys/net

2014-11-26 Thread Masao Uebayashi
On Thu, Nov 27, 2014 at 10:51 AM, Masao Uebayashi uebay...@gmail.com wrote: Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ? Or completely hide sizeof(struct ifnet) by forcing use of if_alloc(), as struct device did.

Re: CVS commit: src/sys/net

2014-11-26 Thread Ryota Ozaki
On Thu, Nov 27, 2014 at 10:51 AM, Masao Uebayashi uebay...@gmail.com wrote: Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ? I thought the version bump is required because a member has been changed (a struct to a pointer). So IIUC the spare members don't help for

Re: CVS commit: src/sys/net

2014-11-26 Thread Ryota Ozaki
On Thu, Nov 27, 2014 at 10:55 AM, Masao Uebayashi uebay...@gmail.com wrote: On Thu, Nov 27, 2014 at 10:51 AM, Masao Uebayashi uebay...@gmail.com wrote: Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ? Or completely hide sizeof(struct ifnet) by forcing use of

Re: CVS commit: src/sys/net

2014-11-26 Thread Ryota Ozaki
On Thu, Nov 27, 2014 at 11:39 AM, matthew green m...@eterna.com.au wrote: Ryota Ozaki writes: On Thu, Nov 27, 2014 at 10:51 AM, Masao Uebayashi uebay...@gmail.com wrote: Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ? I thought the version bump is required

Re: CVS commit: src/sys/net

2014-11-26 Thread Masao Uebayashi
On Thu, Nov 27, 2014 at 11:39 AM, matthew green m...@eterna.com.au wrote: hiding stuff inside an alloc doesn't really help much when the kernel code needs to access the structure anyway, unless you also hide all accesses to the structure inside functions. Right. And some members, including

Re: CVS commit: src/sys/net

2014-11-26 Thread Matt Thomas
On Nov 26, 2014, at 5:55 PM, Masao Uebayashi uebay...@gmail.com wrote: On Thu, Nov 27, 2014 at 10:51 AM, Masao Uebayashi uebay...@gmail.com wrote: Maybe adding a few spare members, like 5 pointers, to reduce # of bumps ... ? Or completely hide sizeof(struct ifnet) by forcing use of

Re: CVS commit: src/sys/net

2014-11-26 Thread Masao Uebayashi
On Thu, Nov 27, 2014 at 4:20 PM, Matt Thomas m...@3am-software.com wrote: Or completely hide sizeof(struct ifnet) by forcing use of if_alloc(), as struct device did. Doesn't work since struct ifnet is embedded in ethercom/fddicom Right. I mean, I want to make them alloc'ed to improve