Re: CVS commit: xsrc/external/mit/MesaLib/dist/src/mapi

2015-01-24 Thread Joerg Sonnenberger
On Sat, Jan 24, 2015 at 12:52:36PM +1100, matthew green wrote:
 
 Joerg Sonnenberger writes:
  Module Name:xsrc
  Committed By:   joerg
  Date:   Fri Jan 23 12:09:27 UTC 2015
  
  Modified Files:
  xsrc/external/mit/MesaLib/dist/src/mapi: entry_x86-64_tls.h
  entry_x86_tls.h entry_x86_tsd.h
  
  Log Message:
  Don't declare zero sized static objects, which is invalid in C.
  Inline assembler is used to populate them, which is a horrible hack.
  Make the hack work with clang by declaring the objects as hidden
  instead.
 
 hmm, if you're going to touch these files we don't use, can you
 fix them so that we can use them? :-)

At least one of the x86 versions is used, the rest is just a mechanical
copy of the same change for consistency.

Joerg


re: CVS commit: xsrc/external/mit/MesaLib/dist/src/mapi

2015-01-24 Thread matthew green

Joerg Sonnenberger writes:
 On Sat, Jan 24, 2015 at 12:52:36PM +1100, matthew green wrote:
  
  Joerg Sonnenberger writes:
   Module Name:  xsrc
   Committed By: joerg
   Date: Fri Jan 23 12:09:27 UTC 2015
   
   Modified Files:
 xsrc/external/mit/MesaLib/dist/src/mapi: entry_x86-64_tls.h
 entry_x86_tls.h entry_x86_tsd.h
   
   Log Message:
   Don't declare zero sized static objects, which is invalid in C.
   Inline assembler is used to populate them, which is a horrible hack.
   Make the hack work with clang by declaring the objects as hidden
   instead.
  
  hmm, if you're going to touch these files we don't use, can you
  fix them so that we can use them? :-)
 
 At least one of the x86 versions is used, the rest is just a mechanical
 copy of the same change for consistency.

where is it used?  the i386 versions were disabled shortly to
your change, because they don't work.

please revert this for now, unless you're going to work on fixing
them...


.mrg.