Re: CVS commit: src/sys
On Wed, Feb 25, 2015 at 12:49 PM, Ryota Ozaki wrote: > On Sun, Feb 22, 2015 at 9:53 AM, Christos Zoulas wrote: >> Module Name:src >> Committed By: christos >> Date: Sun Feb 22 00:53:29 UTC 2015 >> >> Modified Files: >> src/sys/kern: init_sysent.c syscalls.c >> src/sys/rump/include/rump: rump_syscalls.h >> src/sys/sys: syscall.h syscallargs.h > > I think you forgot to commit sys/rump/librump/rumpkern/rump_syscalls.c. > > ozaki-r BTW don't we need to change sys/compat/netbsd32 as well? ozaki-r > >> >> Log Message: >> PR/49684: Pierre Pronchery: readlinkat(2) return type is wrong. >> >> >> To generate a diff of this commit: >> cvs rdiff -u -r1.288 -r1.289 src/sys/kern/init_sysent.c >> cvs rdiff -u -r1.279 -r1.280 src/sys/kern/syscalls.c >> cvs rdiff -u -r1.80 -r1.81 src/sys/rump/include/rump/rump_syscalls.h >> cvs rdiff -u -r1.275 -r1.276 src/sys/sys/syscall.h >> cvs rdiff -u -r1.258 -r1.259 src/sys/sys/syscallargs.h >> >> Please note that diffs are not public domain; they are subject to the >> copyright notices on the relevant files. >>
Re: CVS commit: src/sys
On Sun, Feb 22, 2015 at 9:53 AM, Christos Zoulas wrote: > Module Name:src > Committed By: christos > Date: Sun Feb 22 00:53:29 UTC 2015 > > Modified Files: > src/sys/kern: init_sysent.c syscalls.c > src/sys/rump/include/rump: rump_syscalls.h > src/sys/sys: syscall.h syscallargs.h I think you forgot to commit sys/rump/librump/rumpkern/rump_syscalls.c. ozaki-r > > Log Message: > PR/49684: Pierre Pronchery: readlinkat(2) return type is wrong. > > > To generate a diff of this commit: > cvs rdiff -u -r1.288 -r1.289 src/sys/kern/init_sysent.c > cvs rdiff -u -r1.279 -r1.280 src/sys/kern/syscalls.c > cvs rdiff -u -r1.80 -r1.81 src/sys/rump/include/rump/rump_syscalls.h > cvs rdiff -u -r1.275 -r1.276 src/sys/sys/syscall.h > cvs rdiff -u -r1.258 -r1.259 src/sys/sys/syscallargs.h > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. >
Re: CVS commit: src/sys/ufs/ffs
On Mon, Feb 23, 2015 at 01:38:54PM +, Maxime Villard wrote: > Modified Files: > src/sys/ufs/ffs: ffs_vfsops.c > > Log Message: > Small changes: > - instead of always calling DPRINTF with __func__, put __func__ directly >in the macro > - ffs_mountfs(): rename fsblockloc -> fs_sblockloc, initialize fs_sbsize >to zero > No real functional change Those two really should have been committed separately though. -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/sys/dev/pci
On Feb 24, 11:28am, nona...@gmail.com (NONAKA Kimihiro) wrote: -- Subject: Re: CVS commit: src/sys/dev/pci | 2015-02-24 0:25 GMT+09:00 Christos Zoulas : | | > Please revert the fix then, or check the coverity website for the | > explanation why it thinks that the index can be 15. It does not | > seem possible from my cursory examination and we don't sandbag the | > code against impossible errors. It is probably a coverity false | > positive. | | I've revert this change. | I don't know how to look the full coverity report. Would you mind to teach me? First go to http://scan.coverity.com and create an account. Send me mail once you do this and I can approve you. After that you can visit that website to view the results. Thanks! christos