Re: CVS commit: src/sys/dev/bluetooth
On Wed, 29 Apr 2015, Christos Zoulas wrote: > On Apr 29, 4:27pm, m...@m00nbsd.net (Maxime Villard) wrote: > -- Subject: Re: CVS commit: src/sys/dev/bluetooth > > | You didn't test this change, nor did you test the five other fixes > | you committed. > > I checked the code to the best of my ability; perhaps I missed something. by the way, the Brainy code scanner did not pick them up (perhaps it stops at the first one?) but when I looked briefly at this code, there seem other calls to bcsp_tx_unreliable_pkt() which also leak the mbuf on failure, since if it fails it does not free it? iain
Re: CVS commit: src/sys/dev/bluetooth
Le 27/04/2015 19:36, Christos Zoulas a écrit : > Module Name: src > Committed By: christos > Date: Mon Apr 27 17:36:41 UTC 2015 > > Modified Files: > src/sys/dev/bluetooth: bcsp.c > > Log Message: > free mbuf on failure (Brainy) > > > To generate a diff of this commit: > cvs rdiff -u -r1.25 -r1.26 src/sys/dev/bluetooth/bcsp.c > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. > > When I say "Please carefully test/investigate these bugs before fixing them" I mean "Please carefully test/investigate these bugs before fixing them". You didn't test this change, nor did you test the five other fixes you committed. So now please revert them all.
Re: CVS commit: src/sys/arch
Hello, On Wed, 29 Apr 2015 20:12:40 +0900 Masao Uebayashi wrote: > On Wed, Apr 29, 2015 at 5:32 PM, Hikaru Abe wrote: > > Log Message: > > Initial import of Cavium Octeon and Octeon Plus SoC and > > specifically Ubiquiti Networks EdgeRouter LITE support. > > Currently the ethernet and uart of are worked. > > This support was contributed by Internet Initiative Japan Inc. > > USB is working with dwc2 code base on OpenBSD. FYI. And our dwctwo works on MIPS ( ci20's got one ) have fun Michael
Re: CVS commit: src/sys/arch
On Wed, Apr 29, 2015 at 08:32:01AM +, Hikaru Abe wrote: > Module Name: src > Committed By: hikaru > Date: Wed Apr 29 08:32:01 UTC 2015 > > Modified Files: > src/sys/arch/mips/conf: files.mips > src/sys/arch/mips/include: cpuregs.h locore.h > src/sys/arch/mips/mips: cache.c mips_machdep.c > Added Files: > src/sys/arch/evbmips/cavium: autoconf.c mach_intr.c machdep.c > octeon_bootbus_machdep.c octeon_uboot.h > src/sys/arch/evbmips/conf: ERLITE files.octeon > src/sys/arch/mips/cavium: autoconf.h mainbus.c mainbus_octeon1p.c > octeon1p_iobus.c octeon_bootbus.c octeon_dma.c octeon_intr.c > octeon_iobus.c octeonvar.h > src/sys/arch/mips/cavium/dev: if_cnmac.c if_cnmacvar.h octeon_asx.c > octeon_asxreg.h octeon_asxvar.h octeon_bootbusreg.h octeon_ciu.c > octeon_ciureg.h octeon_cop2reg.h octeon_cop2var.h octeon_corereg.h > octeon_fau.c octeon_faureg.h octeon_fauvar.h octeon_fpa.c > octeon_fpareg.h octeon_fpavar.h octeon_gmx.c octeon_gmxreg.h > octeon_gmxvar.h octeon_gpioreg.h octeon_iobreg.h octeon_ipd.c > octeon_ipdreg.h octeon_ipdvar.h octeon_l2creg.h octeon_mpi.c > octeon_mpireg.h octeon_mpivar.h octeon_npireg.h octeon_pci.c > octeon_pcmreg.h octeon_pip.c octeon_pipreg.h octeon_pipvar.h > octeon_pko.c octeon_pkoreg.h octeon_pkovar.h octeon_pow.c > octeon_powreg.h octeon_powvar.h octeon_rnm.c octeon_rnmreg.h > octeon_smi.c octeon_smireg.h octeon_smivar.h octeon_tim.c > octeon_timreg.h octeon_twsi.c octeon_twsireg.h octeon_uart.c > octeon_uartreg.h octeon_usbc.c octeon_usbcreg.h octeon_usbcvar.h > octeon_usbn.c octeon_usbnreg.h octeon_usbnvar.h > src/sys/arch/mips/cavium/include: bootbusvar.h iobusvar.h mainbusvar.h > src/sys/arch/mips/conf: files.octeon std.octeon > src/sys/arch/mips/include: cache_octeon.h > src/sys/arch/mips/mips: cache_octeon.c locore_octeon.S > > Log Message: > Initial import of Cavium Octeon and Octeon Plus SoC and > specifically Ubiquiti Networks EdgeRouter LITE support. > Currently the ethernet and uart of are worked. > This support was contributed by Internet Initiative Japan Inc. Way cool - many thanks to you and IIJ! Best, Alistair
Re: CVS commit: src/sys/dev/bluetooth
On Apr 29, 4:27pm, m...@m00nbsd.net (Maxime Villard) wrote: -- Subject: Re: CVS commit: src/sys/dev/bluetooth | You didn't test this change, nor did you test the five other fixes | you committed. I checked the code to the best of my ability; perhaps I missed something. | So now please revert them all. Is the reason for that punitive? Because I fail to understand how that helps. christos
Re: CVS commit: src/sys/arch
On Wed, Apr 29, 2015 at 5:32 PM, Hikaru Abe wrote: > Log Message: > Initial import of Cavium Octeon and Octeon Plus SoC and > specifically Ubiquiti Networks EdgeRouter LITE support. > Currently the ethernet and uart of are worked. > This support was contributed by Internet Initiative Japan Inc. USB is working with dwc2 code base on OpenBSD. FYI.
