Re: CVS commit: src/sys/dev

2015-05-05 Thread Michael van Elst
On Tue, May 05, 2015 at 07:47:09PM -0400, Greg Troxel wrote: > > "Michael van Elst" writes: > > > Modified Files: > > src/sys/dev: dksubr.c > > > > Log Message: > > warn about labels only when built with DIAGNOSTIC > > This feels like an abuse of DIAGNOSTIC, which is supposed to be about >

re: CVS commit: src/sys/arch

2015-05-05 Thread matthew green
Paul Goyette writes: > GENERIC kernels already include at least one instance of sensor, > watch-dog, and power-switch, so all the sysmon sub-component drivers > are included and "built-in" whether or not the kernel is MODULAR. > (Confirm by running modstat(8) and observe that all symon modules > a

re: CVS commit: src/sys/arch

2015-05-05 Thread Paul Goyette
GENERIC kernels already include at least one instance of sensor, watch-dog, and power-switch, so all the sysmon sub-component drivers are included and "built-in" whether or not the kernel is MODULAR. (Confirm by running modstat(8) and observe that all symon modules are "built-in".) It seems to m

re: CVS commit: src/sys/arch

2015-05-05 Thread matthew green
> For i386 and amd64: > > non-XEN GENERIC is MODULAR, and the sysmon drivers will be autoloaded as > necesary. Confirmed by successful running of atf test suite. it MODULAR, but it is supposed to have all common drivers in it. autoloading isn't something you can depend on. .mrg.

Re: CVS commit: src/sys/dev

2015-05-05 Thread Greg Troxel
"Michael van Elst" writes: > Modified Files: > src/sys/dev: dksubr.c > > Log Message: > warn about labels only when built with DIAGNOSTIC This feels like an abuse of DIAGNOSTIC, which is supposed to be about asserts for detecting internal inconsistencies, not changing the behavior of how

re: CVS commit: src/sys/arch

2015-05-05 Thread Paul Goyette
For i386 and amd64: non-XEN GENERIC is MODULAR, and the sysmon drivers will be autoloaded as necesary. Confirmed by successful running of atf test suite. For other platforms: MODULAR kernels are unaffected, as drivers will be autoloaded. Non-MODULAR kernels will contain sysmon sub-component

re: CVS commit: src/sys/arch

2015-05-05 Thread matthew green
"Paul Goyette" writes: > Module Name: src > Committed By: pgoyette > Date: Tue May 5 22:14:24 UTC 2015 > > Modified Files: > src/sys/arch/amd64/conf: XEN3_DOMU > src/sys/arch/i386/conf: XEN3_DOMU > > Log Message: > For non-modular XEN3_DOMU kernels, include sysmon and all o

Re: CVS commit: src/sys/dev/sysmon

2015-05-05 Thread Paul Goyette
On Tue, 5 May 2015, Christos Zoulas wrote: | >> If module_autoload() returns an error, just return that value instead | >> of overwriting with ENODEV. | >> | > | > Yes, but break before the mutex_enter... | | Need to hold the mutex so we can release it below... Return error then? Yeah, possib

Re: CVS commit: src/sys/dev/sysmon

2015-05-05 Thread Christos Zoulas
On May 5, 10:22am, p...@vps1.whooppee.com (Paul Goyette) wrote: -- Subject: Re: CVS commit: src/sys/dev/sysmon | On Tue, 5 May 2015, Christos Zoulas wrote: | | > In article <20150505002825.9e50...@cvs.netbsd.org>, | > Paul Goyette wrote: | >> -=-=-=-=-=- | >> | >> Module Name: src | >> Com