Re: CVS commit: src/usr.sbin/rpcbind
In article <20150509225426.ga28...@netbsd.org>, David Holland wrote: >On Sat, May 09, 2015 at 05:22:18PM -0400, Christos Zoulas wrote: > > Modified Files: > > src/usr.sbin/rpcbind: rpcbind.c > > > > Log Message: > > use EXIT_SUCCESS/EXIT_FAILURE consistently. > > > > > > To generate a diff of this commit: > > cvs rdiff -u -r1.21 -r1.22 src/usr.sbin/rpcbind/rpcbind.c > >heh, I just stuck EXIT_FAILURE in the one I added because it was new. > >that said, > >- exit(2); >+ exit(EXIT_FAILURE); > >I wonder if anything depended on that being 2 and not 1. Heh, I am willing to bet 10 to 1 up to $100 that nothing will break, just for the pleasure to rant about what broke with the author of the breakage. christos
Re: CVS commit: src/usr.sbin/rpcbind
On Sat, May 09, 2015 at 05:22:18PM -0400, Christos Zoulas wrote: > Modified Files: > src/usr.sbin/rpcbind: rpcbind.c > > Log Message: > use EXIT_SUCCESS/EXIT_FAILURE consistently. > > > To generate a diff of this commit: > cvs rdiff -u -r1.21 -r1.22 src/usr.sbin/rpcbind/rpcbind.c heh, I just stuck EXIT_FAILURE in the one I added because it was new. that said, - exit(2); + exit(EXIT_FAILURE); I wonder if anything depended on that being 2 and not 1. -- David A. Holland dholl...@netbsd.org
Re: CVS commit: src/usr.sbin/sysinst
On May 9, 4:48pm, mar...@duskware.de (Martin Husemann) wrote:
-- Subject: Re: CVS commit: src/usr.sbin/sysinst
| On Sat, May 09, 2015 at 01:52:06PM +, Christos Zoulas wrote:
| > Doesn't the -g -O0 belong in ${DBG}?
|
| Maybe (but CPPFLAGS is where it was before).
It happens to work, but that does not make it right.
| > Also, perhaps O0TRACKING can be automatically provided if ${DBG} has
| > -O0 in the *.mk files?
|
| Not sure if that is worth the effort.
|
Neither am I, but it is useful knowledge (the flags).
christos
Re: CVS commit: src/usr.sbin/sysinst
On Sat, May 09, 2015 at 01:52:06PM +, Christos Zoulas wrote:
> Doesn't the -g -O0 belong in ${DBG}?
Maybe (but CPPFLAGS is where it was before).
> Also, perhaps O0TRACKING can be automatically provided if ${DBG} has
> -O0 in the *.mk files?
Not sure if that is worth the effort.
Martin
Re: CVS commit: src/usr.sbin/sysinst
In article <20150509061542.2227...@cvs.netbsd.org>,
Martin Husemann wrote:
>-=-=-=-=-=-
>
>Module Name: src
>Committed By: martin
>Date: Sat May 9 06:15:42 UTC 2015
>
>Modified Files:
> src/usr.sbin/sysinst: Makefile.inc
>
>Log Message:
>Make gcc generate better debug info when building with DEBUG set.
>
>
>To generate a diff of this commit:
>cvs rdiff -u -r1.5 -r1.6 src/usr.sbin/sysinst/Makefile.inc
>
>Please note that diffs are not public domain; they are subject to the
>copyright notices on the relevant files.
>
>
>-=-=-=-=-=-
>
>Modified files:
>
>Index: src/usr.sbin/sysinst/Makefile.inc
>diff -u src/usr.sbin/sysinst/Makefile.inc:1.5
>src/usr.sbin/sysinst/Makefile.inc:1.6
>--- src/usr.sbin/sysinst/Makefile.inc:1.5 Wed Aug 6 12:16:12 2014
>+++ src/usr.sbin/sysinst/Makefile.inc Sat May 9 06:15:42 2015
>@@ -1,4 +1,4 @@
>-# $NetBSD: Makefile.inc,v 1.5 2014/08/06 12:16:12 martin Exp $
>+# $NetBSD: Makefile.inc,v 1.6 2015/05/09 06:15:42 martin Exp $
> #
> # Makefile for sysinst
>
>@@ -55,7 +55,12 @@ CPPFLAGS+= -I. -I${.CURDIR}/../.. -I${.C
> -DCATALOG_DIR=\"${CATALOGDIR}\"
>
> .if (defined(DEBUG))
>-CPPFLAGS+=-DDEBUG -g -O0
>+.if ${ACTIVE_CC} == "gcc"
>+# make gcc run additional passes for better debug info (only needed
>+# when compiling with -O0)
>+O0TRACKING= -fvar-tracking-assignments -fvar-tracking
>+.endif
>+CPPFLAGS+=-DDEBUG -g -O0 ${O0TRACKING}
> .endif
Doesn't the -g -O0 belong in ${DBG}?
Also, perhaps O0TRACKING can be automatically provided if ${DBG} has
-O0 in the *.mk files?
christos
Re: CVS commit: src/distrib/notes
snj@ wrote: > Modified Files: : > src/distrib/notes/x68k: legal > > Log Message: > first pass de-suckification for 2015. modernize content a bit, fix dirty > rotten lies, improve wording, sync legalese with reality, yada yada yada. : > cvs rdiff -u -r1.6 -r1.7 src/distrib/notes/x68k/legal >> @@ -13,6 +13,4 @@ >> .It >> This product includes software developed by MINOURA Makoto. >> .It >> -This product includes software developed by Yasushi YAMASAKI. >> -.It >> This product includes software developed by ITOH Yasufumi. Files under xsrc/xfree/xc/programs/Xserver/hw/netbsd/x68k/ and xsrc/external/mit/xorg-server/dist/hw/netbsd/x68k/ still have the following clauses: >> * 3. All advertising materials mentioning features or use of this software >> *must display the following acknowledgement: >> * This product includes software developed by Yasushi Yamasaki (though cases were different) On the other hand I wonder if we still need itohy@'s entry... --- Izumi Tsutsui
Re: CVS commit: [netbsd-7] src
On 2015/05/09 17:37, SAITOH Masanobu wrote: > Module Name: src > Committed By: msaitoh > Date: Sat May 9 08:37:32 UTC 2015 > > Modified Files: > src/distrib/evbarm/instkernel/sshramdisk [netbsd-7]: Makefile > src/sys/arch/evbarm/conf [netbsd-7]: RPI_INSTALL > > Log Message: > Pull up following revision(s) (requested by snj in ticket #1957): s/1957/742/ > distrib/evbarm/instkernel/sshramdisk/Makefile patch > sys/arch/evbarm/conf/RPI_INSTALL patch > > Increase ramdisk size to fix build break. > > > To generate a diff of this commit: > cvs rdiff -u -r1.3.6.1 -r1.3.6.2 \ > src/distrib/evbarm/instkernel/sshramdisk/Makefile > cvs rdiff -u -r1.3 -r1.3.4.1 src/sys/arch/evbarm/conf/RPI_INSTALL > > Please note that diffs are not public domain; they are subject to the > copyright notices on the relevant files. > -- --- SAITOH Masanobu (msai...@execsw.org msai...@netbsd.org)
