Re: CVS commit: [netbsd-7] src/sbin/raidctl

2015-06-08 Thread Christos Zoulas
In article 20150608204801.c85e...@cvs.netbsd.org,
Soren Jacobsen source-changes-d@NetBSD.org wrote:
-=-=-=-=-=-

Module Name:   src
Committed By:  snj
Date:  Mon Jun  8 20:48:01 UTC 2015

Modified Files:
   src/sbin/raidctl [netbsd-7]: raidctl.c

Log Message:
Pull up following revision(s) (requested by manu in ticket #827):
   sbin/raidctl/raidctl.c: revision 1.58
Better sanity check numbers given to raidctl(8)
Replace atoi(3) by strtol(3), and check that numbers are valid,
positive, and in int32_t range. The previous lack of check could
silently lead to the same serial being set to all RAID volumes
for instance because given numbers were bigger than INT_MAX. The
consequence is in an awful mess when RAIDframe would mix volumes...

This has typos and it is easier to use strtou like in the next version.

christos



Re: CVS commit: src/sys/arch/mips

2015-06-08 Thread Roy Marples

On 06/06/2015 22:44, Matt Thomas wrote:

Module Name:src
Committed By:   matt
Date:   Sat Jun  6 21:44:17 UTC 2015

Modified Files:
src/sys/arch/mips/cavium: octeon_cpunode.c
src/sys/arch/mips/mips: genassym.cf

Log Message:
Use ci_nmi_stack


To generate a diff of this commit:
cvs rdiff -u -r1.2 -r1.3 src/sys/arch/mips/cavium/octeon_cpunode.c
cvs rdiff -u -r1.57 -r1.58 src/sys/arch/mips/mips/genassym.cf


+#if NWDOG  0 || defined(DDB)
+	void **nmi_vector = (void *)MIPS_PHYS_TO_KSEG0(0x800 + 
32*ci-ci_cpuid);

+   *nmi_vector = octeon_reset_vector;
+
+   struct vm_page * const pg = mips_pmap_alloc_poolpage(UVM_PGA_ZERO);
+   KASSERT(pg != NULL);
+   const vaddr_t kva = mips_pmap_map_poolpage(VM_PAGE_TO_PHYS(pg));
+   KASSERT(kva != 0);
+   ci-ci_xnext = (void *)(kva + PAGE_SIZE - sizeof(struct kernframe));
+#endif

octeon_reset_vector is only available for MULTIPROCESSOR, so this fails
to link.