Re: CVS commit: src/lib/libpanel

2015-11-01 Thread Paul Goyette 

On Sun, 1 Nov 2015, Robert Elz wrote:


   Date:Sun, 1 Nov 2015 08:54:37 +
   From:"Thomas Klausner" 
   Message-ID:  <20151101085437.75bf...@cvs.netbsd.org>

 | Modified Files:
 |  src/lib/libpanel: panel_above.3
 |
 | Log Message:
 | Improve wording.

It would be even better, more precise, and more useful,
if it said ...


The bottom and the top panels can be obtained by passing a


Less wordy, and perhaps easier to say (at least for an American English 
speaker:


  The bottom and top panels can be obtained by passing a

:)



.Dv NULL
argument to
.Fn panel_above
and
.Fn panel_below ,
respectively.


kre




+--+--+-+
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:   |
| (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com|
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org  |
+--+--+-+

Re: CVS commit: src/lib/libpanel

2015-11-01 Thread Thomas Klausner 
On Sun, Nov 01, 2015 at 05:47:41PM +0700, Robert Elz wrote:
> Date:Sun, 1 Nov 2015 08:54:37 +
> From:"Thomas Klausner" 
> Message-ID:  <20151101085437.75bf...@cvs.netbsd.org>
> 
>   | Modified Files:
>   |   src/lib/libpanel: panel_above.3
>   | 
>   | Log Message:
>   | Improve wording.
> 
> It would be even better, more precise, and more useful,
> if it said ...
> 
> 
> The bottom and the top panels can be obtained by passing a
> .Dv NULL
> argument to
> .Fn panel_above
> and
> .Fn panel_below ,
> respectively.

Thanks, committed. I switched "bottom" and "top" though :)
 Thomas

Re: CVS commit: src/lib/libpanel

2015-11-01 Thread Robert Elz 
Date:Sun, 1 Nov 2015 11:02:24 +
From:"Thomas Klausner" 
Message-ID:  <20151101110224.0f63...@cvs.netbsd.org>

  | Modified Files:
  | src/lib/libpanel: panel_above.3
  | 
  | Log Message:
  | Improve wording even more, suggested by Robert Elz.

You changed the of "bottom and top" to "top and bottom".

While I agree that's a more common usage, if you're going to do
that you also need to swap the order of the functions.

panel_above(NULL) -> the bottom panel, panel_below(NULL) -> the top one.

kre

ps: I also agree with Paul, the extra "the", while not incorrect, makes
it harder to read.