Re: CVS commit: src/crypto/external/bsd/netpgp/dist/src

2017-02-21 Thread Pierre Pronchery
Hey, On 20/02/2017 03:40, Alistair Crooks wrote: Thanks, but I'd really like it if netpgp would work the same on all pkgsrc platforms: The linux man page for getpass(3) (https://linux.die.net/man/3/getpass) says: The function *getpass*() returns a pointer to a static bu

Re: CVS commit: src/sys/dev

2017-02-21 Thread Robert Elz
Date:Tue, 21 Feb 2017 20:23:37 + From:"Nathanial Sloss" Message-ID: <20170221202337.a4c46f...@cvs.netbsd.org> | Modified Files: | src/sys/dev: audio.c In addition to Christos' comments, I see this pattern (in the diff) repeated a few times... +

Re: CVS commit: src/sys/dev

2017-02-21 Thread Christos Zoulas
In article <20170221202337.a81e5f...@cvs.netbsd.org>, Nathanial Sloss wrote: >-=-=-=-=-=- > >virtual_channel *vc) > { >+ struct audio_chan *vchan; >+ bool found = false; Overinitialization here ^. > int error; > > KASSERT(mutex_owned(sc->sc_lock)); >@@ -1526,6 +1529,16 @@