Re: CVS commit: src/sys/arch/amd64/conf

2017-08-15 Thread Martin Husemann
On Tue, Aug 15, 2017 at 04:33:19PM +0200, Maxime Villard wrote: > So we agree? Each compat should be independent. Yes. > It seems to me that > re-implementing (copy-paste) a few functions for linux is a step towards > direction, isn't it? No, it isn't (but it MAY be ok for real trivial ones).

Re: CVS commit: src/sys/arch/amd64/conf

2017-08-15 Thread Maxime Villard
Le 15/08/2017 à 14:50, Martin Husemann a écrit : On Tue, Aug 15, 2017 at 02:48:39PM +0200, Maxime Villard wrote: Why is it a bad idea re-implement the few compat_xx functions used in compat_linux? This would eliminate the dependency, and a single modload would suffice. Move them into a common

Re: CVS commit: src/sys/arch/amd64/conf

2017-08-15 Thread Martin Husemann
On Tue, Aug 15, 2017 at 02:48:39PM +0200, Maxime Villard wrote: > Why is it a bad idea re-implement the few compat_xx functions used in > compat_linux? This would eliminate the dependency, and a single modload > would suffice. Move them into a common module required by all current consumers.

Re: CVS commit: src/sys/arch/amd64/conf

2017-08-15 Thread Maxime Villard
Le 04/08/2017 à 10:00, matthew green a écrit : the setup comes from before modules and it allows code sharing because the old 43 version matches other systems. so there's a single implementation of this code for a large number of consumers, and the name of it describes where it comes from. this