Re: CVS commit: src/sys/ddb

2018-02-16 Thread Paul Goyette 

Please make sure to update the options(4) and ddb(4) man pages...


On Sat, 17 Feb 2018, Sevan Janiyan wrote:


Module Name:src
Committed By:   sevan
Date:   Sat Feb 17 00:41:09 UTC 2018

Modified Files:
src/sys/ddb: db_panic.c db_variables.c ddbvar.h

Log Message:
Opt to print a backtrace on panic by default with the intention of improving 
bug reports.
Instead of relying on ddb.onpanic=2, introduce a new sysctl called dumpstack to 
handle this.
via  channeled through  on tech-kern[1]

[1] https://mail-index.netbsd.org/tech-kern/2018/02/15/msg023103.html


To generate a diff of this commit:
cvs rdiff -u -r1.6 -r1.7 src/sys/ddb/db_panic.c
cvs rdiff -u -r1.45 -r1.46 src/sys/ddb/db_variables.c
cvs rdiff -u -r1.12 -r1.13 src/sys/ddb/ddbvar.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


!DSPAM:5a877a2b294491653810109!




+--+--++
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:  |
| (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+--+--++

re: CVS commit: src/sys/arch

2018-02-16 Thread matthew green 
thanks for doing this.  it will make sanitizer_linux.cc's
port for GetPcSpBp() *much* simplier.

> Module Name:  src
> Committed By: kamil
> Date: Thu Feb 15 15:53:57 UTC 2018
> 
> Modified Files:
>   src/sys/arch/sparc/include: mcontext.h

this doesn't seem right.  at least, it does not match
the usage from libsanitizer:

  uptr *stk_ptr;
#  if defined (__arch64__)
  stk_ptr = (uptr *) (*sp + 2047);
#  else
  stk_ptr = (uptr *) *sp;
#  endif
  *bp = stk_ptr[15];

i don't understand either ofthe sparc versions you have.

+ #define   _UC_MACHINE_FP(uc)  
(((uc)->uc_mcontext.__gregs[_REG_O6])+0x80e)
+ #define   _UC_MACHINE_FP(uc)  
(((uc)->uc_mcontext.__gregs[_REG_O6])+0xf)

both of these grab something invalid and will likely
cause a run-time unaligned access fault as the result
will be aligned to 0x3.  there's an extra deref here
in the sparc case that is needed.  oh, i see where the
additional 0xf offset comes from.  you've conflated
byte and word sizes here.  the 64 bit stack pointer
is offset by -2047 from its actual value.  that's a
byte address.  the 15 is an array offset, which is
either 4 or 8 bytes.

the rest of them seem right as well as i could tell,
given ia64 is kind of a wreck..


.mrg.

re: CVS commit: src/sys/modules/pf

2018-02-16 Thread matthew green 
"Joerg Sonnenberger" writes:
> Module Name:  src
> Committed By: joerg
> Date: Mon Feb 12 22:18:36 UTC 2018
> 
> Modified Files:
>   src/sys/modules/pf: Makefile
> 
> Log Message:
> Simplify and make the GCC check more precise at the same time.

! .if ${HAVE_GCC:U0} == "6"

FWIW, i usually to write these as ">= 6", as these sorts of
problems tend to not disappear with a newer GCC.


.mrg.