Re: CVS commit: src/sys

2018-03-14 Thread Paul Goyette
This change seems to work only with built-in COMPAT_{13,50} code;  it 
does not appear that it would work if it is not built-in, even if the

compat_netbsd module is loaded.

I've changed it differently on the [pgoyette-compat] branch, in a manner 
that allows the code to be built-in or modularly loaded after boot.




On Wed, 14 Mar 2018, Christos Zoulas wrote:


Module Name:src
Committed By:   christos
Date:   Thu Mar 15 00:48:13 UTC 2018

Modified Files:
src/sys/compat/netbsd32: netbsd32_netbsd.c
src/sys/sys: param.h
src/sys/uvm: uvm_swap.c uvm_swap.h

Log Message:
Untangle the swapctl compat code mess. Welcome to lucky 13.


To generate a diff of this commit:
cvs rdiff -u -r1.214 -r1.215 src/sys/compat/netbsd32/netbsd32_netbsd.c
cvs rdiff -u -r1.557 -r1.558 src/sys/sys/param.h
cvs rdiff -u -r1.175 -r1.176 src/sys/uvm/uvm_swap.c
cvs rdiff -u -r1.22 -r1.23 src/sys/uvm/uvm_swap.h

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


!DSPAM:5aa9c2f364906872211511!




+--+--++
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:  |
| (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+--+--++


re: CVS commit: [pgoyette-compat] src/sys/conf

2018-03-14 Thread Paul Goyette

Ack - reverted.

Thanks again for keeping me honest.


On Thu, 15 Mar 2018, matthew green wrote:


"Paul Goyette" writes:

Module Name:src
Committed By:   pgoyette
Date:   Wed Mar 14 21:46:51 UTC 2018

Modified Files:
src/sys/conf [pgoyette-compat]: files

Log Message:
COMPAT_43 is even older than COMPAT_09, so if _43 is enabled, we'll
need everything newer as well.


this isn't traditionally how we did COMPAT_43.  it's more
"enable obsolete interfaces", which is not quite the same
as "make old binaries work".

eg, they enable the old sgtty interfaces that _are_ still
visible and potentially callable from modern binaries.
we still install the headers for this interfaces.

COMPAT_09 enables old binaries with changed interfaces.

i think you should revert this part, untying them.


.mrg.

!DSPAM:5aa99da1134231867360323!




+--+--++
| Paul Goyette | PGP Key fingerprint: | E-mail addresses:  |
| (Retired)| FA29 0E3B 35AF E8AE 6651 | paul at whooppee dot com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd dot org |
+--+--++


re: CVS commit: [pgoyette-compat] src/sys/conf

2018-03-14 Thread matthew green
"Paul Goyette" writes:
> Module Name:  src
> Committed By: pgoyette
> Date: Wed Mar 14 21:46:51 UTC 2018
> 
> Modified Files:
>   src/sys/conf [pgoyette-compat]: files
> 
> Log Message:
> COMPAT_43 is even older than COMPAT_09, so if _43 is enabled, we'll
> need everything newer as well.

this isn't traditionally how we did COMPAT_43.  it's more
"enable obsolete interfaces", which is not quite the same
as "make old binaries work".

eg, they enable the old sgtty interfaces that _are_ still
visible and potentially callable from modern binaries.
we still install the headers for this interfaces.

COMPAT_09 enables old binaries with changed interfaces.

i think you should revert this part, untying them.


.mrg.


re: CVS commit: src/distrib/sets/lists/xdebug

2018-03-14 Thread matthew green
"Rin Okuyama" writes:
> Module Name:  src
> Committed By: rin
> Date: Wed Mar 14 13:23:31 UTC 2018
> 
> Modified Files:
>   src/distrib/sets/lists/xdebug: md.i386
> 
> Log Message:
> Restore shlib version accidentally bumped in the previous commit.
> Fix debug build for i386.

this seems incorrect.

for x86, the ati driver should be .so.18 and the ati_old should
be .so.6.  for everyone else (aka non-drm), only ati should be
around at .so.6.


.mrg.