Re: CVS commit: src/sys/netinet
Date:Sat, 31 Mar 2018 03:07:29 + From:Taylor R Campbell Message-ID: <20180331030950.2325d60...@jupiter.mumble.net> | but a passive observer can't tell the difference between | one colleague joshing another and someone saying `you're an idiot and | I cleaned up your mess'. I totally agree with this - and it is worse when included in commit logs wherte it will remain, visible, and actually viewed, forever (unlike even in a mailing list, which while archived forever, somewhere, usually falls quickly out of view.) If you feel the need to (in a friendly, or not-so way) to make sure the developer who got things wrong knows about it, send e-mail. That's probably a good idea in any case, their view on how to fix it might be different than yours. If you need a fix quickly, make it in your local tree - it is not required that all changes be committed the instant you finish typing them! If you think it likely that others might be seeing the same problem, send your fix to the appropriate mailing list. If whoever broke things then doesn't fix it, or ask you to go ahead and commit your fix, within a reasonable time, then the fix can just be committed (but by this time, the use for a "hi xxx" will have long since passed). kre
Re: CVS commit: src/sys/netinet
> Date: Thu, 29 Mar 2018 23:53:42 +0100 > From: Alexander Nasonov > > m...@netbsd.org wrote: > > I seem to recall a discussion about wanting to avoid this type > > of commit message (hi dev-name), as it can be seen as excessively > > hostile. > > 'ok rmind@' would definitely be better than 'hi maxv@'. > > Hostile? I don't think so. I personally quite like it. They mean different things. `hi dev@' means `FYI, dev@, you broke this, so I'm fixing it'. `ok dev@' means `dev@ reviewed and approved this change'. One connotation of `hi dev@' may be `dev@ is an idiot'; it can be offputting -- and it's not really necessary to call them out publicly. Sometimes dev@ has a rapport with the committer and will take it as good-natured, but a passive observer can't tell the difference between one colleague joshing another and someone saying `you're an idiot and I cleaned up your mess'.
Re: CVS commit: src/share/man/man4/man4.macppc
Hi. > +.An Tsubai Masanari Aq Mt tsu...@netbsd.org Tsubai is inactive, according to status file his account is suspended. Will anyone be able to reach him via this address? If not, then I am not sure if retroactively adding his address makes sense. Best regards, Radoslaw signature.asc Description: Message signed with OpenPGP
Re: CVS commit: src/sys/netinet
In article , Maxime Villard wrote: >Le 30/03/2018 à 00:34, m...@netbsd.org a écrit : >> On Thu, Mar 29, 2018 at 09:40:53PM +, Mindaugas Rasiukevicius wrote: >>> Module Name:src >>> Committed By: rmind >>> Date: Thu Mar 29 21:40:53 UTC 2018 >>> >>> Modified Files: >>> src/sys/netinet: tcp_input.c >>> >>> Log Message: >>> tcp_urp_drop: fix a bug introduced in 1.390 rev (hi maxv@). >>> >> >> I seem to recall a discussion about wanting to avoid this type >> of commit message (hi dev-name), as it can be seen as excessively >> hostile. > >Well, I don't care, I prefer to be told that I'm wrong this way, rather >than not being told I'm wrong at all. I don't mind either :-) We all make mistakes. christos
