Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Robert Elz
Date:Tue, 12 Jun 2018 19:52:43 +0200 From:Kamil Rytarowski Message-ID: <90519caf-289c-b4d3-7ebc-d14d4efc9...@gmx.com> | I will try to meet the expectations in commit messages for *San fixes. That would be good (and not just those, unless the board required it,

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Kamil Rytarowski
On 12.06.2018 15:52, Joerg Sonnenberger wrote: > On Tue, Jun 12, 2018 at 02:35:40PM +0200, Kamil Rytarowski wrote: >> On 12.06.2018 14:24, Joerg Sonnenberger wrote: >>> That's missing the point. A short description of why the specific >>> undefined behavior is seen is useful. Pasting random

Re: CVS commit: src/bin/ksh

2018-06-12 Thread Valery Ushakov
On Tue, Jun 12, 2018 at 14:13:55 +, Kamil Rytarowski wrote: > UBSan can detect that during switching a login to root there is unportable > left shift operation: > > $ su - > Password: > /public/src.git/bin/ksh/eval.c:598:13: runtime error: left shift of > 1073741824 by 1 places cannot be

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Joerg Sonnenberger
On Tue, Jun 12, 2018 at 02:35:40PM +0200, Kamil Rytarowski wrote: > On 12.06.2018 14:24, Joerg Sonnenberger wrote: > > That's missing the point. A short description of why the specific > > undefined behavior is seen is useful. Pasting random program output is > > not. > > > > Joerg > > > >

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Kamil Rytarowski
On 12.06.2018 14:24, Joerg Sonnenberger wrote: > On Tue, Jun 12, 2018 at 12:00:01PM +0200, Kamil Rytarowski wrote: >> On 12.06.2018 11:51, matthew green wrote: On 12.06.2018 10:28, Kamil Rytarowski wrote: > On 12.06.2018 09:04, Martin Husemann wrote: >> On Tue, Jun 12, 2018 at

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Kamil Rytarowski
On 12.06.2018 11:51, matthew green wrote: >> On 12.06.2018 10:28, Kamil Rytarowski wrote: >>> On 12.06.2018 09:04, Martin Husemann wrote: On Tue, Jun 12, 2018 at 05:47:35AM +0300, Valery Ushakov wrote: > To sum it up, out of 30+ lines of the commit message, the relevant > information

re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread matthew green
>On 12.06.2018 10:28, Kamil Rytarowski wrote: >> On 12.06.2018 09:04, Martin Husemann wrote: >>> On Tue, Jun 12, 2018 at 05:47:35AM +0300, Valery Ushakov wrote: To sum it up, out of 30+ lines of the commit message, the relevant information is contained only in (part of) one line. >>> >>>

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Kamil Rytarowski
On 12.06.2018 10:28, Kamil Rytarowski wrote: > On 12.06.2018 09:04, Martin Husemann wrote: >> On Tue, Jun 12, 2018 at 05:47:35AM +0300, Valery Ushakov wrote: >>> To sum it up, out of 30+ lines of the commit message, the relevant >>> information is contained only in (part of) one line. >> >> FWIW,

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Kamil Rytarowski
On 12.06.2018 09:04, Martin Husemann wrote: > On Tue, Jun 12, 2018 at 05:47:35AM +0300, Valery Ushakov wrote: >> To sum it up, out of 30+ lines of the commit message, the relevant >> information is contained only in (part of) one line. > > FWIW, I fully agree with uwe here. > > Martin > I find

Re: CVS commit: src/usr.bin/gzip

2018-06-12 Thread Martin Husemann
On Tue, Jun 12, 2018 at 05:47:35AM +0300, Valery Ushakov wrote: > To sum it up, out of 30+ lines of the commit message, the relevant > information is contained only in (part of) one line. FWIW, I fully agree with uwe here. Martin