Re: CVS commit: src/sys

2018-08-10 Thread Taylor R Campbell
> Date: Fri, 10 Aug 2018 19:11:54 +0100 > From: Nick Hudson > > On 10/08/2018 19:08, Taylor R Campbell wrote: > >> Date: Fri, 10 Aug 2018 18:54:10 +0100 > >> From: Nick Hudson > >> > >> The second bug should never occur as the intention was for drivers to > >> always use xfers until detach and

Re: CVS commit: src/sys

2018-08-10 Thread Paul Goyette
On Fri, 10 Aug 2018, Jason Thorpe wrote: Oops? Yeah I accidentally used -m $logmsg on the cvs commit command, rather than -f $logmsg so it put the filename in the log rather than the file contents. I've fixed the message using cvs admin; yeah, I know we prefer not to do cvs admin, but it was

Re: CVS commit: src/sys

2018-08-10 Thread Nick Hudson
On 10/08/2018 19:08, Taylor R Campbell wrote: Date: Fri, 10 Aug 2018 18:54:10 +0100 From: Nick Hudson On 10/08/2018 07:31, Taylor R Campbell wrote: 2. The callout can run after usbd_free_xfer -- use-after-free. The fix for the second bug is simple: use callout_halt (and usb_rem_task_wait)

Re: CVS commit: src/sys/arch

2018-08-10 Thread Leonardo Taccari
Hello Sevan, "Sevan Janiyan" writes: > Module Name: src > Committed By: sevan > Date: Fri Aug 10 17:54:46 UTC 2018 > > Modified Files: > src/sys/arch/amd64/conf: GENERIC > src/sys/arch/i386/conf: GENERIC > > Log Message: > Add snippet for bpfjit(4) as both i386 and amd64 are

Re: CVS commit: src/sys

2018-08-10 Thread Taylor R Campbell
> Date: Fri, 10 Aug 2018 18:54:10 +0100 > From: Nick Hudson > > On 10/08/2018 07:31, Taylor R Campbell wrote: > > 2. The callout can run after usbd_free_xfer -- use-after-free. > > > > The fix for the second bug is simple: use callout_halt (and > > usb_rem_task_wait) in usbd_free_xfer, rather

Re: CVS commit: src/sys

2018-08-10 Thread Nick Hudson
On 10/08/2018 07:31, Taylor R Campbell wrote: [snip] pull across abort fixes from nick-nhusb. add more abort fixes, using ideas from Taylor and Nick, and myself. special thanks to both who inspired much of the code here, if not wrote it directly. Unfortunately, there is a hole in this

Re: CVS commit: src/sys

2018-08-10 Thread Taylor R Campbell
> Module Name:src > Committed By: mrg > Date: Thu Aug 9 06:26:47 UTC 2018 > > Modified Files: > src/sys/dev/usb: ehci.c ehcivar.h motg.c ohci.c ohcivar.h uhci.c > uhcivar.h usbdi.c usbdivar.h xhci.c