Re: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)

2018-08-18 Thread Nick Hudson
On 19/08/2018 01:02, Rin Okuyama wrote: Oops, I forgot to CC to source-changes-d@. [snip] On 2018/08/19 3:48, matthew green wrote: can't we make arm and arm64 use the identical majors file? please! Diff between majors.arm32 and aarch64 reads [snip] - ctcom was added by matt@ back in

Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf)

2018-08-18 Thread Rin Okuyama
Oops, I forgot to CC to source-changes-d@. Forwarded Message Subject: Merge majors.{arm32,aarch64} into single file (Re: CVS commit: src/sys/arch/evbarm/conf) To: matthew green Cc: Jared McNeill , Nick Hudson , Ryo Shimizu From: Rin Okuyama Date: Sun, 19 Aug 2018 08:57:53

Re: CVS commit: src/sys/arch/evbarm/conf

2018-08-18 Thread Rin Okuyama
On 2018/08/19 1:11, Jason Thorpe wrote: On Aug 18, 2018, at 8:49 AM, Rin Okuyama wrote: ... "ifdef" statements refer "attrtab", whose entries are not normalized to lower-case. Therefore, "ifdef arm32" becomes false even if we have "options ARM32", as I wrote in the previous message:

re: CVS commit: src/sys/arch/evbarm/conf

2018-08-18 Thread matthew green
can't we make arm and arm64 use the identical majors file? please! .mrg.

Re: CVS commit: src/sys/arch/evbarm/conf

2018-08-18 Thread Jason Thorpe
> On Aug 18, 2018, at 8:49 AM, Rin Okuyama wrote: > > On 2018/08/19 0:06, Jason Thorpe wrote: >>> On 2018/08/18 20:08, Rin Okuyama wrote: Ah, then it should be "if ARM32". It was "if arm32" in rev. 1.31. >>> >>> Sorry, not 1.31 but 1.30. >> That's because all options are normalized to

Re: CVS commit: src/lib/libc/arch/aarch64/softfloat

2018-08-18 Thread Ryo Shimizu
>On Sat, Aug 11, 2018 at 10:06:41AM +, Ryo Shimizu wrote: >> Module Name: src >> Committed By:ryo >> Date:Sat Aug 11 10:06:41 UTC 2018 >> >> Modified Files: >> src/lib/libc/arch/aarch64/softfloat: qp.c >> >> Log Message: >> fix multiple definition of

Re: CVS commit: src/sys/arch/evbarm/conf

2018-08-18 Thread Jared McNeill
On Sun, 19 Aug 2018, Rin Okuyama wrote: On 2018/08/18 22:41, Jared McNeill wrote: Not sure I understand this change. arm32 should be defined on 32-bit evbarm platforms via std.evbarm. If arm32 is not defined, I wouldn't expect a kernel to link as there are dependencies on it in

Re: CVS commit: src/sys/arch/evbarm/conf

2018-08-18 Thread Rin Okuyama
On 2018/08/19 0:06, Jason Thorpe wrote: On 2018/08/18 20:08, Rin Okuyama wrote: Ah, then it should be "if ARM32". It was "if arm32" in rev. 1.31. Sorry, not 1.31 but 1.30. That's because all options are normalized to lower-case. Oops, not "if" but "ifdef". "ifdef" statements refer

Re: CVS commit: src/sys/arch/evbarm/conf

2018-08-18 Thread Rin Okuyama
On 2018/08/18 22:41, Jared McNeill wrote: Not sure I understand this change. arm32 should be defined on 32-bit evbarm platforms via std.evbarm. If arm32 is not defined, I wouldn't expect a kernel to link as there are dependencies on it in arch/arm/conf/files.arm as well. No "arm32" is not

Re: CVS commit: src/sys/arch/evbarm/conf

2018-08-18 Thread Jason Thorpe
> On Aug 18, 2018, at 7:59 AM, Rin Okuyama wrote: > > On 2018/08/18 20:08, Rin Okuyama wrote: >> Ah, then it should be "if ARM32". It was "if arm32" in rev. 1.31. > > Sorry, not 1.31 but 1.30. That's because all options are normalized to lower-case. -- thorpej

Re: CVS commit: src/sys/arch/evbarm/conf

2018-08-18 Thread Rin Okuyama
On 2018/08/18 20:08, Rin Okuyama wrote: Ah, then it should be "if ARM32". It was "if arm32" in rev. 1.31. Sorry, not 1.31 but 1.30. On 2018/08/18 18:51, Nick Hudson wrote: On 18/08/2018 10:29, Rin Okuyama wrote: Module Name:    src Committed By:    rin Date:    Sat Aug 18 09:29:45 UTC

Re: CVS commit: src/sys/arch/evbarm/conf

2018-08-18 Thread Jared McNeill
Not sure I understand this change. arm32 should be defined on 32-bit evbarm platforms via std.evbarm. If arm32 is not defined, I wouldn't expect a kernel to link as there are dependencies on it in arch/arm/conf/files.arm as well. On Sat, 18 Aug 2018, Rin Okuyama wrote: Module Name:

Re: CVS commit: src/sys/arch/evbarm/conf

2018-08-18 Thread Rin Okuyama
Ah, then it should be "if ARM32". It was "if arm32" in rev. 1.31. On 2018/08/18 18:51, Nick Hudson wrote: On 18/08/2018 10:29, Rin Okuyama wrote: Module Name:    src Committed By:    rin Date:    Sat Aug 18 09:29:45 UTC 2018 Modified Files: src/sys/arch/evbarm/conf: files.evbarm Log

Re: CVS commit: src/sys/arch/evbarm/conf

2018-08-18 Thread Nick Hudson
On 18/08/2018 10:29, Rin Okuyama wrote: Module Name:src Committed By: rin Date: Sat Aug 18 09:29:45 UTC 2018 Modified Files: src/sys/arch/evbarm/conf: files.evbarm Log Message: Fix a bug introduced in the previous revision; We don't define arm32 anywhere, and