Re: CVS commit: src/sys/arch/arm/broadcom

2018-10-20 Thread Jared McNeill 

On Sat, 20 Oct 2018, Ryo Shimizu wrote:


I think the dts should be fixed rather than #ifdef __arm__


I agree that we need to change dts to eliminate 32bit enable method from
the dtb for 64bit. However, it is also strange that enable-method code
for 32bit ARM remains in the 64bit binary as well.


I don't think the dts should be changed. This lets use share a dtb between 
32- and 64-bit kernels. The brcm,bcm2836-smp enable-method is documented 
as being supported only in 32-bit mode:


https://www.kernel.org/doc/Documentation/devicetree/bindings/arm/cpus.txt

Re: CVS commit: src/sys/arch/arm/broadcom

2018-10-20 Thread Ryo Shimizu 


>On 20/10/2018 06:53, Ryo Shimizu wrote:
>> Module Name: src
>> Committed By:ryo
>> Date:Sat Oct 20 05:53:22 UTC 2018
>> 
>> Modified Files:
>>  src/sys/arch/arm/broadcom: bcm283x_platform.c
>> 
>> Log Message:
>> - fix AP spinup on bcm283x
>> - "brcm,bcm2836-smp" is a enable-method for only 32bit bcm2836.
>
>
>I think the dts should be fixed rather than #ifdef __arm__

I agree that we need to change dts to eliminate 32bit enable method from
the dtb for 64bit. However, it is also strange that enable-method code
for 32bit ARM remains in the 64bit binary as well.

-- 
ryo shimizu

Re: CVS commit: src/sys/arch/arm/broadcom

2018-10-20 Thread Nick Hudson 




On 20/10/2018 08:19, Ryo Shimizu wrote:

On 20/10/2018 06:53, Ryo Shimizu wrote:

Module Name:src
Committed By:   ryo
Date:   Sat Oct 20 05:53:22 UTC 2018

Modified Files:
src/sys/arch/arm/broadcom: bcm283x_platform.c

Log Message:
- fix AP spinup on bcm283x
- "brcm,bcm2836-smp" is a enable-method for only 32bit bcm2836.


I think the dts should be fixed rather than #ifdef __arm__

I agree that we need to change dts to eliminate 32bit enable method from
the dtb for 64bit.


Cool


  However, it is also strange that enable-method code
for 32bit ARM remains in the 64bit binary as well.

Lots more code in GENERIC64 than this little snippet that won't ever get 
used, e.g. SOC_{RK*,TEGRA,SUN*,etc} on RPI3


Nick

Re: CVS commit: src/sys/arch/arm/broadcom

2018-10-20 Thread Nick Hudson 

On 20/10/2018 06:53, Ryo Shimizu wrote:

Module Name:src
Committed By:   ryo
Date:   Sat Oct 20 05:53:22 UTC 2018

Modified Files:
src/sys/arch/arm/broadcom: bcm283x_platform.c

Log Message:
- fix AP spinup on bcm283x
- "brcm,bcm2836-smp" is a enable-method for only 32bit bcm2836.



I think the dts should be fixed rather than #ifdef __arm__

Thanks,
Nick

Re: CVS commit: src/sys/arch/arm/rockchip

2018-10-20 Thread Nick Hudson 

On 20/10/2018 06:38, Ryo Shimizu wrote:

Module Name:src
Committed By:   ryo
Date:   Sat Oct 20 05:38:27 UTC 2018

Modified Files:
src/sys/arch/arm/rockchip: rk_platform.c

Log Message:
add missing .ap_mpstart for rk3399

Thanks,
Nick