In article <20190109092730.00052f...@cvs.netbsd.org>,
Martin Husemann <source-changes-d@NetBSD.org> wrote:

> aslcompilerparse.y: aslparser.y
>-      ${TOOL_M4} -P -I${TOPDIR} ${.ALLSRC} > ${.TARGET}
>+      ${TOOL_M4} -P -I${TOPDIR} ${.ALLSRC} > ${.TARGET}.tmp \
>+      && mv ${.TARGET}.tmp ${.TARGET}

Looks to me like one process can be writing the tmp file while another
is moving it, so that reduces the race window but does not eliminate it.

It is probably better to use a unique name like "$$$$" instead of "tmp".
Or create a special make builtin variable for that use :-)

christos

Reply via email to